Browse Source

Polishing (backported from 5.3.x)

pull/28694/head
Juergen Hoeller 5 years ago
parent
commit
e31d66cd2b
  1. 4
      spring-aop/src/main/java/org/aopalliance/intercept/Joinpoint.java
  2. 16
      spring-beans/src/test/java/org/springframework/beans/BeanWrapperGenericsTests.java
  3. 4
      spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RequestPredicate.java
  4. 4
      spring-webmvc/src/main/java/org/springframework/web/servlet/function/RequestPredicate.java
  5. 4
      spring-websocket/src/main/java/org/springframework/web/socket/adapter/standard/ConvertingEncoderDecoderSupport.java
  6. 2
      src/docs/asciidoc/web/websocket.adoc

4
spring-aop/src/main/java/org/aopalliance/intercept/Joinpoint.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2002-2016 the original author or authors.
* Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -23,7 +23,7 @@ import java.lang.reflect.AccessibleObject; @@ -23,7 +23,7 @@ import java.lang.reflect.AccessibleObject;
* terminology).
*
* <p>A runtime joinpoint is an <i>event</i> that occurs on a static
* joinpoint (i.e. a location in a the program). For instance, an
* joinpoint (i.e. a location in a program). For instance, an
* invocation is the runtime joinpoint on a method (static joinpoint).
* The static part of a given joinpoint can be generically retrieved
* using the {@link #getStaticPart()} method.

16
spring-beans/src/test/java/org/springframework/beans/BeanWrapperGenericsTests.java

@ -162,10 +162,8 @@ public class BeanWrapperGenericsTests { @@ -162,10 +162,8 @@ public class BeanWrapperGenericsTests {
value2.add(Boolean.TRUE);
input.put("2", value2);
bw.setPropertyValue("collectionMap", input);
boolean condition1 = gb.getCollectionMap().get(1) instanceof HashSet;
assertThat(condition1).isTrue();
boolean condition = gb.getCollectionMap().get(2) instanceof ArrayList;
assertThat(condition).isTrue();
assertThat(gb.getCollectionMap().get(1) instanceof HashSet).isTrue();
assertThat(gb.getCollectionMap().get(2) instanceof ArrayList).isTrue();
}
@Test
@ -177,8 +175,7 @@ public class BeanWrapperGenericsTests { @@ -177,8 +175,7 @@ public class BeanWrapperGenericsTests {
HashSet<Integer> value1 = new HashSet<>();
value1.add(1);
bw.setPropertyValue("collectionMap[1]", value1);
boolean condition = gb.getCollectionMap().get(1) instanceof HashSet;
assertThat(condition).isTrue();
assertThat(gb.getCollectionMap().get(1) instanceof HashSet).isTrue();
}
@Test
@ -324,14 +321,13 @@ public class BeanWrapperGenericsTests { @@ -324,14 +321,13 @@ public class BeanWrapperGenericsTests {
bw.setPropertyValue("mapOfInteger", map);
Object obj = gb.getMapOfInteger().get("testKey");
boolean condition = obj instanceof Integer;
assertThat(condition).isTrue();
assertThat(obj instanceof Integer).isTrue();
}
@Test
public void testGenericTypeNestingMapOfListOfInteger() {
Map<String, List<String>> map = new HashMap<>();
List<String> list = Arrays.asList(new String[] {"1", "2", "3"});
List<String> list = Arrays.asList("1", "2", "3");
map.put("testKey", list);
NestedGenericCollectionBean gb = new NestedGenericCollectionBean();
@ -362,7 +358,7 @@ public class BeanWrapperGenericsTests { @@ -362,7 +358,7 @@ public class BeanWrapperGenericsTests {
@Test
public void testGenericTypeNestingMapOfListOfListOfInteger() {
Map<String, List<List<String>>> map = new HashMap<>();
List<String> list = Arrays.asList(new String[] {"1", "2", "3"});
List<String> list = Arrays.asList("1", "2", "3");
map.put("testKey", Collections.singletonList(list));
NestedGenericCollectionBean gb = new NestedGenericCollectionBean();

4
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RequestPredicate.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2002-2019 the original author or authors.
* Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -71,7 +71,7 @@ public interface RequestPredicate { @@ -71,7 +71,7 @@ public interface RequestPredicate {
/**
* Transform the given request into a request used for a nested route. For instance,
* a path-based predicate can return a {@code ServerRequest} with a the path remaining
* a path-based predicate can return a {@code ServerRequest} with a path remaining
* after a match.
* <p>The default implementation returns an {@code Optional} wrapping the given request if
* {@link #test(ServerRequest)} evaluates to {@code true}; or {@link Optional#empty()}

4
spring-webmvc/src/main/java/org/springframework/web/servlet/function/RequestPredicate.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2002-2019 the original author or authors.
* Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -71,7 +71,7 @@ public interface RequestPredicate { @@ -71,7 +71,7 @@ public interface RequestPredicate {
/**
* Transform the given request into a request used for a nested route. For instance,
* a path-based predicate can return a {@code ServerRequest} with a the path remaining
* a path-based predicate can return a {@code ServerRequest} with a path remaining
* after a match.
* <p>The default implementation returns an {@code Optional} wrapping the given request if
* {@link #test(ServerRequest)} evaluates to {@code true}; or {@link Optional#empty()}

4
spring-websocket/src/main/java/org/springframework/web/socket/adapter/standard/ConvertingEncoderDecoderSupport.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2002-2020 the original author or authors.
* Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -183,7 +183,7 @@ public abstract class ConvertingEncoderDecoderSupport<T, M> { @@ -183,7 +183,7 @@ public abstract class ConvertingEncoderDecoderSupport<T, M> {
}
/**
* Decode the a message into an object.
* Decode the message into an object.
* @see javax.websocket.Decoder.Text#decode(String)
* @see javax.websocket.Decoder.Binary#decode(ByteBuffer)
*/

2
src/docs/asciidoc/web/websocket.adoc

@ -1202,7 +1202,7 @@ We can trace the flow through a simple example. Consider the following example, @@ -1202,7 +1202,7 @@ We can trace the flow through a simple example. Consider the following example,
@Controller
public class GreetingController {
@MessageMapping("/greeting") {
@MessageMapping("/greeting")
public String handle(String greeting) {
return "[" + getTimestamp() + ": " + greeting;
}

Loading…
Cancel
Save