From e1d71a30fd5c3a07f280f034d8caad96d2f3c3ef Mon Sep 17 00:00:00 2001 From: Andy Clement Date: Sun, 17 Aug 2008 01:25:43 +0000 Subject: [PATCH] fixing TODOs git-svn-id: https://src.springframework.org/svn/spring-framework/trunk@68 50f2f4bb-b051-0410-bef5-90022cba6387 --- .../expression/spel/standard/StandardEvaluationContext.java | 2 +- .../expression/spel/standard/StandardTypeConverter.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/org.springframework.expression/src/main/java/org/springframework/expression/spel/standard/StandardEvaluationContext.java b/org.springframework.expression/src/main/java/org/springframework/expression/spel/standard/StandardEvaluationContext.java index bd402139c28..8a7e7a7ebd6 100644 --- a/org.springframework.expression/src/main/java/org/springframework/expression/spel/standard/StandardEvaluationContext.java +++ b/org.springframework.expression/src/main/java/org/springframework/expression/spel/standard/StandardEvaluationContext.java @@ -170,7 +170,7 @@ public class StandardEvaluationContext implements EvaluationContext { rootObject = o; } - // TODO 3 have a variant that adds at position (same for ctor/propOrField) + // TODO have a variant that adds at position (same for ctor/propOrField) public void addMethodResolver(MethodResolver resolver) { methodResolvers.add(resolver); } diff --git a/org.springframework.expression/src/main/java/org/springframework/expression/spel/standard/StandardTypeConverter.java b/org.springframework.expression/src/main/java/org/springframework/expression/spel/standard/StandardTypeConverter.java index 28d7486566f..74aaa82108b 100644 --- a/org.springframework.expression/src/main/java/org/springframework/expression/spel/standard/StandardTypeConverter.java +++ b/org.springframework.expression/src/main/java/org/springframework/expression/spel/standard/StandardTypeConverter.java @@ -93,7 +93,7 @@ public class StandardTypeConverter implements TypeConverter { return false; } - // TODO 3 Q In case of a loss in information with coercion to a narrower type, should we throw an exception? + // TODO In case of a loss in information with coercion to a narrower type, should we throw an exception? public Object convertValue(Object value, Class targetType) throws SpelException { if (value == null || value.getClass() == targetType) return value; @@ -201,7 +201,7 @@ public class StandardTypeConverter implements TypeConverter { try { Double.parseDouble((String) value); } catch (NumberFormatException nfe) { - // TODO 3 Q throw something or leave the caller to throw a conversion exception? + // returning null will mean the caller throws a type conversion related exception } } else if (value instanceof Integer) { return new Double(((Integer) value).intValue());