Browse Source

ResolvableType.clearCache() clears SerializableTypeWrapper cache as well

Issue: SPR-15503
(cherry picked from commit 7ca0094)
pull/1420/head
Juergen Hoeller 9 years ago
parent
commit
d643e57318
  1. 5
      spring-core/src/main/java/org/springframework/core/ResolvableType.java
  2. 13
      spring-core/src/main/java/org/springframework/core/SerializableTypeWrapper.java

5
spring-core/src/main/java/org/springframework/core/ResolvableType.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2016 the original author or authors. * Copyright 2002-2017 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -1356,11 +1356,12 @@ public class ResolvableType implements Serializable {
} }
/** /**
* Clear the internal {@code ResolvableType} cache. * Clear the internal {@code ResolvableType}/{@code SerializableTypeWrapper} cache.
* @since 4.2 * @since 4.2
*/ */
public static void clearCache() { public static void clearCache() {
cache.clear(); cache.clear();
SerializableTypeWrapper.cache.clear();
} }

13
spring-core/src/main/java/org/springframework/core/SerializableTypeWrapper.java

@ -59,8 +59,7 @@ abstract class SerializableTypeWrapper {
private static final Class<?>[] SUPPORTED_SERIALIZABLE_TYPES = { private static final Class<?>[] SUPPORTED_SERIALIZABLE_TYPES = {
GenericArrayType.class, ParameterizedType.class, TypeVariable.class, WildcardType.class}; GenericArrayType.class, ParameterizedType.class, TypeVariable.class, WildcardType.class};
private static final ConcurrentReferenceHashMap<Type, Type> cache = static final ConcurrentReferenceHashMap<Type, Type> cache = new ConcurrentReferenceHashMap<Type, Type>(256);
new ConcurrentReferenceHashMap<Type, Type>(256);
/** /**
@ -84,7 +83,7 @@ abstract class SerializableTypeWrapper {
*/ */
@SuppressWarnings("serial") @SuppressWarnings("serial")
public static Type forGenericSuperclass(final Class<?> type) { public static Type forGenericSuperclass(final Class<?> type) {
return forTypeProvider(new DefaultTypeProvider() { return forTypeProvider(new SimpleTypeProvider() {
@Override @Override
public Type getType() { public Type getType() {
return type.getGenericSuperclass(); return type.getGenericSuperclass();
@ -100,7 +99,7 @@ abstract class SerializableTypeWrapper {
Type[] result = new Type[type.getGenericInterfaces().length]; Type[] result = new Type[type.getGenericInterfaces().length];
for (int i = 0; i < result.length; i++) { for (int i = 0; i < result.length; i++) {
final int index = i; final int index = i;
result[i] = forTypeProvider(new DefaultTypeProvider() { result[i] = forTypeProvider(new SimpleTypeProvider() {
@Override @Override
public Type getType() { public Type getType() {
return type.getGenericInterfaces()[index]; return type.getGenericInterfaces()[index];
@ -118,7 +117,7 @@ abstract class SerializableTypeWrapper {
Type[] result = new Type[type.getTypeParameters().length]; Type[] result = new Type[type.getTypeParameters().length];
for (int i = 0; i < result.length; i++) { for (int i = 0; i < result.length; i++) {
final int index = i; final int index = i;
result[i] = forTypeProvider(new DefaultTypeProvider() { result[i] = forTypeProvider(new SimpleTypeProvider() {
@Override @Override
public Type getType() { public Type getType() {
return type.getTypeParameters()[index]; return type.getTypeParameters()[index];
@ -198,10 +197,10 @@ abstract class SerializableTypeWrapper {
/** /**
* Default implementation of {@link TypeProvider} with a {@code null} source. * Base implementation of {@link TypeProvider} with a {@code null} source.
*/ */
@SuppressWarnings("serial") @SuppressWarnings("serial")
private static abstract class DefaultTypeProvider implements TypeProvider { private static abstract class SimpleTypeProvider implements TypeProvider {
@Override @Override
public Object getSource() { public Object getSource() {

Loading…
Cancel
Save