Browse Source

Increase randomness in SocketUtils

pull/859/head
Sam Brannen 11 years ago
parent
commit
d5944c4e39
  1. 7
      spring-core/src/main/java/org/springframework/util/SocketUtils.java

7
spring-core/src/main/java/org/springframework/util/SocketUtils.java

@ -19,7 +19,7 @@ package org.springframework.util; @@ -19,7 +19,7 @@ package org.springframework.util;
import java.net.DatagramSocket;
import java.net.InetAddress;
import java.net.ServerSocket;
import java.util.Random;
import java.security.SecureRandom;
import java.util.SortedSet;
import java.util.TreeSet;
import javax.net.ServerSocketFactory;
@ -53,9 +53,6 @@ public class SocketUtils { @@ -53,9 +53,6 @@ public class SocketUtils {
public static final int PORT_RANGE_MAX = 65535;
private static final Random random = new Random(System.currentTimeMillis());
/**
* Although {@code SocketUtils} consists solely of static utility methods,
* this constructor is intentionally {@code public}.
@ -238,7 +235,7 @@ public class SocketUtils { @@ -238,7 +235,7 @@ public class SocketUtils {
*/
private int findRandomPort(int minPort, int maxPort) {
int portRange = maxPort - minPort;
return minPort + random.nextInt(portRange);
return minPort + new SecureRandom().nextInt(portRange);
}
/**

Loading…
Cancel
Save