Browse Source

Polish gh-35358

Signed-off-by: Johnny Lim <izeye@naver.com>
pull/35407/head
Johnny Lim 4 months ago
parent
commit
d32b7e9b4a
  1. 2
      framework-docs/modules/ROOT/pages/integration/observability.adoc
  2. 9
      spring-web/src/main/java/org/springframework/http/server/observation/OpenTelemetryServerRequestObservationConvention.java

2
framework-docs/modules/ROOT/pages/integration/observability.adoc

@ -190,7 +190,7 @@ This observation uses the `io.micrometer.jakarta9.instrument.jms.DefaultJmsProce @@ -190,7 +190,7 @@ This observation uses the `io.micrometer.jakarta9.instrument.jms.DefaultJmsProce
== HTTP Server instrumentation
HTTP server exchange observations are created with the name `"http.server.requests"` for Servlet and Reactive applications,
or "http.server.request.duration" if using the OpenTelemetry convention.
or `"http.server.request.duration"` if using the OpenTelemetry convention.
[[observability.http-server.servlet]]
=== Servlet applications

9
spring-web/src/main/java/org/springframework/http/server/observation/OpenTelemetryServerRequestObservationConvention.java

@ -69,13 +69,6 @@ public class OpenTelemetryServerRequestObservationConvention implements ServerRe @@ -69,13 +69,6 @@ public class OpenTelemetryServerRequestObservationConvention implements ServerRe
private static final Set<String> HTTP_METHODS = Stream.of(HttpMethod.values()).map(HttpMethod::name).collect(Collectors.toUnmodifiableSet());
/**
* Create a convention.
*/
public OpenTelemetryServerRequestObservationConvention() {
}
@Override
public String getName() {
return NAME;
@ -87,7 +80,7 @@ public class OpenTelemetryServerRequestObservationConvention implements ServerRe @@ -87,7 +80,7 @@ public class OpenTelemetryServerRequestObservationConvention implements ServerRe
* SHOULD be {@code {method}}.
* <p>
* The {@code {method}} MUST be {@code {http.request.method}} if the method represents the original
* method known to the instrumentation. In other cases (when Customize Toolbar is
* method known to the instrumentation. In other cases (when {@code {http.request.method}} is
* set to {@code _OTHER}), {@code {method}} MUST be HTTP.
* <p>
* The {@code target} SHOULD be the {@code {http.route}}.

Loading…
Cancel
Save