From d232fffa63096811d2e157ef7a9057008ca60835 Mon Sep 17 00:00:00 2001 From: Kazuki MATSUDA Date: Sun, 18 Sep 2016 20:17:09 +0900 Subject: [PATCH] Use whenComplete since (null) return value not needed --- .../util/concurrent/CompletableToListenableFutureAdapter.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spring-core/src/main/java/org/springframework/util/concurrent/CompletableToListenableFutureAdapter.java b/spring-core/src/main/java/org/springframework/util/concurrent/CompletableToListenableFutureAdapter.java index c9b28a79a8e..42910bf902d 100644 --- a/spring-core/src/main/java/org/springframework/util/concurrent/CompletableToListenableFutureAdapter.java +++ b/spring-core/src/main/java/org/springframework/util/concurrent/CompletableToListenableFutureAdapter.java @@ -21,6 +21,7 @@ import java.util.concurrent.CompletionStage; import java.util.concurrent.ExecutionException; import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeoutException; +import java.util.function.BiConsumer; /** * Adapts a {@link CompletableFuture} or {@link CompletionStage} into a @@ -50,14 +51,13 @@ public class CompletableToListenableFutureAdapter implements ListenableFuture */ public CompletableToListenableFutureAdapter(CompletableFuture completableFuture) { this.completableFuture = completableFuture; - this.completableFuture.handle((result, ex) -> { + this.completableFuture.whenComplete((result, ex) -> { if (ex != null) { callbacks.failure(ex); } else { callbacks.success(result); } - return null; }); }