From 963cc09c2e742321413b29d94f390ce3f60a4799 Mon Sep 17 00:00:00 2001 From: Johnny Lim Date: Sun, 20 Jan 2019 10:25:15 +0900 Subject: [PATCH] Polish AutowireUtils.EXECUTABLE_COMPARATOR Closes gh-22283 --- .../beans/factory/support/AutowireUtils.java | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/spring-beans/src/main/java/org/springframework/beans/factory/support/AutowireUtils.java b/spring-beans/src/main/java/org/springframework/beans/factory/support/AutowireUtils.java index 0c7e29e39b8..5710a32f013 100644 --- a/spring-beans/src/main/java/org/springframework/beans/factory/support/AutowireUtils.java +++ b/spring-beans/src/main/java/org/springframework/beans/factory/support/AutowireUtils.java @@ -52,14 +52,8 @@ import org.springframework.util.ClassUtils; abstract class AutowireUtils { private static final Comparator EXECUTABLE_COMPARATOR = (e1, e2) -> { - boolean p1 = Modifier.isPublic(e1.getModifiers()); - boolean p2 = Modifier.isPublic(e2.getModifiers()); - if (p1 != p2) { - return (p1 ? -1 : 1); - } - int c1pl = e1.getParameterCount(); - int c2pl = e2.getParameterCount(); - return Integer.compare(c2pl, c1pl); + int result = Boolean.compare(Modifier.isPublic(e2.getModifiers()), Modifier.isPublic(e1.getModifiers())); + return result != 0 ? result : Integer.compare(e2.getParameterCount(), e1.getParameterCount()); };