From bab98498d019a6463c8e815269c958df0c884ee2 Mon Sep 17 00:00:00 2001
From: Keith Donald <kdonald@vmware.com>
Date: Wed, 22 Apr 2009 17:47:44 +0000
Subject: [PATCH] embedded

git-svn-id: https://src.springframework.org/svn/spring-framework/trunk@1051 50f2f4bb-b051-0410-bef5-90022cba6387
---
 .../jdbc/datasource/embedded/EmbeddedDatabaseBuilder.java       | 2 ++
 .../jdbc/datasource/embedded/EmbeddedDatabaseConfigurer.java    | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/org.springframework.jdbc/src/main/java/org/springframework/jdbc/datasource/embedded/EmbeddedDatabaseBuilder.java b/org.springframework.jdbc/src/main/java/org/springframework/jdbc/datasource/embedded/EmbeddedDatabaseBuilder.java
index ce77dd67f91..cb51166c87e 100644
--- a/org.springframework.jdbc/src/main/java/org/springframework/jdbc/datasource/embedded/EmbeddedDatabaseBuilder.java
+++ b/org.springframework.jdbc/src/main/java/org/springframework/jdbc/datasource/embedded/EmbeddedDatabaseBuilder.java
@@ -29,6 +29,8 @@ import org.springframework.core.io.ResourceLoader;
  * db.shutdown();
  * </pre>
  * 
+ * TODO - should we replace schema/testdata with more general 'script' method?
+ * 
  * @author Keith Donald
  */
 public class EmbeddedDatabaseBuilder {
diff --git a/org.springframework.jdbc/src/main/java/org/springframework/jdbc/datasource/embedded/EmbeddedDatabaseConfigurer.java b/org.springframework.jdbc/src/main/java/org/springframework/jdbc/datasource/embedded/EmbeddedDatabaseConfigurer.java
index 534277a8645..a96c753970e 100644
--- a/org.springframework.jdbc/src/main/java/org/springframework/jdbc/datasource/embedded/EmbeddedDatabaseConfigurer.java
+++ b/org.springframework.jdbc/src/main/java/org/springframework/jdbc/datasource/embedded/EmbeddedDatabaseConfigurer.java
@@ -23,6 +23,8 @@ import org.springframework.jdbc.datasource.SimpleDriverDataSource;
  * Encapsulates the configuration required to create, connect to, and shutdown a specific type of embedded database such as HSQLdb or H2.
  * Create a subclass for each database type we wish to support.
  * 
+ * TODO - introduce ConfigurableDataSource strategy for configuring connection properties?
+ * 
  * @see EmbeddedDatabaseConfigurerFactory
  */
 abstract class EmbeddedDatabaseConfigurer {