Browse Source

Polish

pull/1124/merge
Rossen Stoyanchev 9 years ago
parent
commit
b93579a43e
  1. 8
      spring-web/src/main/java/org/springframework/http/server/reactive/AbstractListenerWriteProcessor.java
  2. 14
      spring-web/src/main/java/org/springframework/http/server/reactive/ServletServerHttpResponse.java
  3. 4
      spring-web/src/main/java/org/springframework/http/server/reactive/UndertowServerHttpResponse.java

8
spring-web/src/main/java/org/springframework/http/server/reactive/AbstractListenerWriteProcessor.java

@ -163,11 +163,11 @@ public abstract class AbstractListenerWriteProcessor<T> implements Processor<T, @@ -163,11 +163,11 @@ public abstract class AbstractListenerWriteProcessor<T> implements Processor<T,
}
/**
* Invoked when an error happens while writing. Defaults to no-op.
* Servlet 3.1 based implementations will receive
* {@link WriteListener#onError(Throwable)} event.
* Invoked when an error happens while writing.
* <p>Defaults to no-op. Servlet 3.1 based implementations will receive
* {@code javax.servlet.WriteListener#onError(Throwable)} event.
*/
protected void writingFailed(Throwable t) {
protected void writingFailed(Throwable ex) {
}

14
spring-web/src/main/java/org/springframework/http/server/reactive/ServletServerHttpResponse.java

@ -192,9 +192,10 @@ public class ServletServerHttpResponse extends AbstractListenerServerHttpRespons @@ -192,9 +192,10 @@ public class ServletServerHttpResponse extends AbstractListenerServerHttpRespons
}
void handleError(Throwable ex) {
if (bodyFlushProcessor != null) {
bodyFlushProcessor.cancel();
bodyFlushProcessor.onError(ex);
ResponseBodyFlushProcessor flushProcessor = bodyFlushProcessor;
if (flushProcessor != null) {
flushProcessor.cancel();
flushProcessor.onError(ex);
}
ResponseBodyProcessor processor = bodyProcessor;
@ -206,9 +207,10 @@ public class ServletServerHttpResponse extends AbstractListenerServerHttpRespons @@ -206,9 +207,10 @@ public class ServletServerHttpResponse extends AbstractListenerServerHttpRespons
@Override
public void onComplete(AsyncEvent event) {
if (bodyFlushProcessor != null) {
bodyFlushProcessor.cancel();
bodyFlushProcessor.onComplete();
ResponseBodyFlushProcessor flushProcessor = bodyFlushProcessor;
if (flushProcessor != null) {
flushProcessor.cancel();
flushProcessor.onComplete();
}
ResponseBodyProcessor processor = bodyProcessor;

4
spring-web/src/main/java/org/springframework/http/server/reactive/UndertowServerHttpResponse.java

@ -231,9 +231,9 @@ public class UndertowServerHttpResponse extends AbstractListenerServerHttpRespon @@ -231,9 +231,9 @@ public class UndertowServerHttpResponse extends AbstractListenerServerHttpRespon
}
@Override
protected void writingFailed(Throwable t) {
protected void writingFailed(Throwable ex) {
cancel();
onError(t);
onError(ex);
}
}

Loading…
Cancel
Save