Browse Source

Property actually throws exception for no write method found

Issue: SPR-15507
(cherry picked from commit 817e80c)
pull/1420/head
Juergen Hoeller 9 years ago
parent
commit
aa8cf190d3
  1. 8
      spring-core/src/main/java/org/springframework/core/convert/Property.java

8
spring-core/src/main/java/org/springframework/core/convert/Property.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2002-2016 the original author or authors.
* Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -144,10 +144,11 @@ public final class Property { @@ -144,10 +144,11 @@ public final class Property {
return StringUtils.uncapitalize(this.readMethod.getName().substring(index));
}
else {
int index = this.writeMethod.getName().indexOf("set") + 3;
int index = this.writeMethod.getName().indexOf("set");
if (index == -1) {
throw new IllegalArgumentException("Not a setter method");
}
index += 3;
return StringUtils.uncapitalize(this.writeMethod.getName().substring(index));
}
}
@ -194,7 +195,8 @@ public final class Property { @@ -194,7 +195,8 @@ public final class Property {
private Annotation[] resolveAnnotations() {
Annotation[] annotations = annotationCache.get(this);
if (annotations == null) {
Map<Class<? extends Annotation>, Annotation> annotationMap = new LinkedHashMap<Class<? extends Annotation>, Annotation>();
Map<Class<? extends Annotation>, Annotation> annotationMap =
new LinkedHashMap<Class<? extends Annotation>, Annotation>();
addAnnotationsToMap(annotationMap, getReadMethod());
addAnnotationsToMap(annotationMap, getWriteMethod());
addAnnotationsToMap(annotationMap, getField());

Loading…
Cancel
Save