From a6eaf871f1637a29f89effb8d4ecd7f1af4b4310 Mon Sep 17 00:00:00 2001 From: Chris Beams Date: Thu, 3 Jan 2013 11:10:16 +0100 Subject: [PATCH] Fix Eclipse compilation error in Gradle plugin Prior to this commit, the following compilation error presented itself when importing buildSrc ('spring-build-src') into Eclipse: Groovy:missing type for constructor call @ line 36, column 49. This commit replaces the use of the diamond operator with typical generics syntax in order to work around the problem. It is assumed that the underlying problem is to do with the Groovy compiler in use. This change ensures that any contributor / committer importing spring-framework into Eclipse has a straightforward experience without being required to tweak Groovy settings. If selection of the correct Groovy compilation settings can be made automatic, then we should of course feel free to use Java 7-style syntax there in the future. Note that this was *not* a problem when importing buildSrc into IDEA 12. --- .../build/gradle/TestSourceSetDependenciesPlugin.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildSrc/src/main/groovy/org/springframework/build/gradle/TestSourceSetDependenciesPlugin.groovy b/buildSrc/src/main/groovy/org/springframework/build/gradle/TestSourceSetDependenciesPlugin.groovy index 363c66c00f4..e57b04dec22 100644 --- a/buildSrc/src/main/groovy/org/springframework/build/gradle/TestSourceSetDependenciesPlugin.groovy +++ b/buildSrc/src/main/groovy/org/springframework/build/gradle/TestSourceSetDependenciesPlugin.groovy @@ -33,7 +33,7 @@ class TestSourceSetDependenciesPlugin implements Plugin { @Override public void apply(Project project) { project.afterEvaluate { - Set projectDependencies = new LinkedHashSet<>() + Set projectDependencies = new LinkedHashSet() collectProjectDependencies(projectDependencies, project) projectDependencies.each { project.dependencies.add("testCompile", it.dependencyProject.sourceSets.test.output)