diff --git a/spring-aop/src/test/java/org/springframework/aop/config/AopNamespaceHandlerPointcutErrorTests.java b/spring-aop/src/test/java/org/springframework/aop/config/AopNamespaceHandlerPointcutErrorTests.java index db5fdd5fdc5..3d1bea7b13d 100644 --- a/spring-aop/src/test/java/org/springframework/aop/config/AopNamespaceHandlerPointcutErrorTests.java +++ b/spring-aop/src/test/java/org/springframework/aop/config/AopNamespaceHandlerPointcutErrorTests.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2022 the original author or authors. + * Copyright 2002-2023 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -19,9 +19,9 @@ package org.springframework.aop.config; import org.junit.jupiter.api.Test; import org.springframework.beans.factory.BeanDefinitionStoreException; -import org.springframework.beans.factory.parsing.BeanDefinitionParsingException; import org.springframework.beans.factory.support.DefaultListableBeanFactory; import org.springframework.beans.factory.xml.XmlBeanDefinitionReader; +import org.springframework.core.io.ClassPathResource; import static org.assertj.core.api.Assertions.assertThatExceptionOfType; import static org.springframework.core.testfixture.io.ResourceTestUtils.qualifiedResource; @@ -29,25 +29,28 @@ import static org.springframework.core.testfixture.io.ResourceTestUtils.qualifie /** * @author Mark Fisher * @author Chris Beams + * @author Sam Brannen */ class AopNamespaceHandlerPointcutErrorTests { @Test void duplicatePointcutConfig() { DefaultListableBeanFactory bf = new DefaultListableBeanFactory(); - assertThatExceptionOfType(BeanDefinitionStoreException.class).isThrownBy(() -> - new XmlBeanDefinitionReader(bf).loadBeanDefinitions( - qualifiedResource(getClass(), "pointcutDuplication.xml"))) - .satisfies(ex -> ex.contains(BeanDefinitionParsingException.class)); + XmlBeanDefinitionReader reader = new XmlBeanDefinitionReader(bf); + ClassPathResource resource = qualifiedResource(getClass(), "pointcutDuplication.xml"); + + assertThatExceptionOfType(BeanDefinitionStoreException.class) + .isThrownBy(() -> reader.loadBeanDefinitions(resource)); } @Test void missingPointcutConfig() { DefaultListableBeanFactory bf = new DefaultListableBeanFactory(); - assertThatExceptionOfType(BeanDefinitionStoreException.class).isThrownBy(() -> - new XmlBeanDefinitionReader(bf).loadBeanDefinitions( - qualifiedResource(getClass(), "pointcutMissing.xml"))) - .satisfies(ex -> ex.contains(BeanDefinitionParsingException.class)); + XmlBeanDefinitionReader reader = new XmlBeanDefinitionReader(bf); + ClassPathResource resource = qualifiedResource(getClass(), "pointcutMissing.xml"); + + assertThatExceptionOfType(BeanDefinitionStoreException.class) + .isThrownBy(() -> reader.loadBeanDefinitions(resource)); } } diff --git a/spring-context/src/test/java/org/springframework/context/support/ClassPathXmlApplicationContextTests.java b/spring-context/src/test/java/org/springframework/context/support/ClassPathXmlApplicationContextTests.java index b91dd9b6050..655c91de039 100644 --- a/spring-context/src/test/java/org/springframework/context/support/ClassPathXmlApplicationContextTests.java +++ b/spring-context/src/test/java/org/springframework/context/support/ClassPathXmlApplicationContextTests.java @@ -166,9 +166,9 @@ public class ClassPathXmlApplicationContextTests { void contextWithInvalidLazyClass() { ClassPathXmlApplicationContext ctx = new ClassPathXmlApplicationContext(INVALID_CLASS_CONTEXT, getClass()); assertThat(ctx.containsBean("someMessageSource")).isTrue(); - assertThatExceptionOfType(CannotLoadBeanClassException.class).isThrownBy(() -> - ctx.getBean("someMessageSource")) - .satisfies(ex -> assertThat(ex.contains(ClassNotFoundException.class)).isTrue()); + assertThatExceptionOfType(CannotLoadBeanClassException.class) + .isThrownBy(() -> ctx.getBean("someMessageSource")) + .withCauseExactlyInstanceOf(ClassNotFoundException.class); ctx.close(); } @@ -176,8 +176,7 @@ public class ClassPathXmlApplicationContextTests { void contextWithClassNameThatContainsPlaceholder() { ClassPathXmlApplicationContext ctx = new ClassPathXmlApplicationContext(CLASS_WITH_PLACEHOLDER_CONTEXT, getClass()); assertThat(ctx.containsBean("someMessageSource")).isTrue(); - boolean condition = ctx.getBean("someMessageSource") instanceof StaticMessageSource; - assertThat(condition).isTrue(); + assertThat(ctx.getBean("someMessageSource")).isInstanceOf(StaticMessageSource.class); ctx.close(); } diff --git a/spring-context/src/test/java/org/springframework/jmx/export/MBeanExporterTests.java b/spring-context/src/test/java/org/springframework/jmx/export/MBeanExporterTests.java index 3d01b40eda5..79087637426 100644 --- a/spring-context/src/test/java/org/springframework/jmx/export/MBeanExporterTests.java +++ b/spring-context/src/test/java/org/springframework/jmx/export/MBeanExporterTests.java @@ -84,8 +84,8 @@ public class MBeanExporterTests extends AbstractMBeanServerTests { listeners.put("*", null); MBeanExporter exporter = new MBeanExporter(); - assertThatIllegalArgumentException().isThrownBy(() -> - exporter.setNotificationListenerMappings(listeners)); + assertThatIllegalArgumentException() + .isThrownBy(() -> exporter.setNotificationListenerMappings(listeners)); } @Test @@ -100,9 +100,10 @@ public class MBeanExporterTests extends AbstractMBeanServerTests { exporter.setBeans(getBeanMap()); exporter.setServer(server); exporter.setNotificationListenerMappings(listeners); - assertThatExceptionOfType(MBeanExportException.class).as("NotificationListener on a non-existent MBean").isThrownBy(() -> - start(exporter)) - .satisfies(ex -> assertThat(ex.contains(InstanceNotFoundException.class)).isTrue()); + assertThatExceptionOfType(MBeanExportException.class) + .as("NotificationListener on a non-existent MBean") + .isThrownBy(() -> start(exporter)) + .withCauseExactlyInstanceOf(InstanceNotFoundException.class); } @Test @@ -165,8 +166,8 @@ public class MBeanExporterTests extends AbstractMBeanServerTests { ObjectInstance instance = server.getObjectInstance(ObjectNameManager.getInstance("spring:mbean=true")); assertThat(instance).isNotNull(); - assertThatExceptionOfType(InstanceNotFoundException.class).isThrownBy(() -> - server.getObjectInstance(ObjectNameManager.getInstance("spring:mbean=false"))); + assertThatExceptionOfType(InstanceNotFoundException.class) + .isThrownBy(() -> server.getObjectInstance(ObjectNameManager.getInstance("spring:mbean=false"))); } }