GitHub-Spring
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Lower bad requests to DEBUG level in AbstractHandshakeHandler 

Closes gh-35930
pull/35968/head
rstoyanchev 2 weeks ago
parent
35b58cd0ee
commit
8edde374bb
1 changed files with 10 additions and 10 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 20
      spring-websocket/src/main/java/org/springframework/web/socket/server/support/AbstractHandshakeHandler.java

20
spring-websocket/src/main/java/org/springframework/web/socket/server/support/AbstractHandshakeHandler.java
Unescape View File

@ -178,8 +178,8 @@ public abstract class AbstractHandshakeHandler implements HandshakeHandler, Life
if (HttpMethod.GET != httpMethod && !CONNECT_METHOD.equals(httpMethod)) { if (HttpMethod.GET != httpMethod && !CONNECT_METHOD.equals(httpMethod)) {
response.setStatusCode(HttpStatus.METHOD_NOT_ALLOWED); response.setStatusCode(HttpStatus.METHOD_NOT_ALLOWED);
response.getHeaders().setAllow(Set.of(HttpMethod.GET, CONNECT_METHOD)); response.getHeaders().setAllow(Set.of(HttpMethod.GET, CONNECT_METHOD));
if (logger.isErrorEnabled()) { if (logger.isDebugEnabled()) {
logger.error("Handshake failed due to unexpected HTTP method: " + httpMethod); logger.debug("Handshake failed due to unexpected HTTP method: " + httpMethod);
} }
return false; return false;
} }
@ -195,8 +195,8 @@ public abstract class AbstractHandshakeHandler implements HandshakeHandler, Life
} }
String key = headers.getSecWebSocketKey(); String key = headers.getSecWebSocketKey();
if (key == null) { if (key == null) {
if (logger.isErrorEnabled()) { if (logger.isDebugEnabled()) {
logger.error("Missing \"Sec-WebSocket-Key\" header"); logger.debug("Missing \"Sec-WebSocket-Key\" header");
} }
response.setStatusCode(HttpStatus.BAD_REQUEST); response.setStatusCode(HttpStatus.BAD_REQUEST);
return false; return false;
@ -230,8 +230,8 @@ public abstract class AbstractHandshakeHandler implements HandshakeHandler, Life
} }
protected void handleInvalidUpgradeHeader(ServerHttpRequest request, ServerHttpResponse response) throws IOException { protected void handleInvalidUpgradeHeader(ServerHttpRequest request, ServerHttpResponse response) throws IOException {
if (logger.isErrorEnabled()) { if (logger.isDebugEnabled()) {
logger.error(LogFormatUtils.formatValue( logger.debug(LogFormatUtils.formatValue(
"Handshake failed due to invalid Upgrade header: " + request.getHeaders().getUpgrade(), -1, true)); "Handshake failed due to invalid Upgrade header: " + request.getHeaders().getUpgrade(), -1, true));
} }
response.setStatusCode(HttpStatus.BAD_REQUEST); response.setStatusCode(HttpStatus.BAD_REQUEST);
@ -239,8 +239,8 @@ public abstract class AbstractHandshakeHandler implements HandshakeHandler, Life
} }
protected void handleInvalidConnectHeader(ServerHttpRequest request, ServerHttpResponse response) throws IOException { protected void handleInvalidConnectHeader(ServerHttpRequest request, ServerHttpResponse response) throws IOException {
if (logger.isErrorEnabled()) { if (logger.isDebugEnabled()) {
logger.error(LogFormatUtils.formatValue( logger.debug(LogFormatUtils.formatValue(
"Handshake failed due to invalid Connection header" + request.getHeaders().getConnection(), -1, true)); "Handshake failed due to invalid Connection header" + request.getHeaders().getConnection(), -1, true));
} }
response.setStatusCode(HttpStatus.BAD_REQUEST); response.setStatusCode(HttpStatus.BAD_REQUEST);
@ -263,9 +263,9 @@ public abstract class AbstractHandshakeHandler implements HandshakeHandler, Life
} }
protected void handleWebSocketVersionNotSupported(ServerHttpRequest request, ServerHttpResponse response) { protected void handleWebSocketVersionNotSupported(ServerHttpRequest request, ServerHttpResponse response) {
if (logger.isErrorEnabled()) { if (logger.isDebugEnabled()) {
String version = request.getHeaders().getFirst(WebSocketHttpHeaders.SEC_WEBSOCKET_VERSION); String version = request.getHeaders().getFirst(WebSocketHttpHeaders.SEC_WEBSOCKET_VERSION);
logger.error(LogFormatUtils.formatValue( logger.debug(LogFormatUtils.formatValue(
"Handshake failed due to unsupported WebSocket version: " + version + "Handshake failed due to unsupported WebSocket version: " + version +
". Supported versions: " + Arrays.toString(getSupportedVersions()), -1, true)); ". Supported versions: " + Arrays.toString(getSupportedVersions()), -1, true));
} }

Write Preview
Loading…
Cancel
Save