Browse Source

Clean up warnings in spring-web

pull/1029/head
Sam Brannen 10 years ago
parent
commit
8213df817e
  1. 7
      spring-web/src/main/java/org/springframework/http/HttpHeaders.java
  2. 1
      spring-web/src/main/java/org/springframework/web/client/AsyncRestTemplate.java
  3. 3
      spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilderTests.java
  4. 3
      spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperFactoryBeanTests.java
  5. 3
      spring-web/src/test/java/org/springframework/web/client/AsyncRestTemplateIntegrationTests.java
  6. 1
      spring-web/src/test/java/org/springframework/web/method/annotation/RequestParamMethodArgumentResolverTests.java
  7. 2
      spring-web/src/test/java/org/springframework/web/util/UriTemplateTests.java

7
spring-web/src/main/java/org/springframework/http/HttpHeaders.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2002-2015 the original author or authors.
* Copyright 2002-2016 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -38,11 +38,10 @@ import java.util.TimeZone; @@ -38,11 +38,10 @@ import java.util.TimeZone;
import org.springframework.util.Assert;
import org.springframework.util.LinkedCaseInsensitiveMap;
import org.springframework.util.MultiValueMap;
import org.springframework.util.ObjectUtils;
import org.springframework.util.StringUtils;
/**
* Represents HTTP request and response headers, mapping string header names to list of string values.
* Represents HTTP request and response headers, mapping string header names to a list of string values.
*
* <p>In addition to the normal methods defined by {@link Map}, this class offers the following
* convenience methods:
@ -52,7 +51,7 @@ import org.springframework.util.StringUtils; @@ -52,7 +51,7 @@ import org.springframework.util.StringUtils;
* <li>{@link #set(String, String)} sets the header value to a single string value</li>
* </ul>
*
* <p>Inspired by {@link com.sun.net.httpserver.Headers}.
* <p>Inspired by {@code com.sun.net.httpserver.Headers}.
*
* @author Arjen Poutsma
* @author Sebastien Deleuze

1
spring-web/src/main/java/org/springframework/web/client/AsyncRestTemplate.java

@ -44,7 +44,6 @@ import org.springframework.http.converter.HttpMessageConverter; @@ -44,7 +44,6 @@ import org.springframework.http.converter.HttpMessageConverter;
import org.springframework.util.Assert;
import org.springframework.util.concurrent.ListenableFuture;
import org.springframework.util.concurrent.ListenableFutureAdapter;
import org.springframework.web.util.DefaultUriTemplateHandler;
import org.springframework.web.util.UriTemplateHandler;
/**

3
spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilderTests.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2002-2015 the original author or authors.
* Copyright 2002-2016 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -80,6 +80,7 @@ import static org.junit.Assert.*; @@ -80,6 +80,7 @@ import static org.junit.Assert.*;
*
* @author Sebastien Deleuze
*/
@SuppressWarnings("deprecation")
public class Jackson2ObjectMapperBuilderTests {
private static final String DATE_FORMAT = "yyyy-MM-dd";

3
spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperFactoryBeanTests.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2002-2015 the original author or authors.
* Copyright 2002-2016 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -76,6 +76,7 @@ import static org.junit.Assert.*; @@ -76,6 +76,7 @@ import static org.junit.Assert.*;
* @author Sebastien Deleuze
* @author Sam Brannen
*/
@SuppressWarnings("deprecation")
public class Jackson2ObjectMapperFactoryBeanTests {
private static final String DATE_FORMAT = "yyyy-MM-dd";

3
spring-web/src/test/java/org/springframework/web/client/AsyncRestTemplateIntegrationTests.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2002-2015 the original author or authors.
* Copyright 2002-2016 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -618,7 +618,6 @@ public class AsyncRestTemplateIntegrationTests extends AbstractJettyServerTestCa @@ -618,7 +618,6 @@ public class AsyncRestTemplateIntegrationTests extends AbstractJettyServerTestCa
assertNull(interceptor.exception);
}
@SuppressWarnings("StatementWithEmptyBody")
private void waitTillDone(ListenableFuture<?> future) {
while (!future.isDone()) {
}

1
spring-web/src/test/java/org/springframework/web/method/annotation/RequestParamMethodArgumentResolverTests.java

@ -474,7 +474,6 @@ public class RequestParamMethodArgumentResolverTests { @@ -474,7 +474,6 @@ public class RequestParamMethodArgumentResolverTests {
}
@SuppressWarnings("unused")
public void handle(
@RequestParam(name = "name", defaultValue = "bar") String param1,
@RequestParam("name") String[] param2,

2
spring-web/src/test/java/org/springframework/web/util/UriTemplateTests.java

@ -50,7 +50,7 @@ public class UriTemplateTests { @@ -50,7 +50,7 @@ public class UriTemplateTests {
// SPR-9712
@Test @SuppressWarnings("PrimitiveArrayArgumentToVariableArgMethod")
@Test
public void expandVarArgsWithArrayValue() throws Exception {
UriTemplate template = new UriTemplate("/sum?numbers={numbers}");
URI result = template.expand(new int[] {1, 2, 3});

Loading…
Cancel
Save