From 6eb4ac60ab41563a6d08b312e9b599778b6638f8 Mon Sep 17 00:00:00 2001 From: Andrew Flower Date: Sun, 5 May 2019 11:55:35 +0900 Subject: [PATCH 1/2] Polish CONTRIBUTING.md See gh-22891 --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8b0d3d20d19..24b8387f68e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -83,7 +83,7 @@ multiple edits or corrections of the same logical change. See [Rewriting History section of Pro Git](https://git-scm.com/book/en/Git-Tools-Rewriting-History) for an overview of streamlining commit history. -1. Format commit messages using 55 characters for the subject line, 72 lines for the +1. Format commit messages using 55 characters for the subject line, 72-character lines for the description, followed by the issue fixed, e.g. `Fixes #22276`. See the [Commit Guidelines section of Pro Git](https://git-scm.com/book/en/Distributed-Git-Contributing-to-a-Project#Commit-Guidelines) From 1542d97dab205175ee459a5820787205ed6ccb08 Mon Sep 17 00:00:00 2001 From: Stephane Nicoll Date: Sun, 5 May 2019 09:08:21 +0200 Subject: [PATCH 2/2] Polish contribution Closes gh-22891 --- CONTRIBUTING.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 24b8387f68e..377a23d74ba 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -83,9 +83,8 @@ multiple edits or corrections of the same logical change. See [Rewriting History section of Pro Git](https://git-scm.com/book/en/Git-Tools-Rewriting-History) for an overview of streamlining commit history. -1. Format commit messages using 55 characters for the subject line, 72-character lines for the -description, followed by the issue fixed, e.g. `Fixes #22276`. -See the +1. Format commit messages using 55 characters for the subject line, 72 characters per line +for the description, followed by the issue fixed, e.g. `Fixes #22276`. See the [Commit Guidelines section of Pro Git](https://git-scm.com/book/en/Distributed-Git-Contributing-to-a-Project#Commit-Guidelines) for best practices around commit messages and use `git log` to see some examples.