diff --git a/spring-webflux/src/main/java/org/springframework/web/reactive/result/condition/ParamsRequestCondition.java b/spring-webflux/src/main/java/org/springframework/web/reactive/result/condition/ParamsRequestCondition.java index cdd0e0813da..98fa9c42e37 100644 --- a/spring-webflux/src/main/java/org/springframework/web/reactive/result/condition/ParamsRequestCondition.java +++ b/spring-webflux/src/main/java/org/springframework/web/reactive/result/condition/ParamsRequestCondition.java @@ -86,10 +86,7 @@ public final class ParamsRequestCondition extends AbstractRequestCondition set = new LinkedHashSet<>(this.expressions); diff --git a/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/condition/ParamsRequestConditionTests.java b/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/condition/ParamsRequestConditionTests.java index 13d8edfb0d1..86de02d0f3a 100644 --- a/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/condition/ParamsRequestConditionTests.java +++ b/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/condition/ParamsRequestConditionTests.java @@ -27,7 +27,9 @@ import static org.assertj.core.api.Assertions.assertThat; /** * Unit tests for {@link ParamsRequestCondition}. + * * @author Arjen Poutsma + * @author Stephane Nicoll */ public class ParamsRequestConditionTests { @@ -123,6 +125,24 @@ public class ParamsRequestConditionTests { assertThat(condition1.compareTo(condition2, request)).as("Negated match should not count as more specific").isEqualTo(0); } + @Test + public void combineWithOtherEmpty() { + ParamsRequestCondition condition1 = new ParamsRequestCondition("foo=bar"); + ParamsRequestCondition condition2 = new ParamsRequestCondition(); + + ParamsRequestCondition result = condition1.combine(condition2); + assertThat(result).isEqualTo(condition1); + } + + @Test + public void combineWithThisEmpty() { + ParamsRequestCondition condition1 = new ParamsRequestCondition(); + ParamsRequestCondition condition2 = new ParamsRequestCondition("foo=bar"); + + ParamsRequestCondition result = condition1.combine(condition2); + assertThat(result).isEqualTo(condition2); + } + @Test public void combine() { ParamsRequestCondition condition1 = new ParamsRequestCondition("foo=bar");