From 63a1348c32264efb80a71bef13af9f617842320b Mon Sep 17 00:00:00 2001 From: Sam Brannen Date: Sat, 27 Jun 2015 22:44:42 +0200 Subject: [PATCH] Polish LoggingResultHandler in Spring MVC Test Issue: SPR-13171 --- .../web/servlet/result/MockMvcResultHandlers.java | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/spring-test/src/main/java/org/springframework/test/web/servlet/result/MockMvcResultHandlers.java b/spring-test/src/main/java/org/springframework/test/web/servlet/result/MockMvcResultHandlers.java index 8d8ffdd48cf..270db9ad714 100644 --- a/spring-test/src/main/java/org/springframework/test/web/servlet/result/MockMvcResultHandlers.java +++ b/spring-test/src/main/java/org/springframework/test/web/servlet/result/MockMvcResultHandlers.java @@ -123,16 +123,15 @@ public abstract class MockMvcResultHandlers { */ private static class LoggingResultHandler implements ResultHandler { - private final StringWriter stringWriter = new StringWriter(); - - private final ResultHandler printingResultHandler = new PrintWriterPrintingResultHandler( - new PrintWriter(stringWriter, true)); - - @Override public void handle(MvcResult result) throws Exception { - this.printingResultHandler.handle(result); - logger.debug("MvcResult details:\n" + this.stringWriter); + if (logger.isDebugEnabled()) { + StringWriter stringWriter = new StringWriter(); + ResultHandler printingResultHandler = new PrintWriterPrintingResultHandler( + new PrintWriter(stringWriter)); + printingResultHandler.handle(result); + logger.debug("MvcResult details:\n" + stringWriter); + } } }