Browse Source

Clean up warnings in Gradle build

pull/34134/head
Sam Brannen 1 year ago
parent
commit
62d9600cdd
  1. 14
      spring-core/src/test/java/org/springframework/core/annotation/AnnotatedElementUtilsTests.java
  2. 9
      spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ServletAnnotationControllerHandlerMethodTests.java

14
spring-core/src/test/java/org/springframework/core/annotation/AnnotatedElementUtilsTests.java

@ -47,7 +47,6 @@ import org.springframework.core.annotation.AnnotationUtilsTests.WebController;
import org.springframework.core.annotation.AnnotationUtilsTests.WebMapping; import org.springframework.core.annotation.AnnotationUtilsTests.WebMapping;
import org.springframework.core.testfixture.stereotype.Component; import org.springframework.core.testfixture.stereotype.Component;
import org.springframework.core.testfixture.stereotype.Indexed; import org.springframework.core.testfixture.stereotype.Indexed;
import org.springframework.lang.NonNullApi;
import org.springframework.util.MultiValueMap; import org.springframework.util.MultiValueMap;
import static java.util.Arrays.asList; import static java.util.Arrays.asList;
@ -237,10 +236,11 @@ class AnnotatedElementUtilsTests {
} }
@Test @Test
@SuppressWarnings("deprecation")
void isAnnotatedForPlainTypes() { void isAnnotatedForPlainTypes() {
assertThat(isAnnotated(Order.class, Documented.class)).isTrue(); assertThat(isAnnotated(Order.class, Documented.class)).isTrue();
assertThat(isAnnotated(NonNullApi.class, Documented.class)).isTrue(); assertThat(isAnnotated(org.springframework.lang.NonNullApi.class, Documented.class)).isTrue();
assertThat(isAnnotated(NonNullApi.class, Nonnull.class)).isTrue(); assertThat(isAnnotated(org.springframework.lang.NonNullApi.class, Nonnull.class)).isTrue();
assertThat(isAnnotated(ParametersAreNonnullByDefault.class, Nonnull.class)).isTrue(); assertThat(isAnnotated(ParametersAreNonnullByDefault.class, Nonnull.class)).isTrue();
} }
@ -277,10 +277,11 @@ class AnnotatedElementUtilsTests {
} }
@Test @Test
@SuppressWarnings("deprecation")
void hasAnnotationForPlainTypes() { void hasAnnotationForPlainTypes() {
assertThat(hasAnnotation(Order.class, Documented.class)).isTrue(); assertThat(hasAnnotation(Order.class, Documented.class)).isTrue();
assertThat(hasAnnotation(NonNullApi.class, Documented.class)).isTrue(); assertThat(hasAnnotation(org.springframework.lang.NonNullApi.class, Documented.class)).isTrue();
assertThat(hasAnnotation(NonNullApi.class, Nonnull.class)).isTrue(); assertThat(hasAnnotation(org.springframework.lang.NonNullApi.class, Nonnull.class)).isTrue();
assertThat(hasAnnotation(ParametersAreNonnullByDefault.class, Nonnull.class)).isTrue(); assertThat(hasAnnotation(ParametersAreNonnullByDefault.class, Nonnull.class)).isTrue();
} }
@ -344,9 +345,10 @@ class AnnotatedElementUtilsTests {
} }
@Test @Test
@SuppressWarnings("deprecation")
void getAllAnnotationAttributesOnLangType() { void getAllAnnotationAttributesOnLangType() {
MultiValueMap<String, Object> attributes = getAllAnnotationAttributes( MultiValueMap<String, Object> attributes = getAllAnnotationAttributes(
NonNullApi.class, Nonnull.class.getName()); org.springframework.lang.NonNullApi.class, Nonnull.class.getName());
assertThat(attributes).as("Annotation attributes map for @Nonnull on NonNullApi").isNotNull(); assertThat(attributes).as("Annotation attributes map for @Nonnull on NonNullApi").isNotNull();
assertThat(attributes.get("when")).as("value for NonNullApi").isEqualTo(List.of(When.ALWAYS)); assertThat(attributes.get("when")).as("value for NonNullApi").isEqualTo(List.of(When.ALWAYS));
} }

9
spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ServletAnnotationControllerHandlerMethodTests.java

@ -2905,7 +2905,7 @@ class ServletAnnotationControllerHandlerMethodTests extends AbstractServletHandl
tb = (TestBean) model.get("myCommand"); tb = (TestBean) model.get("myCommand");
} }
if (tb.getName() != null && tb.getName().endsWith("myDefaultName")) { if (tb.getName() != null && tb.getName().endsWith("myDefaultName")) {
assertThat(tb.getDate().getYear()).isEqualTo(107); assertThat(tb.getDate()).hasYear(2007);
} }
Errors errors = (Errors) model.get(BindingResult.MODEL_KEY_PREFIX + "testBean"); Errors errors = (Errors) model.get(BindingResult.MODEL_KEY_PREFIX + "testBean");
if (errors == null) { if (errors == null) {
@ -2915,8 +2915,7 @@ class ServletAnnotationControllerHandlerMethodTests extends AbstractServletHandl
throw new IllegalStateException(); throw new IllegalStateException();
} }
if (model.containsKey("ITestBean")) { if (model.containsKey("ITestBean")) {
boolean condition = model.get(BindingResult.MODEL_KEY_PREFIX + "ITestBean") instanceof Errors; assertThat(model.get(BindingResult.MODEL_KEY_PREFIX + "ITestBean")).isInstanceOf(Errors.class);
assertThat(condition).isTrue();
} }
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
List<TestBean> testBeans = (List<TestBean>) model.get("testBeanList"); List<TestBean> testBeans = (List<TestBean>) model.get("testBeanList");
@ -2939,8 +2938,8 @@ class ServletAnnotationControllerHandlerMethodTests extends AbstractServletHandl
@Override @Override
public View resolveViewName(String viewName, Locale locale) { public View resolveViewName(String viewName, Locale locale) {
return (model, request, response) -> { return (model, request, response) -> {
request.setAttribute("viewName", viewName); request.setAttribute("viewName", viewName);
request.getSession().setAttribute("model", model); request.getSession().setAttribute("model", model);
}; };
} }
} }

Loading…
Cancel
Save