diff --git a/org.springframework.context/src/test/java/org/springframework/jmx/access/MBeanClientInterceptorTests.java b/org.springframework.context/src/test/java/org/springframework/jmx/access/MBeanClientInterceptorTests.java index 53fe8a908f9..a6af50e1325 100644 --- a/org.springframework.context/src/test/java/org/springframework/jmx/access/MBeanClientInterceptorTests.java +++ b/org.springframework.context/src/test/java/org/springframework/jmx/access/MBeanClientInterceptorTests.java @@ -29,6 +29,7 @@ import javax.management.remote.JMXConnectorServer; import javax.management.remote.JMXConnectorServerFactory; import javax.management.remote.JMXServiceURL; +import org.junit.Ignore; import org.springframework.jmx.AbstractMBeanServerTests; import org.springframework.jmx.IJmxTestBean; import org.springframework.jmx.JmxException; @@ -185,7 +186,16 @@ public class MBeanClientInterceptorTests extends AbstractMBeanServerTests { } } - public void testTestLazyConnectionToRemote() throws Exception { + // TODO [SPR-8089] Clean up ignored JMX tests. + // + // @Ignore should have no effect for JUnit 3.8 tests; however, it appears + // that tests on the CI server -- as well as those in Eclipse -- do in + // fact get ignored. So we leave @Ignore here so that developers can + // easily search for ignored tests. + // + // Once fixed, renamed to test* instead of ignore*. + @Ignore("Requires jmxremote_optional.jar; see comments in AbstractMBeanServerTests for details.") + public void ignoreTestLazyConnectionToRemote() throws Exception { if (!runTests) return; diff --git a/org.springframework.context/src/test/java/org/springframework/jmx/access/RemoteMBeanClientInterceptorTests.java b/org.springframework.context/src/test/java/org/springframework/jmx/access/RemoteMBeanClientInterceptorTests.java index 85db8feb55c..751884998a7 100644 --- a/org.springframework.context/src/test/java/org/springframework/jmx/access/RemoteMBeanClientInterceptorTests.java +++ b/org.springframework.context/src/test/java/org/springframework/jmx/access/RemoteMBeanClientInterceptorTests.java @@ -26,9 +26,18 @@ import javax.management.remote.JMXConnectorServer; import javax.management.remote.JMXConnectorServerFactory; import javax.management.remote.JMXServiceURL; +import org.junit.Ignore; + /** * @author Rob Harrop */ +// TODO [SPR-8089] Clean up ignored JMX tests. +// +// @Ignore should have no effect for JUnit 3.8 tests; however, it appears +// that tests on the CI server -- as well as those in Eclipse -- do in +// fact get ignored. So we leave @Ignore here so that developers can +// easily search for ignored tests. +@Ignore("Requires jmxremote_optional.jar; see comments in AbstractMBeanServerTests for details.") public class RemoteMBeanClientInterceptorTests extends MBeanClientInterceptorTests { private static final String SERVICE_URL = "service:jmx:jmxmp://localhost:9876"; diff --git a/org.springframework.context/src/test/java/org/springframework/jmx/support/ConnectorServerFactoryBeanTests.java b/org.springframework.context/src/test/java/org/springframework/jmx/support/ConnectorServerFactoryBeanTests.java index 14d59d5baac..5d7cce5ed17 100644 --- a/org.springframework.context/src/test/java/org/springframework/jmx/support/ConnectorServerFactoryBeanTests.java +++ b/org.springframework.context/src/test/java/org/springframework/jmx/support/ConnectorServerFactoryBeanTests.java @@ -28,11 +28,19 @@ import javax.management.remote.JMXConnector; import javax.management.remote.JMXConnectorFactory; import javax.management.remote.JMXServiceURL; +import org.junit.Ignore; import org.springframework.jmx.AbstractMBeanServerTests; /** * @author Rob Harrop */ +// TODO [SPR-8089] Clean up ignored JMX tests. +// +// @Ignore should have no effect for JUnit 3.8 tests; however, it appears +// that tests on the CI server -- as well as those in Eclipse -- do in +// fact get ignored. So we leave @Ignore here so that developers can +// easily search for ignored tests. +@Ignore("Requires jmxremote_optional.jar; see comments in AbstractMBeanServerTests for details.") public class ConnectorServerFactoryBeanTests extends AbstractMBeanServerTests { private static final String OBJECT_NAME = "spring:type=connector,name=test"; diff --git a/org.springframework.context/src/test/java/org/springframework/jmx/support/MBeanServerConnectionFactoryBeanTests.java b/org.springframework.context/src/test/java/org/springframework/jmx/support/MBeanServerConnectionFactoryBeanTests.java index 725180f3c0c..56244c74a4f 100644 --- a/org.springframework.context/src/test/java/org/springframework/jmx/support/MBeanServerConnectionFactoryBeanTests.java +++ b/org.springframework.context/src/test/java/org/springframework/jmx/support/MBeanServerConnectionFactoryBeanTests.java @@ -23,6 +23,7 @@ import javax.management.remote.JMXConnectorServer; import javax.management.remote.JMXConnectorServerFactory; import javax.management.remote.JMXServiceURL; +import org.junit.Ignore; import org.springframework.aop.support.AopUtils; import org.springframework.jmx.AbstractMBeanServerTests; @@ -42,7 +43,16 @@ public class MBeanServerConnectionFactoryBeanTests extends AbstractMBeanServerTe return JMXConnectorServerFactory.newJMXConnectorServer(getServiceUrl(), null, getServer()); } - public void testTestValidConnection() throws Exception { + // TODO [SPR-8089] Clean up ignored JMX tests. + // + // @Ignore should have no effect for JUnit 3.8 tests; however, it appears + // that tests on the CI server -- as well as those in Eclipse -- do in + // fact get ignored. So we leave @Ignore here so that developers can + // easily search for ignored tests. + // + // Once fixed, renamed to test* instead of ignore*. + @Ignore("Requires jmxremote_optional.jar; see comments in AbstractMBeanServerTests for details.") + public void ignoreTestValidConnection() throws Exception { JMXConnectorServer connectorServer = getConnectorServer(); connectorServer.start(); @@ -75,7 +85,16 @@ public class MBeanServerConnectionFactoryBeanTests extends AbstractMBeanServerTe } } - public void testTestWithLazyConnection() throws Exception { + // TODO [SPR-8089] Clean up ignored JMX tests. + // + // @Ignore should have no effect for JUnit 3.8 tests; however, it appears + // that tests on the CI server -- as well as those in Eclipse -- do in + // fact get ignored. So we leave @Ignore here so that developers can + // easily search for ignored tests. + // + // Once fixed, renamed to test* instead of ignore*. + @Ignore("Requires jmxremote_optional.jar; see comments in AbstractMBeanServerTests for details.") + public void ignoreTestWithLazyConnection() throws Exception { MBeanServerConnectionFactoryBean bean = new MBeanServerConnectionFactoryBean(); bean.setServiceUrl(SERVICE_URL); bean.setConnectOnStartup(false);