Browse Source

Add explicit FileSystemResource path check for trailing slash

Closes gh-34509
pull/34656/head
Juergen Hoeller 10 months ago
parent
commit
534f123fe8
  1. 11
      spring-webflux/src/main/java/org/springframework/web/reactive/resource/ResourceHandlerUtils.java
  2. 19
      spring-webflux/src/test/java/org/springframework/web/reactive/function/server/PathResourceLookupFunctionTests.java
  3. 11
      spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceHandlerUtils.java
  4. 16
      spring-webmvc/src/test/java/org/springframework/web/servlet/function/PathResourceLookupFunctionTests.java

11
spring-webflux/src/main/java/org/springframework/web/reactive/resource/ResourceHandlerUtils.java

@ -24,7 +24,7 @@ import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.springframework.core.io.ClassPathResource; import org.springframework.core.io.ClassPathResource;
import org.springframework.core.io.PathResource; import org.springframework.core.io.FileSystemResource;
import org.springframework.core.io.Resource; import org.springframework.core.io.Resource;
import org.springframework.core.io.UrlResource; import org.springframework.core.io.UrlResource;
import org.springframework.core.log.LogFormatUtils; import org.springframework.core.log.LogFormatUtils;
@ -57,15 +57,18 @@ public abstract class ResourceHandlerUtils {
Assert.notNull(location, "Resource location must not be null"); Assert.notNull(location, "Resource location must not be null");
try { try {
String path; String path;
if (location instanceof PathResource) { if (location instanceof org.springframework.core.io.PathResource) {
return; return;
} }
else if (location instanceof UrlResource) { else if (location instanceof FileSystemResource fileSystemResource) {
path = location.getURL().toExternalForm(); path = fileSystemResource.getPath();
} }
else if (location instanceof ClassPathResource classPathResource) { else if (location instanceof ClassPathResource classPathResource) {
path = classPathResource.getPath(); path = classPathResource.getPath();
} }
else if (location instanceof UrlResource) {
path = location.getURL().toExternalForm();
}
else { else {
path = location.getURL().getPath(); path = location.getURL().getPath();
} }

19
spring-webflux/src/test/java/org/springframework/web/reactive/function/server/PathResourceLookupFunctionTests.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2024 the original author or authors. * Copyright 2002-2025 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -26,6 +26,7 @@ import reactor.core.publisher.Mono;
import reactor.test.StepVerifier; import reactor.test.StepVerifier;
import org.springframework.core.io.ClassPathResource; import org.springframework.core.io.ClassPathResource;
import org.springframework.core.io.FileSystemResource;
import org.springframework.core.io.Resource; import org.springframework.core.io.Resource;
import org.springframework.web.testfixture.http.server.reactive.MockServerHttpRequest; import org.springframework.web.testfixture.http.server.reactive.MockServerHttpRequest;
import org.springframework.web.testfixture.server.MockServerWebExchange; import org.springframework.web.testfixture.server.MockServerWebExchange;
@ -39,8 +40,7 @@ class PathResourceLookupFunctionTests {
void normal() throws Exception { void normal() throws Exception {
ClassPathResource location = new ClassPathResource("org/springframework/web/reactive/function/server/"); ClassPathResource location = new ClassPathResource("org/springframework/web/reactive/function/server/");
PathResourceLookupFunction PathResourceLookupFunction function = new PathResourceLookupFunction("/resources/**", location);
function = new PathResourceLookupFunction("/resources/**", location);
MockServerHttpRequest mockRequest = MockServerHttpRequest.get("https://localhost/resources/response.txt").build(); MockServerHttpRequest mockRequest = MockServerHttpRequest.get("https://localhost/resources/response.txt").build();
ServerRequest request = new DefaultServerRequest(MockServerWebExchange.from(mockRequest), Collections.emptyList()); ServerRequest request = new DefaultServerRequest(MockServerWebExchange.from(mockRequest), Collections.emptyList());
Mono<Resource> result = function.apply(request); Mono<Resource> result = function.apply(request);
@ -124,4 +124,17 @@ class PathResourceLookupFunctionTests {
.verify(); .verify();
} }
@Test
@SuppressWarnings("removal")
void withPathResource() {
org.springframework.core.io.PathResource location = new org.springframework.core.io.PathResource("/static/");
PathResourceLookupFunction function = new PathResourceLookupFunction("/resources/**", location);
}
@Test
void withFileSystemResource() {
FileSystemResource location = new FileSystemResource("/static/");
PathResourceLookupFunction function = new PathResourceLookupFunction("/resources/**", location);
}
} }

11
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceHandlerUtils.java

@ -24,7 +24,7 @@ import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.springframework.core.io.ClassPathResource; import org.springframework.core.io.ClassPathResource;
import org.springframework.core.io.PathResource; import org.springframework.core.io.FileSystemResource;
import org.springframework.core.io.Resource; import org.springframework.core.io.Resource;
import org.springframework.core.io.UrlResource; import org.springframework.core.io.UrlResource;
import org.springframework.core.log.LogFormatUtils; import org.springframework.core.log.LogFormatUtils;
@ -58,15 +58,18 @@ public abstract class ResourceHandlerUtils {
Assert.notNull(location, "Resource location must not be null"); Assert.notNull(location, "Resource location must not be null");
try { try {
String path; String path;
if (location instanceof PathResource) { if (location instanceof org.springframework.core.io.PathResource) {
return; return;
} }
else if (location instanceof UrlResource) { else if (location instanceof FileSystemResource fileSystemResource) {
path = location.getURL().toExternalForm(); path = fileSystemResource.getPath();
} }
else if (location instanceof ClassPathResource classPathResource) { else if (location instanceof ClassPathResource classPathResource) {
path = classPathResource.getPath(); path = classPathResource.getPath();
} }
else if (location instanceof UrlResource) {
path = location.getURL().toExternalForm();
}
else { else {
path = location.getURL().getPath(); path = location.getURL().getPath();
} }

16
spring-webmvc/src/test/java/org/springframework/web/servlet/function/PathResourceLookupFunctionTests.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2023 the original author or authors. * Copyright 2002-2025 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -24,6 +24,7 @@ import java.util.function.Function;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.springframework.core.io.ClassPathResource; import org.springframework.core.io.ClassPathResource;
import org.springframework.core.io.FileSystemResource;
import org.springframework.core.io.Resource; import org.springframework.core.io.Resource;
import org.springframework.web.servlet.handler.PathPatternsTestUtils; import org.springframework.web.servlet.handler.PathPatternsTestUtils;
@ -102,4 +103,17 @@ class PathResourceLookupFunctionTests {
Collections.emptyList()); Collections.emptyList());
} }
@Test
@SuppressWarnings("removal")
void withPathResource() {
org.springframework.core.io.PathResource location = new org.springframework.core.io.PathResource("/static/");
PathResourceLookupFunction function = new PathResourceLookupFunction("/resources/**", location);
}
@Test
void withFileSystemResource() {
FileSystemResource location = new FileSystemResource("/static/");
PathResourceLookupFunction function = new PathResourceLookupFunction("/resources/**", location);
}
} }

Loading…
Cancel
Save