From 52f580149fb4c43d162dfd1e5d9d999a2a30dc69 Mon Sep 17 00:00:00 2001 From: Juergen Hoeller Date: Thu, 17 Apr 2014 22:42:33 +0200 Subject: [PATCH] Polishing --- .../messaging/simp/SimpMessagingTemplate.java | 4 ++-- .../converter/AbstractHttpMessageConverter.java | 15 ++++++++------- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/spring-messaging/src/main/java/org/springframework/messaging/simp/SimpMessagingTemplate.java b/spring-messaging/src/main/java/org/springframework/messaging/simp/SimpMessagingTemplate.java index f6424fc0f9b..bad47460b84 100644 --- a/spring-messaging/src/main/java/org/springframework/messaging/simp/SimpMessagingTemplate.java +++ b/spring-messaging/src/main/java/org/springframework/messaging/simp/SimpMessagingTemplate.java @@ -108,7 +108,7 @@ public class SimpMessagingTemplate extends AbstractMessageSendingTemplate message) { SimpMessageHeaderAccessor headers = SimpMessageHeaderAccessor.wrap(message); String destination = headers.getDestination(); - destination = (destination != null) ? destination : getRequiredDefaultDestination(); + destination = (destination != null ? destination : getRequiredDefaultDestination()); doSend(destination, message); } @@ -131,7 +131,6 @@ public class SimpMessagingTemplate extends AbstractMessageSendingTemplate implements HttpMessageConv final HttpHeaders headers = outputMessage.getHeaders(); if (headers.getContentType() == null) { + MediaType contentTypeToUse = contentType; if (contentType == null || contentType.isWildcardType() || contentType.isWildcardSubtype()) { - contentType = getDefaultContentType(t); + contentTypeToUse = getDefaultContentType(t); } - if (contentType != null) { - headers.setContentType(contentType); + if (contentTypeToUse != null) { + headers.setContentType(contentTypeToUse); } } if (headers.getContentLength() == -1) { @@ -182,10 +184,10 @@ public abstract class AbstractHttpMessageConverter implements HttpMessageConv headers.setContentLength(contentLength); } } + if (outputMessage instanceof StreamingHttpOutputMessage) { StreamingHttpOutputMessage streamingOutputMessage = (StreamingHttpOutputMessage) outputMessage; - streamingOutputMessage.setBody(new StreamingHttpOutputMessage.Body() { @Override public void writeTo(final OutputStream outputStream) throws IOException { @@ -194,7 +196,6 @@ public abstract class AbstractHttpMessageConverter implements HttpMessageConv public OutputStream getBody() throws IOException { return outputStream; } - @Override public HttpHeaders getHeaders() { return headers; @@ -256,7 +257,7 @@ public abstract class AbstractHttpMessageConverter implements HttpMessageConv /** * Abstract template method that writes the actual body. Invoked from {@link #write}. * @param t the object to write to the output message - * @param outputMessage the message to write to + * @param outputMessage the HTTP output message to write to * @throws IOException in case of I/O errors * @throws HttpMessageNotWritableException in case of conversion errors */