From 51d6e8beb0850cbf9255326b739239a29e8e45fa Mon Sep 17 00:00:00 2001 From: Sam Brannen <104798+sbrannen@users.noreply.github.com> Date: Sat, 11 Oct 2025 15:18:14 +0200 Subject: [PATCH] Polishing --- .../index/CandidateComponentsIndex.java | 4 +- .../CandidateComponentsIndexLoaderTests.java | 2 +- .../index/CandidateComponentsIndexTests.java | 38 ++++++++----------- 3 files changed, 19 insertions(+), 25 deletions(-) diff --git a/spring-context/src/main/java/org/springframework/context/index/CandidateComponentsIndex.java b/spring-context/src/main/java/org/springframework/context/index/CandidateComponentsIndex.java index bf8c9f1bc29..45082199ab6 100644 --- a/spring-context/src/main/java/org/springframework/context/index/CandidateComponentsIndex.java +++ b/spring-context/src/main/java/org/springframework/context/index/CandidateComponentsIndex.java @@ -138,8 +138,8 @@ public class CandidateComponentsIndex { List candidates = this.index.get(stereotype); if (candidates != null) { return candidates.stream() - .filter(t -> t.match(basePackage)) - .map(t -> t.type) + .filter(entry -> entry.match(basePackage)) + .map(entry -> entry.type) .collect(Collectors.toSet()); } return Collections.emptySet(); diff --git a/spring-context/src/test/java/org/springframework/context/index/CandidateComponentsIndexLoaderTests.java b/spring-context/src/test/java/org/springframework/context/index/CandidateComponentsIndexLoaderTests.java index 32d4eb7c2a0..9d84c2b8176 100644 --- a/spring-context/src/test/java/org/springframework/context/index/CandidateComponentsIndexLoaderTests.java +++ b/spring-context/src/test/java/org/springframework/context/index/CandidateComponentsIndexLoaderTests.java @@ -32,7 +32,7 @@ import static org.assertj.core.api.Assertions.assertThatIllegalStateException; * * @author Stephane Nicoll */ -public class CandidateComponentsIndexLoaderTests { +class CandidateComponentsIndexLoaderTests { @Test void validateIndexIsDisabledByDefault() { diff --git a/spring-context/src/test/java/org/springframework/context/index/CandidateComponentsIndexTests.java b/spring-context/src/test/java/org/springframework/context/index/CandidateComponentsIndexTests.java index 32befc3230e..8a623fa58f9 100644 --- a/spring-context/src/test/java/org/springframework/context/index/CandidateComponentsIndexTests.java +++ b/spring-context/src/test/java/org/springframework/context/index/CandidateComponentsIndexTests.java @@ -16,8 +16,7 @@ package org.springframework.context.index; -import java.util.Arrays; -import java.util.Collections; +import java.util.List; import java.util.Properties; import java.util.Set; @@ -30,52 +29,47 @@ import static org.assertj.core.api.Assertions.assertThat; * * @author Stephane Nicoll */ -public class CandidateComponentsIndexTests { +class CandidateComponentsIndexTests { @Test void getCandidateTypes() { - CandidateComponentsIndex index = new CandidateComponentsIndex( - Collections.singletonList(createSampleProperties())); + CandidateComponentsIndex index = new CandidateComponentsIndex(List.of(createSampleProperties())); Set actual = index.getCandidateTypes("com.example.service", "service"); assertThat(actual).contains("com.example.service.One", "com.example.service.sub.Two", "com.example.service.Three"); } + @Test + void getCandidateTypesNoMatch() { + CandidateComponentsIndex index = new CandidateComponentsIndex(List.of(createSampleProperties())); + Set actual = index.getCandidateTypes("com.example.service", "entity"); + assertThat(actual).isEmpty(); + } + @Test void getCandidateTypesSubPackage() { - CandidateComponentsIndex index = new CandidateComponentsIndex( - Collections.singletonList(createSampleProperties())); + CandidateComponentsIndex index = new CandidateComponentsIndex(List.of(createSampleProperties())); Set actual = index.getCandidateTypes("com.example.service.sub", "service"); assertThat(actual).contains("com.example.service.sub.Two"); } @Test void getCandidateTypesSubPackageNoMatch() { - CandidateComponentsIndex index = new CandidateComponentsIndex( - Collections.singletonList(createSampleProperties())); + CandidateComponentsIndex index = new CandidateComponentsIndex(List.of(createSampleProperties())); Set actual = index.getCandidateTypes("com.example.service.none", "service"); assertThat(actual).isEmpty(); } - @Test - void getCandidateTypesNoMatch() { - CandidateComponentsIndex index = new CandidateComponentsIndex( - Collections.singletonList(createSampleProperties())); - Set actual = index.getCandidateTypes("com.example.service", "entity"); - assertThat(actual).isEmpty(); - } - @Test void mergeCandidateStereotypes() { - CandidateComponentsIndex index = new CandidateComponentsIndex(Arrays.asList( + CandidateComponentsIndex index = new CandidateComponentsIndex(List.of( createProperties("com.example.Foo", "service"), createProperties("com.example.Foo", "entity"))); - assertThat(index.getCandidateTypes("com.example", "service")) - .contains("com.example.Foo"); - assertThat(index.getCandidateTypes("com.example", "entity")) - .contains("com.example.Foo"); + assertThat(index.getCandidateTypes("com.example", "service")).contains("com.example.Foo"); + assertThat(index.getCandidateTypes("com.example", "entity")).contains("com.example.Foo"); } + private static Properties createProperties(String key, String stereotypes) { Properties properties = new Properties(); properties.put(key, String.join(",", stereotypes));