From 512ffbb2730f2e58da6ca6cb069a6801ff3bc9e0 Mon Sep 17 00:00:00 2001 From: Chris Beams Date: Tue, 11 Sep 2012 15:54:54 +0200 Subject: [PATCH] Update PortletRequestUtilsTests float test timeout Float parameter handling appears to be marginally more expensive under JDK7, with the testGetFloatParameterWithDefaultValueHandlingIsFastEnough test clocking in anywhere from 250 to 315 ms. This violates the current test threshold of 250 ms, so this commit ups the timeout value to 350 ms with the assumption that this is indeed a marginal and therefore overall negligible performance degradation. --- .../web/portlet/bind/PortletRequestUtilsTests.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-webmvc-portlet/src/test/java/org/springframework/web/portlet/bind/PortletRequestUtilsTests.java b/spring-webmvc-portlet/src/test/java/org/springframework/web/portlet/bind/PortletRequestUtilsTests.java index 82afc0536ae..e82de4420e6 100644 --- a/spring-webmvc-portlet/src/test/java/org/springframework/web/portlet/bind/PortletRequestUtilsTests.java +++ b/spring-webmvc-portlet/src/test/java/org/springframework/web/portlet/bind/PortletRequestUtilsTests.java @@ -395,7 +395,7 @@ public class PortletRequestUtilsTests extends TestCase { PortletRequestUtils.getFloatParameter(request, "nonExistingParam", 0f); } sw.stop(); - assertThat(sw.getTotalTimeMillis(), lessThan(250L)); + assertThat(sw.getTotalTimeMillis(), lessThan(350L)); } public void testGetDoubleParameterWithDefaultValueHandlingIsFastEnough() {