From 43dd813ee64e7c62aeeaf24cdd52230457336d5b Mon Sep 17 00:00:00 2001 From: Sam Brannen Date: Mon, 30 May 2022 19:35:16 +0200 Subject: [PATCH] Temporary workaround for Checkstyle bug Attempting to name a variable in an "instanceof pattern" the same as a field results in a Checkstyle violation similar to the following if the "instanceof pattern matching" is located within a constructor. Reference to instance variable 'document' needs "this.". [RequireThis] See gh-28188 --- .../java/org/springframework/util/xml/DomContentHandler.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spring-core/src/main/java/org/springframework/util/xml/DomContentHandler.java b/spring-core/src/main/java/org/springframework/util/xml/DomContentHandler.java index d9abd162521..7405e0b90eb 100644 --- a/spring-core/src/main/java/org/springframework/util/xml/DomContentHandler.java +++ b/spring-core/src/main/java/org/springframework/util/xml/DomContentHandler.java @@ -50,8 +50,8 @@ class DomContentHandler implements ContentHandler { */ DomContentHandler(Node node) { this.node = node; - if (node instanceof Document document) { - this.document = document; + if (node instanceof Document doc) { + this.document = doc; } else { this.document = node.getOwnerDocument();