From 4357bbd31b0207afbfc3ab20588cf1fbdaca076e Mon Sep 17 00:00:00 2001 From: Sam Brannen <104798+sbrannen@users.noreply.github.com> Date: Thu, 19 Mar 2026 15:01:17 +0100 Subject: [PATCH] Convert assertThat(!x).isTrue() to assertThat(x).isFalse() Search: assertThat\(\!(.+?)\)(.*?)\.isTrue\(\) Replace: assertThat($1)$2.isFalse() See gh-36504 --- .../factory/xml/AbstractBeanFactoryTests.java | 4 ++-- .../mail/SimpleMailMessageTests.java | 4 ++-- .../aop/aspectj/BeanNamePointcutTests.java | 4 ++-- .../AbstractApplicationContextTests.java | 4 ++-- .../springframework/util/ClassUtilsTests.java | 4 ++-- .../jdbc/core/JdbcTemplateTests.java | 4 ++-- .../core/simple/CallMetaDataContextTests.java | 2 +- .../JndiJtaTransactionManagerTests.java | 10 ++++---- .../bind/ServletRequestDataBinderTests.java | 4 ++-- .../support/WebRequestDataBinderTests.java | 4 ++-- .../web/context/ContextLoaderTests.java | 2 +- .../XmlWebApplicationContextTests.java | 4 ++-- .../web/servlet/tags/BindTagTests.java | 2 +- .../web/servlet/tags/HtmlEscapeTagTests.java | 24 +++++++++---------- 14 files changed, 38 insertions(+), 38 deletions(-) diff --git a/spring-beans/src/testFixtures/java/org/springframework/beans/testfixture/factory/xml/AbstractBeanFactoryTests.java b/spring-beans/src/testFixtures/java/org/springframework/beans/testfixture/factory/xml/AbstractBeanFactoryTests.java index 58d5212d890..af7d8b5a4b4 100644 --- a/spring-beans/src/testFixtures/java/org/springframework/beans/testfixture/factory/xml/AbstractBeanFactoryTests.java +++ b/spring-beans/src/testFixtures/java/org/springframework/beans/testfixture/factory/xml/AbstractBeanFactoryTests.java @@ -90,7 +90,7 @@ public abstract class AbstractBeanFactoryTests { // The dummy business method will throw an exception if the // necessary callbacks weren't invoked in the right order. lb.businessMethod(); - assertThat(!lb.isDestroyed()).as("Not destroyed").isTrue(); + assertThat(lb.isDestroyed()).as("Not destroyed").isFalse(); } @Test @@ -160,7 +160,7 @@ public abstract class AbstractBeanFactoryTests { tb2.setAge(2); assertThat(tb1.getAge()).as("1 age independent = 1").isEqualTo(1); assertThat(tb2.getAge()).as("2 age independent = 2").isEqualTo(2); - assertThat(!tb1.equals(tb2)).as("object equal now false").isTrue(); + assertThat(tb1.equals(tb2)).as("object equal now false").isFalse(); } @Test diff --git a/spring-context-support/src/test/java/org/springframework/mail/SimpleMailMessageTests.java b/spring-context-support/src/test/java/org/springframework/mail/SimpleMailMessageTests.java index 984e235bab6..49530d62608 100644 --- a/spring-context-support/src/test/java/org/springframework/mail/SimpleMailMessageTests.java +++ b/spring-context-support/src/test/java/org/springframework/mail/SimpleMailMessageTests.java @@ -133,10 +133,10 @@ class SimpleMailMessageTests { // Null object is not equal message1 = new SimpleMailMessage(); message2 = null; - assertThat(!(message1.equals(message2))).isTrue(); + assertThat((message1.equals(message2))).isFalse(); // Different class is not equal - assertThat(!(message1.equals(new Object()))).isTrue(); + assertThat((message1.equals(new Object()))).isFalse(); // Equal values are equal message1 = new SimpleMailMessage(); diff --git a/spring-context/src/test/java/org/springframework/aop/aspectj/BeanNamePointcutTests.java b/spring-context/src/test/java/org/springframework/aop/aspectj/BeanNamePointcutTests.java index 031b914bf75..5265536bd9f 100644 --- a/spring-context/src/test/java/org/springframework/aop/aspectj/BeanNamePointcutTests.java +++ b/spring-context/src/test/java/org/springframework/aop/aspectj/BeanNamePointcutTests.java @@ -101,12 +101,12 @@ class BeanNamePointcutTests { assertThat(this.testFactoryBean1.get("myKey")).isEqualTo("myValue"); assertThat(this.counterAspect.getCount()).as("Advice not executed: must have been").isEqualTo(2); FactoryBean fb = (FactoryBean) ctx.getBean("&testFactoryBean1"); - assertThat(!(fb instanceof Advised)).as("FactoryBean itself must *not* be advised").isTrue(); + assertThat((fb instanceof Advised)).as("FactoryBean itself must *not* be advised").isFalse(); } @Test void matchingFactoryBeanItself() { - assertThat(!(this.testFactoryBean2 instanceof Advised)).as("Matching bean must *not* be advised (proxied)").isTrue(); + assertThat((this.testFactoryBean2 instanceof Advised)).as("Matching bean must *not* be advised (proxied)").isFalse(); FactoryBean fb = (FactoryBean) ctx.getBean("&testFactoryBean2"); assertThat(fb instanceof Advised).as("FactoryBean itself must be advised").isTrue(); assertThat(Map.class.isAssignableFrom(fb.getObjectType())).isTrue(); diff --git a/spring-context/src/testFixtures/java/org/springframework/context/testfixture/AbstractApplicationContextTests.java b/spring-context/src/testFixtures/java/org/springframework/context/testfixture/AbstractApplicationContextTests.java index 7b1cb562a90..57a8c670af0 100644 --- a/spring-context/src/testFixtures/java/org/springframework/context/testfixture/AbstractApplicationContextTests.java +++ b/spring-context/src/testFixtures/java/org/springframework/context/testfixture/AbstractApplicationContextTests.java @@ -93,7 +93,7 @@ public abstract class AbstractApplicationContextTests extends AbstractListableBe assertThat(aca.getApplicationContext()).as("has had context set").isSameAs(applicationContext); Object aca2 = applicationContext.getBean("aca-prototype"); assertThat(aca).as("NOT Same instance").isNotSameAs(aca2); - assertThat(!applicationContext.isSingleton("aca-prototype")).as("Says is prototype").isTrue(); + assertThat(applicationContext.isSingleton("aca-prototype")).as("Says is prototype").isFalse(); } @Test @@ -127,7 +127,7 @@ public abstract class AbstractApplicationContextTests extends AbstractListableBe @Test protected void closeTriggersDestroy() { LifecycleBean lb = (LifecycleBean) applicationContext.getBean("lifecycle"); - assertThat(!lb.isDestroyed()).as("Not destroyed").isTrue(); + assertThat(lb.isDestroyed()).as("Not destroyed").isFalse(); applicationContext.close(); if (applicationContext.getParent() != null) { ((ConfigurableApplicationContext) applicationContext.getParent()).close(); diff --git a/spring-core/src/test/java/org/springframework/util/ClassUtilsTests.java b/spring-core/src/test/java/org/springframework/util/ClassUtilsTests.java index 88c288898ca..1baeb027d6c 100644 --- a/spring-core/src/test/java/org/springframework/util/ClassUtilsTests.java +++ b/spring-core/src/test/java/org/springframework/util/ClassUtilsTests.java @@ -944,11 +944,11 @@ class ClassUtilsTests { } private static void assertNotPublic(Member member) { - assertThat(!isPublic(member)).as("%s must be not be public", member).isTrue(); + assertThat(isPublic(member)).as("%s must be not be public", member).isFalse(); } private static void assertNotPublic(Class clazz) { - assertThat(!isPublic(clazz)).as("%s must be not be public", clazz).isTrue(); + assertThat(isPublic(clazz)).as("%s must be not be public", clazz).isFalse(); } private static boolean isPublic(Class clazz) { diff --git a/spring-jdbc/src/test/java/org/springframework/jdbc/core/JdbcTemplateTests.java b/spring-jdbc/src/test/java/org/springframework/jdbc/core/JdbcTemplateTests.java index 29083c9d94f..c55d72daa6d 100644 --- a/spring-jdbc/src/test/java/org/springframework/jdbc/core/JdbcTemplateTests.java +++ b/spring-jdbc/src/test/java/org/springframework/jdbc/core/JdbcTemplateTests.java @@ -117,7 +117,7 @@ class JdbcTemplateTests { assertThat(this.template.getDataSource()).as("datasource ok").isSameAs(this.dataSource); assertThat(this.template.isIgnoreWarnings()).as("ignores warnings by default").isTrue(); this.template.setIgnoreWarnings(false); - assertThat(!this.template.isIgnoreWarnings()).as("can set NOT to ignore warnings").isTrue(); + assertThat(this.template.isIgnoreWarnings()).as("can set NOT to ignore warnings").isFalse(); } @Test @@ -1125,7 +1125,7 @@ class JdbcTemplateTests { given(this.callableStatement.getUpdateCount()).willReturn(-1); given(this.callableStatement.getObject(1)).willReturn("X"); - assertThat(!this.template.isResultsMapCaseInsensitive()).as("default should have been NOT case insensitive").isTrue(); + assertThat(this.template.isResultsMapCaseInsensitive()).as("default should have been NOT case insensitive").isFalse(); this.template.setResultsMapCaseInsensitive(true); assertThat(this.template.isResultsMapCaseInsensitive()).as("now it should have been set to case insensitive").isTrue(); diff --git a/spring-jdbc/src/test/java/org/springframework/jdbc/core/simple/CallMetaDataContextTests.java b/spring-jdbc/src/test/java/org/springframework/jdbc/core/simple/CallMetaDataContextTests.java index 6acd0cbfc50..fcca55103b3 100644 --- a/spring-jdbc/src/test/java/org/springframework/jdbc/core/simple/CallMetaDataContextTests.java +++ b/spring-jdbc/src/test/java/org/springframework/jdbc/core/simple/CallMetaDataContextTests.java @@ -94,7 +94,7 @@ class CallMetaDataContextTests { assertThat(inParameters).as("Wrong number of matched in parameter values").hasSize(2); assertThat(inParameters.containsKey("id")).as("in parameter value missing").isTrue(); assertThat(inParameters.containsKey("name")).as("in out parameter value missing").isTrue(); - assertThat(!inParameters.containsKey("customer_no")).as("out parameter value matched").isTrue(); + assertThat(inParameters.containsKey("customer_no")).as("out parameter value matched").isFalse(); List names = context.getOutParameterNames(); assertThat(names).as("Wrong number of out parameters").hasSize(2); diff --git a/spring-tx/src/test/java/org/springframework/transaction/JndiJtaTransactionManagerTests.java b/spring-tx/src/test/java/org/springframework/transaction/JndiJtaTransactionManagerTests.java index 54b50d45e1a..f11aecf47b7 100644 --- a/spring-tx/src/test/java/org/springframework/transaction/JndiJtaTransactionManagerTests.java +++ b/spring-tx/src/test/java/org/springframework/transaction/JndiJtaTransactionManagerTests.java @@ -97,14 +97,14 @@ class JndiJtaTransactionManagerTests { } TransactionTemplate tt = new TransactionTemplate(ptm); - assertThat(!TransactionSynchronizationManager.isSynchronizationActive()).isTrue(); + assertThat(TransactionSynchronizationManager.isSynchronizationActive()).isFalse(); assertThat(TransactionSynchronizationManager.isCurrentTransactionReadOnly()).isFalse(); tt.executeWithoutResult(status -> { // something transactional assertThat(TransactionSynchronizationManager.isSynchronizationActive()).isTrue(); assertThat(TransactionSynchronizationManager.isCurrentTransactionReadOnly()).isFalse(); }); - assertThat(!TransactionSynchronizationManager.isSynchronizationActive()).isTrue(); + assertThat(TransactionSynchronizationManager.isSynchronizationActive()).isFalse(); assertThat(TransactionSynchronizationManager.isCurrentTransactionReadOnly()).isFalse(); @@ -139,14 +139,14 @@ class JndiJtaTransactionManagerTests { assertThat(ptm.getTransactionManager()).isEqualTo(tm); TransactionTemplate tt = new TransactionTemplate(ptm); - assertThat(!TransactionSynchronizationManager.isSynchronizationActive()).isTrue(); + assertThat(TransactionSynchronizationManager.isSynchronizationActive()).isFalse(); assertThat(TransactionSynchronizationManager.isCurrentTransactionReadOnly()).isFalse(); tt.executeWithoutResult(status -> { // something transactional assertThat(TransactionSynchronizationManager.isSynchronizationActive()).isTrue(); assertThat(TransactionSynchronizationManager.isCurrentTransactionReadOnly()).isFalse(); }); - assertThat(!TransactionSynchronizationManager.isSynchronizationActive()).isTrue(); + assertThat(TransactionSynchronizationManager.isSynchronizationActive()).isFalse(); assertThat(TransactionSynchronizationManager.isCurrentTransactionReadOnly()).isFalse(); verify(ut).begin(); @@ -170,7 +170,7 @@ class JndiJtaTransactionManagerTests { TransactionTemplate tt = new TransactionTemplate(ptm); assertThat(ptm.getTransactionSynchronization()).isEqualTo(JtaTransactionManager.SYNCHRONIZATION_ALWAYS); - assertThat(!TransactionSynchronizationManager.isSynchronizationActive()).isTrue(); + assertThat(TransactionSynchronizationManager.isSynchronizationActive()).isFalse(); assertThat(TransactionSynchronizationManager.isCurrentTransactionReadOnly()).isFalse(); tt.executeWithoutResult(status -> { // something transactional diff --git a/spring-web/src/test/java/org/springframework/web/bind/ServletRequestDataBinderTests.java b/spring-web/src/test/java/org/springframework/web/bind/ServletRequestDataBinderTests.java index 3f311f60994..17919be98b6 100644 --- a/spring-web/src/test/java/org/springframework/web/bind/ServletRequestDataBinderTests.java +++ b/spring-web/src/test/java/org/springframework/web/bind/ServletRequestDataBinderTests.java @@ -204,7 +204,7 @@ class ServletRequestDataBinderTests { request.addParameter("test_age", "" + 50); ServletRequestParameterPropertyValues pvs = new ServletRequestParameterPropertyValues(request); - assertThat(!pvs.contains("forname")).as("Didn't find normal when given prefix").isTrue(); + assertThat(pvs.contains("forname")).as("Didn't find normal when given prefix").isFalse(); assertThat(pvs.contains("test_forname")).as("Did treat prefix as normal when not given prefix").isTrue(); pvs = new ServletRequestParameterPropertyValues(request, "test"); @@ -239,7 +239,7 @@ class ServletRequestDataBinderTests { assertThat(pvs.contains("forname")).as("Contains forname").isTrue(); assertThat(pvs.contains("surname")).as("Contains surname").isTrue(); assertThat(pvs.contains("age")).as("Contains age").isTrue(); - assertThat(!pvs.contains("tory")).as("Doesn't contain tory").isTrue(); + assertThat(pvs.contains("tory")).as("Doesn't contain tory").isFalse(); PropertyValue[] ps = pvs.getPropertyValues(); Map m = new HashMap<>(); diff --git a/spring-web/src/test/java/org/springframework/web/bind/support/WebRequestDataBinderTests.java b/spring-web/src/test/java/org/springframework/web/bind/support/WebRequestDataBinderTests.java index febd27fb4b9..82769c94d62 100644 --- a/spring-web/src/test/java/org/springframework/web/bind/support/WebRequestDataBinderTests.java +++ b/spring-web/src/test/java/org/springframework/web/bind/support/WebRequestDataBinderTests.java @@ -307,7 +307,7 @@ class WebRequestDataBinderTests { request.addParameter("test_age", "" + 50); ServletRequestParameterPropertyValues pvs = new ServletRequestParameterPropertyValues(request); - assertThat(!pvs.contains("forname")).as("Didn't find normal when given prefix").isTrue(); + assertThat(pvs.contains("forname")).as("Didn't find normal when given prefix").isFalse(); assertThat(pvs.contains("test_forname")).as("Did treat prefix as normal when not given prefix").isTrue(); pvs = new ServletRequestParameterPropertyValues(request, "test"); @@ -322,7 +322,7 @@ class WebRequestDataBinderTests { assertThat(pvs.contains("forname")).as("Contains forname").isTrue(); assertThat(pvs.contains("surname")).as("Contains surname").isTrue(); assertThat(pvs.contains("age")).as("Contains age").isTrue(); - assertThat(!pvs.contains("tory")).as("Doesn't contain tory").isTrue(); + assertThat(pvs.contains("tory")).as("Doesn't contain tory").isFalse(); PropertyValue[] pvArray = pvs.getPropertyValues(); Map m = new HashMap<>(); diff --git a/spring-webmvc/src/test/java/org/springframework/web/context/ContextLoaderTests.java b/spring-webmvc/src/test/java/org/springframework/web/context/ContextLoaderTests.java index ce6858088b3..e741b2f85b3 100644 --- a/spring-webmvc/src/test/java/org/springframework/web/context/ContextLoaderTests.java +++ b/spring-webmvc/src/test/java/org/springframework/web/context/ContextLoaderTests.java @@ -77,7 +77,7 @@ class ContextLoaderTests { assertThat(context.containsBean("father")).as("Has father").isTrue(); assertThat(context.containsBean("rod")).as("Has rod").isTrue(); assertThat(context.containsBean("kerry")).as("Has kerry").isTrue(); - assertThat(!lb.isDestroyed()).as("Not destroyed").isTrue(); + assertThat(lb.isDestroyed()).as("Not destroyed").isFalse(); assertThat(context.containsBean("beans1.bean1")).isFalse(); assertThat(context.containsBean("beans1.bean2")).isFalse(); listener.contextDestroyed(event); diff --git a/spring-webmvc/src/test/java/org/springframework/web/context/XmlWebApplicationContextTests.java b/spring-webmvc/src/test/java/org/springframework/web/context/XmlWebApplicationContextTests.java index f8551d3e090..1dd0c4fabb3 100644 --- a/spring-webmvc/src/test/java/org/springframework/web/context/XmlWebApplicationContextTests.java +++ b/spring-webmvc/src/test/java/org/springframework/web/context/XmlWebApplicationContextTests.java @@ -135,9 +135,9 @@ class XmlWebApplicationContextTests extends AbstractApplicationContextTests { InitAndIB iib = (InitAndIB) this.applicationContext.getBean("init-and-ib"); assertThat(InitAndIB.constructed).isTrue(); assertThat(iib.afterPropertiesSetInvoked && iib.initMethodInvoked).isTrue(); - assertThat(!iib.destroyed && !iib.customDestroyed).isTrue(); + assertThat(iib.destroyed && !iib.customDestroyed).isFalse(); this.applicationContext.close(); - assertThat(!iib.destroyed && !iib.customDestroyed).isTrue(); + assertThat(iib.destroyed && !iib.customDestroyed).isFalse(); ConfigurableApplicationContext parent = (ConfigurableApplicationContext) this.applicationContext.getParent(); parent.close(); assertThat(iib.destroyed && iib.customDestroyed).isTrue(); diff --git a/spring-webmvc/src/test/java/org/springframework/web/servlet/tags/BindTagTests.java b/spring-webmvc/src/test/java/org/springframework/web/servlet/tags/BindTagTests.java index be5c73a111b..8ce29fd89d0 100644 --- a/spring-webmvc/src/test/java/org/springframework/web/servlet/tags/BindTagTests.java +++ b/spring-webmvc/src/test/java/org/springframework/web/servlet/tags/BindTagTests.java @@ -65,7 +65,7 @@ class BindTagTests extends AbstractTagTests { assertThat(status.getExpression()).as("Correct expression").isNull(); assertThat(status.getValue()).as("Correct value").isNull(); assertThat(status.getDisplayValue()).as("Correct displayValue").isEmpty(); - assertThat(!status.isError()).as("Correct isError").isTrue(); + assertThat(status.isError()).as("Correct isError").isFalse(); assertThat(status.getErrorCodes()).as("Correct errorCodes").isEmpty(); assertThat(status.getErrorMessages()).as("Correct errorMessages").isEmpty(); assertThat(status.getErrorCode()).as("Correct errorCode").isEmpty(); diff --git a/spring-webmvc/src/test/java/org/springframework/web/servlet/tags/HtmlEscapeTagTests.java b/spring-webmvc/src/test/java/org/springframework/web/servlet/tags/HtmlEscapeTagTests.java index bde121d2722..33f7a86125b 100644 --- a/spring-webmvc/src/test/java/org/springframework/web/servlet/tags/HtmlEscapeTagTests.java +++ b/spring-webmvc/src/test/java/org/springframework/web/servlet/tags/HtmlEscapeTagTests.java @@ -49,16 +49,16 @@ class HtmlEscapeTagTests extends AbstractTagTests { testTag.setPageContext(pc); testTag.doStartTag(); - assertThat(!tag.getRequestContext().isDefaultHtmlEscape()).as("Correct default").isTrue(); - assertThat(!testTag.isHtmlEscape()).as("Correctly applied").isTrue(); + assertThat(tag.getRequestContext().isDefaultHtmlEscape()).as("Correct default").isFalse(); + assertThat(testTag.isHtmlEscape()).as("Correctly applied").isFalse(); tag.setDefaultHtmlEscape(true); assertThat(tag.doStartTag()).as("Correct doStartTag return value").isEqualTo(Tag.EVAL_BODY_INCLUDE); assertThat(tag.getRequestContext().isDefaultHtmlEscape()).as("Correctly enabled").isTrue(); assertThat(testTag.isHtmlEscape()).as("Correctly applied").isTrue(); tag.setDefaultHtmlEscape(false); assertThat(tag.doStartTag()).as("Correct doStartTag return value").isEqualTo(Tag.EVAL_BODY_INCLUDE); - assertThat(!tag.getRequestContext().isDefaultHtmlEscape()).as("Correctly disabled").isTrue(); - assertThat(!testTag.isHtmlEscape()).as("Correctly applied").isTrue(); + assertThat(tag.getRequestContext().isDefaultHtmlEscape()).as("Correctly disabled").isFalse(); + assertThat(testTag.isHtmlEscape()).as("Correctly applied").isFalse(); tag.setDefaultHtmlEscape(true); assertThat(tag.doStartTag()).as("Correct doStartTag return value").isEqualTo(Tag.EVAL_BODY_INCLUDE); @@ -67,15 +67,15 @@ class HtmlEscapeTagTests extends AbstractTagTests { assertThat(testTag.isHtmlEscape()).as("Correctly applied").isTrue(); testTag.setHtmlEscape(false); assertThat(tag.getRequestContext().isDefaultHtmlEscape()).as("Correctly enabled").isTrue(); - assertThat(!testTag.isHtmlEscape()).as("Correctly applied").isTrue(); + assertThat(testTag.isHtmlEscape()).as("Correctly applied").isFalse(); tag.setDefaultHtmlEscape(false); assertThat(tag.doStartTag()).as("Correct doStartTag return value").isEqualTo(Tag.EVAL_BODY_INCLUDE); testTag.setHtmlEscape(true); - assertThat(!tag.getRequestContext().isDefaultHtmlEscape()).as("Correctly disabled").isTrue(); + assertThat(tag.getRequestContext().isDefaultHtmlEscape()).as("Correctly disabled").isFalse(); assertThat(testTag.isHtmlEscape()).as("Correctly applied").isTrue(); testTag.setHtmlEscape(false); - assertThat(!tag.getRequestContext().isDefaultHtmlEscape()).as("Correctly disabled").isTrue(); - assertThat(!testTag.isHtmlEscape()).as("Correctly applied").isTrue(); + assertThat(tag.getRequestContext().isDefaultHtmlEscape()).as("Correctly disabled").isFalse(); + assertThat(testTag.isHtmlEscape()).as("Correctly applied").isFalse(); } @Test @@ -88,13 +88,13 @@ class HtmlEscapeTagTests extends AbstractTagTests { tag.setPageContext(pc); tag.doStartTag(); - assertThat(!tag.getRequestContext().isDefaultHtmlEscape()).as("Correct default").isTrue(); + assertThat(tag.getRequestContext().isDefaultHtmlEscape()).as("Correct default").isFalse(); tag.setDefaultHtmlEscape(true); assertThat(tag.doStartTag()).as("Correct doStartTag return value").isEqualTo(Tag.EVAL_BODY_INCLUDE); assertThat(tag.getRequestContext().isDefaultHtmlEscape()).as("Correctly enabled").isTrue(); tag.setDefaultHtmlEscape(false); assertThat(tag.doStartTag()).as("Correct doStartTag return value").isEqualTo(Tag.EVAL_BODY_INCLUDE); - assertThat(!tag.getRequestContext().isDefaultHtmlEscape()).as("Correctly disabled").isTrue(); + assertThat(tag.getRequestContext().isDefaultHtmlEscape()).as("Correctly disabled").isFalse(); } @Test @@ -106,13 +106,13 @@ class HtmlEscapeTagTests extends AbstractTagTests { tag.doStartTag(); sc.addInitParameter(WebUtils.HTML_ESCAPE_CONTEXT_PARAM, "false"); - assertThat(!tag.getRequestContext().isDefaultHtmlEscape()).as("Correct default").isTrue(); + assertThat(tag.getRequestContext().isDefaultHtmlEscape()).as("Correct default").isFalse(); tag.setDefaultHtmlEscape(true); assertThat(tag.doStartTag()).as("Correct doStartTag return value").isEqualTo(Tag.EVAL_BODY_INCLUDE); assertThat(tag.getRequestContext().isDefaultHtmlEscape()).as("Correctly enabled").isTrue(); tag.setDefaultHtmlEscape(false); assertThat(tag.doStartTag()).as("Correct doStartTag return value").isEqualTo(Tag.EVAL_BODY_INCLUDE); - assertThat(!tag.getRequestContext().isDefaultHtmlEscape()).as("Correctly disabled").isTrue(); + assertThat(tag.getRequestContext().isDefaultHtmlEscape()).as("Correctly disabled").isFalse(); } @Test