Stop printing to System.out in tests

integration-tests/src/test/java/org/springframework/expression/spel/support/Spr7538Tests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,11 +21,15 @@ import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
 
+import org.assertj.core.api.InstanceOfAssertFactories;
 import org.junit.jupiter.api.Test;
 
 import org.springframework.core.MethodParameter;
 import org.springframework.core.convert.TypeDescriptor;
 import org.springframework.expression.MethodExecutor;
+import org.springframework.expression.TypedValue;
+
+import static org.assertj.core.api.Assertions.assertThat;
 
 class Spr7538Tests {
 
@@ -49,8 +53,9 @@ class Spr7538Tests {
 		ReflectiveMethodResolver resolver = new ReflectiveMethodResolver();
 		MethodExecutor executor = resolver.resolve(context, target, "checkCompleteness", argumentTypes);
 
-		Object result = executor.execute(context, target, arguments);
-		System.out.println("Result: " + result);
+		TypedValue typedValue = executor.execute(context, target, arguments);
+		assertThat(typedValue.getValue()).asInstanceOf(InstanceOfAssertFactories.BOOLEAN).isTrue();
+		assertThat(typedValue.getTypeDescriptor().getType()).isEqualTo(Boolean.class);
 	}
 
 	static class AlwaysTrueReleaseStrategy {

spring-aop/src/test/java/org/springframework/aop/framework/IntroductionBenchmarkTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -82,6 +82,8 @@ public class IntroductionBenchmarkTests {
 		}
 		sw.stop();
 
-		System.out.println(sw.prettyPrint());
+		// TODO Add reasonable assertions.
+		// System.out.println(sw.prettyPrint());
 	}
+
 }

spring-context/src/test/java/example/scannable/FooServiceImpl.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2022 the original author or authors.
+ * Copyright 2002-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -93,7 +93,6 @@ public abstract class FooServiceImpl implements FooService {
 	@Override
 	@SuppressWarnings("deprecation")
 	public Future<String> asyncFoo(int id) {
-		System.out.println(Thread.currentThread().getName());
 		Assert.state(ServiceInvocationCounter.getThreadLocalCount() != null, "Thread-local counter not exposed");
 		return new org.springframework.scheduling.annotation.AsyncResult<>(fooDao().findFoo(id));
 	}

spring-context/src/test/java/org/springframework/aop/target/CommonsPool2TargetSourceTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2022 the original author or authors.
+ * Copyright 2002-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -187,7 +187,6 @@ class CommonsPool2TargetSourceTests {
 
 		// release all objects
 		for (int i = 0; i < pooledInstances.length; i++) {
-			System.out.println(i);
 			targetSource.releaseTarget(pooledInstances[i]);
 		}
 	}

spring-context/src/test/java/org/springframework/context/support/Assembler.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -23,7 +23,10 @@ public class Assembler implements TestIF {
 
 	@SuppressWarnings("unused")
 	private Service service;
+
 	private Logic l;
+
+	@SuppressWarnings("unused")
 	private String name;
 
 	public void setService(Service service) {
@@ -42,7 +45,6 @@ public class Assembler implements TestIF {
 	}
 
 	public void output() {
-		System.out.println("Bean " + name);
 		l.output();
 	}
 

spring-context/src/test/java/org/springframework/context/support/Logic.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,6 +20,7 @@ import org.springframework.beans.factory.BeanNameAware;
 
 public class Logic implements BeanNameAware {
 
+	@SuppressWarnings("unused")
 	private String name;
 
 	@SuppressWarnings("unused")
@@ -35,7 +36,7 @@ public class Logic implements BeanNameAware {
 	}
 
 	public void output() {
-		System.out.println("Bean " + name);
+		// System.out.println("Bean " + name);
 	}
 
 }

spring-jms/src/test/java/org/springframework/jms/listener/adapter/StubMessageListenerAdapter.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -37,7 +37,7 @@ public class StubMessageListenerAdapter extends MessageListenerAdapter {
 
 	@Override
 	protected void handleListenerException(Throwable ex) {
-		System.out.println(ex);
+		// System.out.println(ex);
 	}
 
 }

spring-tx/src/test/java/org/springframework/dao/annotation/PersistenceExceptionTranslationPostProcessorTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -131,7 +131,7 @@ public class PersistenceExceptionTranslationPostProcessorTests {
 
 		@Before("execution(void *.additionalMethod(*))")
 		public void log(JoinPoint jp) {
-			System.out.println("Before " + jp.getSignature().getName());
+			// System.out.println("Before " + jp.getSignature().getName());
 		}
 	}
 

spring-webmvc/src/test/java/org/springframework/web/servlet/tags/form/TextareaTagTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -103,7 +103,6 @@ public class TextareaTagTests extends AbstractFormTagTests {
 
 		assertThat(this.tag.doStartTag()).isEqualTo(Tag.SKIP_BODY);
 		String output = getOutput();
-		System.out.println(output);
 		assertContainsAttribute(output, "name", "name");
 		assertBlockTagContains(output, HTML_ESCAPED_NAME);
 	}