From 39bb751546aba4780b57e0c3c2984529d0589fe3 Mon Sep 17 00:00:00 2001 From: rstoyanchev Date: Thu, 9 Jan 2025 14:15:17 +0000 Subject: [PATCH] Polishing --- .../http/client/BufferingClientHttpRequestFactory.java | 1 + .../java/org/springframework/web/client/RestClient.java | 4 ++-- .../web/client/RestClientIntegrationTests.java | 6 ++---- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/spring-web/src/main/java/org/springframework/http/client/BufferingClientHttpRequestFactory.java b/spring-web/src/main/java/org/springframework/http/client/BufferingClientHttpRequestFactory.java index 9b24a49c014..4f808eebae8 100644 --- a/spring-web/src/main/java/org/springframework/http/client/BufferingClientHttpRequestFactory.java +++ b/spring-web/src/main/java/org/springframework/http/client/BufferingClientHttpRequestFactory.java @@ -54,6 +54,7 @@ public class BufferingClientHttpRequestFactory extends AbstractClientHttpRequest /** * Constructor variant with an additional predicate to decide whether to * buffer the response. + * @since 7.0 */ public BufferingClientHttpRequestFactory( ClientHttpRequestFactory requestFactory, diff --git a/spring-web/src/main/java/org/springframework/web/client/RestClient.java b/spring-web/src/main/java/org/springframework/web/client/RestClient.java index 391ab01c1ee..28142dcb4df 100644 --- a/spring-web/src/main/java/org/springframework/web/client/RestClient.java +++ b/spring-web/src/main/java/org/springframework/web/client/RestClient.java @@ -386,8 +386,8 @@ public interface RestClient { Builder requestInterceptors(Consumer> interceptorsConsumer); /** - * Enable buffering of request and response content making it possible to - * read the request and the response body multiple times. + * Enable buffering of request and response, aggregating all content before + * it is sent, and making it possible to read the response body repeatedly. * @param predicate to determine whether to buffer for the given request * @return this builder * @since 7.0 diff --git a/spring-web/src/test/java/org/springframework/web/client/RestClientIntegrationTests.java b/spring-web/src/test/java/org/springframework/web/client/RestClientIntegrationTests.java index 81639730ccd..36ec54c60ce 100644 --- a/spring-web/src/test/java/org/springframework/web/client/RestClientIntegrationTests.java +++ b/spring-web/src/test/java/org/springframework/web/client/RestClientIntegrationTests.java @@ -834,9 +834,8 @@ class RestClientIntegrationTests { .retrieve() .body(String.class); - assertThat(result).isEqualTo("Hello Spring!"); - expectRequestCount(1); + assertThat(result).isEqualTo("Hello Spring!"); } @ParameterizedRestClientTest @@ -860,9 +859,8 @@ class RestClientIntegrationTests { return new String(bytes, UTF_8); }); - assertThat(result).isEqualTo("Hello Spring!"); - expectRequestCount(1); + assertThat(result).isEqualTo("Hello Spring!"); } @ParameterizedRestClientTest