Browse Source

Merge branch '6.2.x'

pull/34319/head
Juergen Hoeller 1 year ago
parent
commit
3302bc46f8
  1. 5
      spring-core/src/main/java/org/springframework/core/convert/support/GenericConversionService.java
  2. 48
      spring-core/src/test/java/org/springframework/core/convert/support/GenericConversionServiceTests.java

5
spring-core/src/main/java/org/springframework/core/convert/support/GenericConversionService.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2024 the original author or authors. * Copyright 2002-2025 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -334,8 +334,7 @@ public class GenericConversionService implements ConfigurableConversionService {
} }
// Full check for complex generic type match required? // Full check for complex generic type match required?
ResolvableType rt = targetType.getResolvableType(); ResolvableType rt = targetType.getResolvableType();
if (!(rt.getType() instanceof Class) && !rt.isAssignableFrom(this.targetType) && if (!(rt.getType() instanceof Class) && !rt.isAssignableFromResolvedPart(this.targetType)) {
!this.targetType.hasUnresolvableGenerics()) {
return false; return false;
} }
return !(this.converter instanceof ConditionalConverter conditionalConverter) || return !(this.converter instanceof ConditionalConverter conditionalConverter) ||

48
spring-core/src/test/java/org/springframework/core/convert/support/GenericConversionServiceTests.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2024 the original author or authors. * Copyright 2002-2025 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -565,6 +565,22 @@ class GenericConversionServiceTests {
assertThat(conversionService.convert("test", TypeDescriptor.valueOf(String.class), new TypeDescriptor(getClass().getField("integerCollection")))).isEqualTo(Collections.singleton("testX")); assertThat(conversionService.convert("test", TypeDescriptor.valueOf(String.class), new TypeDescriptor(getClass().getField("integerCollection")))).isEqualTo(Collections.singleton("testX"));
} }
@Test
void stringListToListOfSubclassOfUnboundGenericClass() {
conversionService.addConverter(new StringListToAListConverter());
conversionService.addConverter(new StringListToBListConverter());
List<ARaw> aList = (List<ARaw>) conversionService.convert(List.of("foo"),
TypeDescriptor.collection(List.class, TypeDescriptor.valueOf(String.class)),
TypeDescriptor.collection(List.class, TypeDescriptor.valueOf(ARaw.class)));
assertThat(aList).allMatch(e -> e instanceof ARaw);
List<BRaw> bList = (List<BRaw>) conversionService.convert(List.of("foo"),
TypeDescriptor.collection(List.class, TypeDescriptor.valueOf(String.class)),
TypeDescriptor.collection(List.class, TypeDescriptor.valueOf(BRaw.class)));
assertThat(bList).allMatch(e -> e instanceof BRaw);
}
@ExampleAnnotation(active = true) @ExampleAnnotation(active = true)
public String annotatedString; public String annotatedString;
@ -740,6 +756,7 @@ class GenericConversionServiceTests {
} }
} }
private interface MyEnumBaseInterface { private interface MyEnumBaseInterface {
String getBaseCode(); String getBaseCode();
} }
@ -921,4 +938,33 @@ class GenericConversionServiceTests {
return Color.decode(source.substring(0, 6)); return Color.decode(source.substring(0, 6));
} }
} }
private static class GenericBaseClass<T> {
}
private static class ARaw extends GenericBaseClass {
}
private static class BRaw extends GenericBaseClass {
}
private static class StringListToAListConverter implements Converter<List<String>, List<ARaw>> {
@Override
public List<ARaw> convert(List<String> source) {
return List.of(new ARaw());
}
}
private static class StringListToBListConverter implements Converter<List<String>, List<BRaw>> {
@Override
public List<BRaw> convert(List<String> source) {
return List.of(new BRaw());
}
}
} }

Loading…
Cancel
Save