From 324c310cbd3a95da73d36a6f868a538742a10c4f Mon Sep 17 00:00:00 2001 From: Sebastien Deleuze Date: Mon, 3 Oct 2016 10:58:24 +0200 Subject: [PATCH] Log unresolved exceptions at error level --- .../http/server/reactive/ReactorHttpHandlerAdapter.java | 2 +- .../http/server/reactive/RxNettyHttpHandlerAdapter.java | 2 +- .../http/server/reactive/ServletHttpHandlerAdapter.java | 2 +- .../http/server/reactive/UndertowHttpHandlerAdapter.java | 2 +- .../web/server/adapter/WebHttpHandlerBuilder.java | 6 ++---- .../web/server/handler/ExceptionHandlingWebHandler.java | 2 +- 6 files changed, 7 insertions(+), 9 deletions(-) diff --git a/spring-web/src/main/java/org/springframework/http/server/reactive/ReactorHttpHandlerAdapter.java b/spring-web/src/main/java/org/springframework/http/server/reactive/ReactorHttpHandlerAdapter.java index 39d7f5ae139..341b9b30409 100644 --- a/spring-web/src/main/java/org/springframework/http/server/reactive/ReactorHttpHandlerAdapter.java +++ b/spring-web/src/main/java/org/springframework/http/server/reactive/ReactorHttpHandlerAdapter.java @@ -54,7 +54,7 @@ public class ReactorHttpHandlerAdapter implements Function { - logger.debug("Could not complete request", ex); + logger.error("Could not complete request", ex); channel.status(HttpResponseStatus.INTERNAL_SERVER_ERROR); return Mono.empty(); }) diff --git a/spring-web/src/main/java/org/springframework/http/server/reactive/RxNettyHttpHandlerAdapter.java b/spring-web/src/main/java/org/springframework/http/server/reactive/RxNettyHttpHandlerAdapter.java index ffb580869b2..d8f09908810 100644 --- a/spring-web/src/main/java/org/springframework/http/server/reactive/RxNettyHttpHandlerAdapter.java +++ b/spring-web/src/main/java/org/springframework/http/server/reactive/RxNettyHttpHandlerAdapter.java @@ -58,7 +58,7 @@ public class RxNettyHttpHandlerAdapter implements RequestHandler result = this.delegate.handle(adaptedRequest, adaptedResponse) .otherwise(ex -> { - logger.debug("Could not complete request", ex); + logger.error("Could not complete request", ex); response.setStatus(HttpResponseStatus.INTERNAL_SERVER_ERROR); return Mono.empty(); }) diff --git a/spring-web/src/main/java/org/springframework/http/server/reactive/ServletHttpHandlerAdapter.java b/spring-web/src/main/java/org/springframework/http/server/reactive/ServletHttpHandlerAdapter.java index 78a4419ed0f..0b6c51ece0f 100644 --- a/spring-web/src/main/java/org/springframework/http/server/reactive/ServletHttpHandlerAdapter.java +++ b/spring-web/src/main/java/org/springframework/http/server/reactive/ServletHttpHandlerAdapter.java @@ -114,7 +114,7 @@ public class ServletHttpHandlerAdapter extends HttpServlet { @Override public void onError(Throwable ex) { - logger.debug("Could not complete request", ex); + logger.error("Could not complete request", ex); HttpServletResponse response = (HttpServletResponse) this.asyncContext.getResponse(); response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR); this.asyncContext.complete(); diff --git a/spring-web/src/main/java/org/springframework/http/server/reactive/UndertowHttpHandlerAdapter.java b/spring-web/src/main/java/org/springframework/http/server/reactive/UndertowHttpHandlerAdapter.java index 7726ef4e7e6..0bd48cb7380 100644 --- a/spring-web/src/main/java/org/springframework/http/server/reactive/UndertowHttpHandlerAdapter.java +++ b/spring-web/src/main/java/org/springframework/http/server/reactive/UndertowHttpHandlerAdapter.java @@ -72,7 +72,7 @@ public class UndertowHttpHandlerAdapter implements io.undertow.server.HttpHandle } @Override public void onError(Throwable ex) { - logger.debug("Could not complete request", ex); + logger.error("Could not complete request", ex); if (!exchange.isResponseStarted() && exchange.getStatusCode() <= 500) { exchange.setStatusCode(500); } diff --git a/spring-web/src/main/java/org/springframework/web/server/adapter/WebHttpHandlerBuilder.java b/spring-web/src/main/java/org/springframework/web/server/adapter/WebHttpHandlerBuilder.java index e3dde3ee359..70bf4305192 100644 --- a/spring-web/src/main/java/org/springframework/web/server/adapter/WebHttpHandlerBuilder.java +++ b/spring-web/src/main/java/org/springframework/web/server/adapter/WebHttpHandlerBuilder.java @@ -123,10 +123,8 @@ public class WebHttpHandlerBuilder { WebFilter[] array = new WebFilter[this.filters.size()]; webHandler = new FilteringWebHandler(webHandler, this.filters.toArray(array)); } - if (!this.exceptionHandlers.isEmpty()) { - WebExceptionHandler[] array = new WebExceptionHandler[this.exceptionHandlers.size()]; - webHandler = new ExceptionHandlingWebHandler(webHandler, this.exceptionHandlers.toArray(array)); - } + WebExceptionHandler[] array = new WebExceptionHandler[this.exceptionHandlers.size()]; + webHandler = new ExceptionHandlingWebHandler(webHandler, this.exceptionHandlers.toArray(array)); HttpWebHandlerAdapter httpHandler = new HttpWebHandlerAdapter(webHandler); if (this.sessionManager != null) { httpHandler.setSessionManager(this.sessionManager); diff --git a/spring-web/src/main/java/org/springframework/web/server/handler/ExceptionHandlingWebHandler.java b/spring-web/src/main/java/org/springframework/web/server/handler/ExceptionHandlingWebHandler.java index ecf8d3e8de2..a36836c8bea 100644 --- a/spring-web/src/main/java/org/springframework/web/server/handler/ExceptionHandlingWebHandler.java +++ b/spring-web/src/main/java/org/springframework/web/server/handler/ExceptionHandlingWebHandler.java @@ -128,7 +128,7 @@ public class ExceptionHandlingWebHandler extends WebHandlerDecorator { } } else { - logger.debug("Could not complete request", ex); + logger.error("Could not complete request", ex); } }