Browse Source

Populate dependencies metadata for resolved target behind lazy dependency proxy

Closes gh-25562
pull/26515/head
Juergen Hoeller 6 years ago
parent
commit
265bc6cd65
  1. 29
      spring-context/src/main/java/org/springframework/context/annotation/ContextAnnotationAutowireCandidateResolver.java
  2. 12
      spring-context/src/test/java/org/springframework/context/annotation/LazyAutowiredAnnotationBeanPostProcessorTests.java

29
spring-context/src/main/java/org/springframework/context/annotation/ContextAnnotationAutowireCandidateResolver.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2017 the original author or authors. * Copyright 2002-2020 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -20,12 +20,14 @@ import java.lang.annotation.Annotation;
import java.lang.reflect.Method; import java.lang.reflect.Method;
import java.util.Collection; import java.util.Collection;
import java.util.Collections; import java.util.Collections;
import java.util.LinkedHashSet;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Set; import java.util.Set;
import org.springframework.aop.TargetSource; import org.springframework.aop.TargetSource;
import org.springframework.aop.framework.ProxyFactory; import org.springframework.aop.framework.ProxyFactory;
import org.springframework.beans.factory.BeanFactory;
import org.springframework.beans.factory.NoSuchBeanDefinitionException; import org.springframework.beans.factory.NoSuchBeanDefinitionException;
import org.springframework.beans.factory.annotation.QualifierAnnotationAutowireCandidateResolver; import org.springframework.beans.factory.annotation.QualifierAnnotationAutowireCandidateResolver;
import org.springframework.beans.factory.config.DependencyDescriptor; import org.springframework.beans.factory.config.DependencyDescriptor;
@ -71,9 +73,11 @@ public class ContextAnnotationAutowireCandidateResolver extends QualifierAnnotat
} }
protected Object buildLazyResolutionProxy(final DependencyDescriptor descriptor, final String beanName) { protected Object buildLazyResolutionProxy(final DependencyDescriptor descriptor, final String beanName) {
Assert.state(getBeanFactory() instanceof DefaultListableBeanFactory, BeanFactory beanFactory = getBeanFactory();
Assert.state(beanFactory instanceof DefaultListableBeanFactory,
"BeanFactory needs to be a DefaultListableBeanFactory"); "BeanFactory needs to be a DefaultListableBeanFactory");
final DefaultListableBeanFactory beanFactory = (DefaultListableBeanFactory) getBeanFactory(); final DefaultListableBeanFactory dlbf = (DefaultListableBeanFactory) beanFactory;
TargetSource ts = new TargetSource() { TargetSource ts = new TargetSource() {
@Override @Override
public Class<?> getTargetClass() { public Class<?> getTargetClass() {
@ -85,34 +89,43 @@ public class ContextAnnotationAutowireCandidateResolver extends QualifierAnnotat
} }
@Override @Override
public Object getTarget() { public Object getTarget() {
Object target = beanFactory.doResolveDependency(descriptor, beanName, null, null); Set<String> autowiredBeanNames = (beanName != null ? new LinkedHashSet<String>(1) : null);
Object target = dlbf.doResolveDependency(descriptor, beanName, autowiredBeanNames, null);
if (target == null) { if (target == null) {
Class<?> type = getTargetClass(); Class<?> type = getTargetClass();
if (Map.class == type) { if (Map.class == type) {
return Collections.EMPTY_MAP; return Collections.emptyMap();
} }
else if (List.class == type) { else if (List.class == type) {
return Collections.EMPTY_LIST; return Collections.emptyList();
} }
else if (Set.class == type || Collection.class == type) { else if (Set.class == type || Collection.class == type) {
return Collections.EMPTY_SET; return Collections.emptySet();
} }
throw new NoSuchBeanDefinitionException(descriptor.getResolvableType(), throw new NoSuchBeanDefinitionException(descriptor.getResolvableType(),
"Optional dependency not present for lazy injection point"); "Optional dependency not present for lazy injection point");
} }
if (autowiredBeanNames != null) {
for (String autowiredBeanName : autowiredBeanNames) {
if (dlbf.containsBean(autowiredBeanName)) {
dlbf.registerDependentBean(autowiredBeanName, beanName);
}
}
}
return target; return target;
} }
@Override @Override
public void releaseTarget(Object target) { public void releaseTarget(Object target) {
} }
}; };
ProxyFactory pf = new ProxyFactory(); ProxyFactory pf = new ProxyFactory();
pf.setTargetSource(ts); pf.setTargetSource(ts);
Class<?> dependencyType = descriptor.getDependencyType(); Class<?> dependencyType = descriptor.getDependencyType();
if (dependencyType.isInterface()) { if (dependencyType.isInterface()) {
pf.addInterface(dependencyType); pf.addInterface(dependencyType);
} }
return pf.getProxy(beanFactory.getBeanClassLoader()); return pf.getProxy(dlbf.getBeanClassLoader());
} }
} }

12
spring-context/src/test/java/org/springframework/context/annotation/LazyAutowiredAnnotationBeanPostProcessorTests.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2017 the original author or authors. * Copyright 2002-2020 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -25,9 +25,11 @@ import org.junit.Test;
import org.springframework.beans.factory.NoSuchBeanDefinitionException; import org.springframework.beans.factory.NoSuchBeanDefinitionException;
import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor; import org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor;
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
import org.springframework.beans.factory.support.DefaultListableBeanFactory; import org.springframework.beans.factory.support.DefaultListableBeanFactory;
import org.springframework.beans.factory.support.RootBeanDefinition; import org.springframework.beans.factory.support.RootBeanDefinition;
import org.springframework.tests.sample.beans.TestBean; import org.springframework.tests.sample.beans.TestBean;
import org.springframework.util.ObjectUtils;
import static org.junit.Assert.*; import static org.junit.Assert.*;
@ -47,14 +49,18 @@ public class LazyAutowiredAnnotationBeanPostProcessorTests {
ac.registerBeanDefinition("testBean", tbd); ac.registerBeanDefinition("testBean", tbd);
ac.refresh(); ac.refresh();
ConfigurableListableBeanFactory bf = ac.getBeanFactory();
TestBeanHolder bean = ac.getBean("annotatedBean", TestBeanHolder.class); TestBeanHolder bean = ac.getBean("annotatedBean", TestBeanHolder.class);
assertFalse(ac.getBeanFactory().containsSingleton("testBean")); assertFalse(bf.containsSingleton("testBean"));
assertNotNull(bean.getTestBean()); assertNotNull(bean.getTestBean());
assertNull(bean.getTestBean().getName()); assertNull(bean.getTestBean().getName());
assertTrue(ac.getBeanFactory().containsSingleton("testBean")); assertTrue(bf.containsSingleton("testBean"));
TestBean tb = (TestBean) ac.getBean("testBean"); TestBean tb = (TestBean) ac.getBean("testBean");
tb.setName("tb"); tb.setName("tb");
assertSame("tb", bean.getTestBean().getName()); assertSame("tb", bean.getTestBean().getName());
assertTrue(ObjectUtils.containsElement(bf.getDependenciesForBean("annotatedBean"), "testBean"));
assertTrue(ObjectUtils.containsElement(bf.getDependentBeans("testBean"), "annotatedBean"));
} }
@Test @Test

Loading…
Cancel
Save