Merge pull request #765 from poutsma/SPR-12779

Netty4ClientHttpRequest ignores query params

spring-web/src/main/java/org/springframework/http/client/Netty4ClientHttpRequest.java

@@ -147,7 +147,7 @@ class Netty4ClientHttpRequest extends AbstractAsyncClientHttpRequest implements
 				io.netty.handler.codec.http.HttpMethod.valueOf(this.method.name());
 
 		FullHttpRequest nettyRequest = new DefaultFullHttpRequest(HttpVersion.HTTP_1_1,
-				nettyMethod, this.uri.getRawPath(), this.body.buffer());
+				nettyMethod, this.uri.toString(), this.body.buffer());
 
 		nettyRequest.headers().set(HttpHeaders.HOST, uri.getHost());
 		nettyRequest.headers().set(HttpHeaders.CONNECTION, io.netty.handler.codec.http.HttpHeaders.Values.CLOSE);

spring-web/src/test/java/org/springframework/http/client/AbstractHttpRequestFactoryTestCase.java

@@ -180,4 +180,18 @@ public abstract class AbstractHttpRequestFactoryTestCase extends
 		}
 	}
 
+	@Test
+	public void queryParameters() throws Exception {
+		URI uri = new URI(baseUrl + "/params?param1=value&param2=value1&param2=value2");
+		ClientHttpRequest request = factory.createRequest(uri, HttpMethod.GET);
+
+		ClientHttpResponse response = request.execute();
+		try {
+			assertEquals("Invalid status code", HttpStatus.OK, response.getStatusCode());
+		}
+		finally {
+			response.close();
+		}
+	}
+
 }

spring-web/src/test/java/org/springframework/http/client/AbstractJettyServerTestCase.java

@@ -19,6 +19,7 @@ package org.springframework.http.client;
 import java.io.IOException;
 import java.io.InputStream;
 import java.util.Enumeration;
+import java.util.Map;
 import javax.servlet.GenericServlet;
 import javax.servlet.ServletException;
 import javax.servlet.ServletRequest;
@@ -38,7 +39,7 @@ import org.springframework.util.SocketUtils;
 import org.springframework.util.StreamUtils;
 
 /** @author Arjen Poutsma */
-public class AbstractJettyServerTestCase {
+public abstract class AbstractJettyServerTestCase {
 
 	protected static String baseUrl;
 
@@ -54,6 +55,7 @@ public class AbstractJettyServerTestCase {
 		handler.setContextPath("/");
 
 		handler.addServlet(new ServletHolder(new EchoServlet()), "/echo");
+		handler.addServlet(new ServletHolder(new ParameterServlet()), "/params");
 		handler.addServlet(new ServletHolder(new StatusServlet(200)), "/status/ok");
 		handler.addServlet(new ServletHolder(new StatusServlet(404)), "/status/notfound");
 		handler.addServlet(new ServletHolder(new MethodServlet("DELETE")), "/methods/delete");
@@ -158,4 +160,28 @@ public class AbstractJettyServerTestCase {
 			StreamUtils.copy(request.getInputStream(), response.getOutputStream());
 		}
 	}
+
+	@SuppressWarnings("serial")
+	private static class ParameterServlet extends HttpServlet {
+
+		@Override
+		protected void service(HttpServletRequest req, HttpServletResponse resp)
+				throws ServletException, IOException {
+			Map<String, String[]> parameters = req.getParameterMap();
+			assertEquals(2, parameters.size());
+
+			String[] values = parameters.get("param1");
+			assertEquals(1, values.length);
+			assertEquals("value", values[0]);
+
+			values = parameters.get("param2");
+			assertEquals(2, values.length);
+			assertEquals("value1", values[0]);
+			assertEquals("value2", values[1]);
+
+			resp.setStatus(200);
+			resp.setContentLength(0);
+		}
+	}
+
 }