Browse Source

Polishing

(cherry picked from commit 9e03e0e)
pull/941/head
Juergen Hoeller 10 years ago
parent
commit
241dfbf855
  1. 2
      spring-orm/src/main/java/org/springframework/orm/hibernate3/support/IdTransferringMergeEventListener.java
  2. 12
      spring-webmvc-portlet/src/main/java/org/springframework/web/portlet/mvc/annotation/AnnotationMethodHandlerExceptionResolver.java
  3. 14
      spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/annotation/AnnotationMethodHandlerExceptionResolver.java

2
spring-orm/src/main/java/org/springframework/orm/hibernate3/support/IdTransferringMergeEventListener.java

@ -49,7 +49,7 @@ import org.hibernate.persister.entity.EntityPersister;
* @since 1.2 * @since 1.2
* @see org.springframework.orm.hibernate3.LocalSessionFactoryBean#setEventListeners(java.util.Map) * @see org.springframework.orm.hibernate3.LocalSessionFactoryBean#setEventListeners(java.util.Map)
*/ */
@SuppressWarnings({ "serial", "rawtypes", "deprecation" }) @SuppressWarnings({"serial", "rawtypes", "deprecation"})
public class IdTransferringMergeEventListener extends DefaultMergeEventListener { public class IdTransferringMergeEventListener extends DefaultMergeEventListener {
/** /**

12
spring-webmvc-portlet/src/main/java/org/springframework/web/portlet/mvc/annotation/AnnotationMethodHandlerExceptionResolver.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2012 the original author or authors. * Copyright 2002-2015 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -74,9 +74,11 @@ import org.springframework.web.servlet.View;
*/ */
public class AnnotationMethodHandlerExceptionResolver extends AbstractHandlerExceptionResolver { public class AnnotationMethodHandlerExceptionResolver extends AbstractHandlerExceptionResolver {
// dummy method placeholder /**
private static final Method NO_METHOD_FOUND = * Arbitrary {@link Method} reference, indicating no method found in the cache.
ClassUtils.getMethodIfAvailable(System.class, "currentTimeMillis", (Class<?>[]) null); */
private static final Method NO_METHOD_FOUND = ClassUtils.getMethodIfAvailable(System.class, "currentTimeMillis");
private final Map<Class<?>, Map<Class<? extends Throwable>, Method>> exceptionHandlerCache = private final Map<Class<?>, Map<Class<? extends Throwable>, Method>> exceptionHandlerCache =
new ConcurrentHashMap<Class<?>, Map<Class<? extends Throwable>, Method>>(64); new ConcurrentHashMap<Class<?>, Map<Class<? extends Throwable>, Method>>(64);
@ -209,7 +211,7 @@ public class AnnotationMethodHandlerExceptionResolver extends AbstractHandlerExc
/** /**
* Uses the {@link ExceptionDepthComparator} to find the best matching method. * Uses the {@link ExceptionDepthComparator} to find the best matching method.
* @return the best matching method or {@code null}. * @return the best matching method, or {@code null} if none found
*/ */
private Method getBestMatchingMethod( private Method getBestMatchingMethod(
Map<Class<? extends Throwable>, Method> resolverMethods, Exception thrownException) { Map<Class<? extends Throwable>, Method> resolverMethods, Exception thrownException) {

14
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/annotation/AnnotationMethodHandlerExceptionResolver.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2012 the original author or authors. * Copyright 2002-2015 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -80,15 +80,17 @@ import org.springframework.web.servlet.support.RequestContextUtils;
* @author Arjen Poutsma * @author Arjen Poutsma
* @author Juergen Hoeller * @author Juergen Hoeller
* @since 3.0 * @since 3.0
*
* @deprecated as of Spring 3.2, in favor of * @deprecated as of Spring 3.2, in favor of
* {@link org.springframework.web.servlet.mvc.method.annotation.ExceptionHandlerExceptionResolver ExceptionHandlerExceptionResolver} * {@link org.springframework.web.servlet.mvc.method.annotation.ExceptionHandlerExceptionResolver ExceptionHandlerExceptionResolver}
*/ */
@Deprecated @Deprecated
public class AnnotationMethodHandlerExceptionResolver extends AbstractHandlerExceptionResolver { public class AnnotationMethodHandlerExceptionResolver extends AbstractHandlerExceptionResolver {
// dummy method placeholder /**
private static final Method NO_METHOD_FOUND = ClassUtils.getMethodIfAvailable(System.class, "currentTimeMillis", (Class<?>[]) null); * Arbitrary {@link Method} reference, indicating no method found in the cache.
*/
private static final Method NO_METHOD_FOUND = ClassUtils.getMethodIfAvailable(System.class, "currentTimeMillis");
private final Map<Class<?>, Map<Class<? extends Throwable>, Method>> exceptionHandlerCache = private final Map<Class<?>, Map<Class<? extends Throwable>, Method>> exceptionHandlerCache =
new ConcurrentHashMap<Class<?>, Map<Class<? extends Throwable>, Method>>(64); new ConcurrentHashMap<Class<?>, Map<Class<? extends Throwable>, Method>>(64);
@ -233,8 +235,8 @@ public class AnnotationMethodHandlerExceptionResolver extends AbstractHandlerExc
} }
/** /**
* Uses the {@link DepthComparator} to find the best matching method * Uses the {@link ExceptionDepthComparator} to find the best matching method.
* @return the best matching method or {@code null}. * @return the best matching method, or {@code null} if none found
*/ */
private Method getBestMatchingMethod( private Method getBestMatchingMethod(
Map<Class<? extends Throwable>, Method> resolverMethods, Exception thrownException) { Map<Class<? extends Throwable>, Method> resolverMethods, Exception thrownException) {

Loading…
Cancel
Save