diff --git a/spring-core/src/main/java/org/springframework/core/SpringProperties.java b/spring-core/src/main/java/org/springframework/core/SpringProperties.java index fe6def84bea..01813e2596a 100644 --- a/spring-core/src/main/java/org/springframework/core/SpringProperties.java +++ b/spring-core/src/main/java/org/springframework/core/SpringProperties.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2013 the original author or authors. + * Copyright 2002-2014 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -44,6 +44,8 @@ import org.apache.commons.logging.LogFactory; */ public abstract class SpringProperties { + private static final String PROPERTIES_RESOURCE_LOCATION = "spring.properties"; + private static final Log logger = LogFactory.getLog(SpringProperties.class); private static final Properties localProperties = new Properties(); @@ -52,7 +54,7 @@ public abstract class SpringProperties { static { try { ClassLoader cl = SpringProperties.class.getClassLoader(); - URL url = cl.getResource("spring.properties"); + URL url = cl.getResource(PROPERTIES_RESOURCE_LOCATION); if (url != null) { logger.info("Found 'spring.properties' file in local classpath"); InputStream is = url.openStream(); diff --git a/spring-core/src/test/java/org/springframework/core/env/StandardEnvironmentTests.java b/spring-core/src/test/java/org/springframework/core/env/StandardEnvironmentTests.java index 964ba389875..01daf449dcf 100644 --- a/spring-core/src/test/java/org/springframework/core/env/StandardEnvironmentTests.java +++ b/spring-core/src/test/java/org/springframework/core/env/StandardEnvironmentTests.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2013 the original author or authors. + * Copyright 2002-2014 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -354,6 +354,13 @@ public class StandardEnvironmentTests { SpringProperties.setProperty("spring.getenv.ignore", null); } + @Test + public void suppressGetenvAccessThroughSpringFlag() { + SpringProperties.setFlag("spring.getenv.ignore"); + assertTrue(environment.getSystemEnvironment().isEmpty()); + SpringProperties.setProperty("spring.getenv.ignore", null); + } + @Test public void getSystemProperties_withAndWithoutSecurityManager() { System.setProperty(ALLOWED_PROPERTY_NAME, ALLOWED_PROPERTY_VALUE);