diff --git a/spring-context/src/main/java/org/springframework/validation/beanvalidation/LocalValidatorFactoryBean.java b/spring-context/src/main/java/org/springframework/validation/beanvalidation/LocalValidatorFactoryBean.java index badc4f1219c..f144c092569 100644 --- a/spring-context/src/main/java/org/springframework/validation/beanvalidation/LocalValidatorFactoryBean.java +++ b/spring-context/src/main/java/org/springframework/validation/beanvalidation/LocalValidatorFactoryBean.java @@ -377,47 +377,45 @@ public class LocalValidatorFactoryBean extends SpringValidatorAdapter protected void postProcessConfiguration(Configuration configuration) { } + private ValidatorFactory obtainValidatorFactory() { + Assert.state(this.validatorFactory != null, "No target ValidatorFactory set"); + return this.validatorFactory; + } + @Override public Validator getValidator() { - Assert.state(this.validatorFactory != null, "No target ValidatorFactory set"); - return this.validatorFactory.getValidator(); + return obtainValidatorFactory().getValidator(); } @Override public ValidatorContext usingContext() { - Assert.state(this.validatorFactory != null, "No target ValidatorFactory set"); - return this.validatorFactory.usingContext(); + return obtainValidatorFactory().usingContext(); } @Override public MessageInterpolator getMessageInterpolator() { - Assert.state(this.validatorFactory != null, "No target ValidatorFactory set"); - return this.validatorFactory.getMessageInterpolator(); + return obtainValidatorFactory().getMessageInterpolator(); } @Override public TraversableResolver getTraversableResolver() { - Assert.state(this.validatorFactory != null, "No target ValidatorFactory set"); - return this.validatorFactory.getTraversableResolver(); + return obtainValidatorFactory().getTraversableResolver(); } @Override public ConstraintValidatorFactory getConstraintValidatorFactory() { - Assert.state(this.validatorFactory != null, "No target ValidatorFactory set"); - return this.validatorFactory.getConstraintValidatorFactory(); + return obtainValidatorFactory().getConstraintValidatorFactory(); } @Override public ParameterNameProvider getParameterNameProvider() { - Assert.state(this.validatorFactory != null, "No target ValidatorFactory set"); - return this.validatorFactory.getParameterNameProvider(); + return obtainValidatorFactory().getParameterNameProvider(); } @Override public ClockProvider getClockProvider() { - Assert.state(this.validatorFactory != null, "No target ValidatorFactory set"); - return this.validatorFactory.getClockProvider(); + return obtainValidatorFactory().getClockProvider(); } @Override @@ -427,8 +425,8 @@ public class LocalValidatorFactoryBean extends SpringValidatorAdapter try { return super.unwrap(type); } - catch (ValidationException ex) { - // Ignore - we'll try ValidatorFactory unwrapping next + catch (ValidationException ignored) { + // Trying ValidatorFactory unwrapping next } } if (this.validatorFactory != null) { diff --git a/spring-context/src/main/java/org/springframework/validation/beanvalidation/MessageSourceResourceBundleLocator.java b/spring-context/src/main/java/org/springframework/validation/beanvalidation/MessageSourceResourceBundleLocator.java index 8e34503d301..13041c45dac 100644 --- a/spring-context/src/main/java/org/springframework/validation/beanvalidation/MessageSourceResourceBundleLocator.java +++ b/spring-context/src/main/java/org/springframework/validation/beanvalidation/MessageSourceResourceBundleLocator.java @@ -26,7 +26,7 @@ import org.springframework.context.support.MessageSourceResourceBundle; import org.springframework.util.Assert; /** - * Implementation of Hibernate Validator 4.3/5.x's {@link ResourceBundleLocator} interface, + * Implementation of Hibernate Validator's {@link ResourceBundleLocator} interface, * exposing a Spring {@link MessageSource} as localized {@link MessageSourceResourceBundle}. * * @author Juergen Hoeller @@ -39,6 +39,7 @@ public class MessageSourceResourceBundleLocator implements ResourceBundleLocator private final MessageSource messageSource; + /** * Build a MessageSourceResourceBundleLocator for the given MessageSource. * @param messageSource the Spring MessageSource to wrap @@ -48,6 +49,7 @@ public class MessageSourceResourceBundleLocator implements ResourceBundleLocator this.messageSource = messageSource; } + @Override public ResourceBundle getResourceBundle(Locale locale) { return new MessageSourceResourceBundle(this.messageSource, locale); diff --git a/spring-web/src/main/java/org/springframework/http/converter/AbstractGenericHttpMessageConverter.java b/spring-web/src/main/java/org/springframework/http/converter/AbstractGenericHttpMessageConverter.java index c4e8de7a9c8..6dcfb3447dd 100644 --- a/spring-web/src/main/java/org/springframework/http/converter/AbstractGenericHttpMessageConverter.java +++ b/spring-web/src/main/java/org/springframework/http/converter/AbstractGenericHttpMessageConverter.java @@ -93,7 +93,7 @@ public abstract class AbstractGenericHttpMessageConverter extends AbstractHtt * and then calls {@link #writeInternal}. */ @Override - public final void write(final T t, @Nullable final Type type, @Nullable MediaType contentType, + public final void write(final T t, final @Nullable Type type, @Nullable MediaType contentType, HttpOutputMessage outputMessage) throws IOException, HttpMessageNotWritableException { final HttpHeaders headers = outputMessage.getHeaders(); @@ -108,14 +108,12 @@ public abstract class AbstractGenericHttpMessageConverter extends AbstractHtt public OutputStream getBody() { return outputStream; } - @Override public HttpHeaders getHeaders() { return headers; } }); } - @Override public boolean repeatable() { return supportsRepeatableWrites(t); diff --git a/spring-web/src/main/java/org/springframework/http/converter/AbstractHttpMessageConverter.java b/spring-web/src/main/java/org/springframework/http/converter/AbstractHttpMessageConverter.java index 032637fb269..4559ea375e2 100644 --- a/spring-web/src/main/java/org/springframework/http/converter/AbstractHttpMessageConverter.java +++ b/spring-web/src/main/java/org/springframework/http/converter/AbstractHttpMessageConverter.java @@ -224,7 +224,6 @@ public abstract class AbstractHttpMessageConverter implements HttpMessageConv } }); } - @Override public boolean repeatable() { return supportsRepeatableWrites(t); diff --git a/spring-web/src/main/java/org/springframework/http/converter/AbstractSmartHttpMessageConverter.java b/spring-web/src/main/java/org/springframework/http/converter/AbstractSmartHttpMessageConverter.java index 1842b474a2a..5b86c8e36ef 100644 --- a/spring-web/src/main/java/org/springframework/http/converter/AbstractSmartHttpMessageConverter.java +++ b/spring-web/src/main/java/org/springframework/http/converter/AbstractSmartHttpMessageConverter.java @@ -106,7 +106,6 @@ public abstract class AbstractSmartHttpMessageConverter extends AbstractHttpM } }, hints); } - @Override public boolean repeatable() { return supportsRepeatableWrites(t); diff --git a/spring-web/src/main/java/org/springframework/http/converter/BufferedImageHttpMessageConverter.java b/spring-web/src/main/java/org/springframework/http/converter/BufferedImageHttpMessageConverter.java index 49cd6a65724..864158bddd3 100644 --- a/spring-web/src/main/java/org/springframework/http/converter/BufferedImageHttpMessageConverter.java +++ b/spring-web/src/main/java/org/springframework/http/converter/BufferedImageHttpMessageConverter.java @@ -218,7 +218,7 @@ public class BufferedImageHttpMessageConverter implements HttpMessageConverter