Browse Source

LocalVariableTableParameterNameDiscoverer works for bridge methods as well

Issue: SPR-9429
3.1.x
Juergen Hoeller 13 years ago
parent
commit
1bca2c01fd
  1. 19
      org.springframework.core/src/main/java/org/springframework/core/LocalVariableTableParameterNameDiscoverer.java

19
org.springframework.core/src/main/java/org/springframework/core/LocalVariableTableParameterNameDiscoverer.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2010 the original author or authors. * Copyright 2002-2013 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -39,12 +39,11 @@ import org.springframework.util.ClassUtils;
/** /**
* Implementation of {@link ParameterNameDiscoverer} that uses the LocalVariableTable * Implementation of {@link ParameterNameDiscoverer} that uses the LocalVariableTable
* information in the method attributes to discover parameter names. Returns * information in the method attributes to discover parameter names. Returns
* <code>null</code> if the class file was compiled without debug information. * {@code null} if the class file was compiled without debug information.
* *
* <p>Uses ObjectWeb's ASM library for analyzing class files. Each discoverer * <p>Uses ObjectWeb's ASM library for analyzing class files. Each discoverer instance
* instance caches the ASM discovered information for each introspected Class, in a * caches the ASM discovered information for each introspected Class, in a thread-safe
* thread-safe manner. It is recommended to reuse discoverer instances * manner. It is recommended to reuse ParameterNameDiscoverer instances as far as possible.
* as far as possible.
* *
* @author Adrian Colyer * @author Adrian Colyer
* @author Costin Leau * @author Costin Leau
@ -64,15 +63,15 @@ public class LocalVariableTableParameterNameDiscoverer implements ParameterNameD
public String[] getParameterNames(Method method) { public String[] getParameterNames(Method method) {
Class<?> declaringClass = method.getDeclaringClass(); Method originalMethod = BridgeMethodResolver.findBridgedMethod(method);
Class<?> declaringClass = originalMethod.getDeclaringClass();
Map<Member, String[]> map = this.parameterNamesCache.get(declaringClass); Map<Member, String[]> map = this.parameterNamesCache.get(declaringClass);
if (map == null) { if (map == null) {
// initialize cache
map = inspectClass(declaringClass); map = inspectClass(declaringClass);
this.parameterNamesCache.put(declaringClass, map); this.parameterNamesCache.put(declaringClass, map);
} }
if (map != NO_DEBUG_INFO_MAP) { if (map != NO_DEBUG_INFO_MAP) {
return map.get(method); return map.get(originalMethod);
} }
return null; return null;
} }
@ -82,14 +81,12 @@ public class LocalVariableTableParameterNameDiscoverer implements ParameterNameD
Class<?> declaringClass = ctor.getDeclaringClass(); Class<?> declaringClass = ctor.getDeclaringClass();
Map<Member, String[]> map = this.parameterNamesCache.get(declaringClass); Map<Member, String[]> map = this.parameterNamesCache.get(declaringClass);
if (map == null) { if (map == null) {
// initialize cache
map = inspectClass(declaringClass); map = inspectClass(declaringClass);
this.parameterNamesCache.put(declaringClass, map); this.parameterNamesCache.put(declaringClass, map);
} }
if (map != NO_DEBUG_INFO_MAP) { if (map != NO_DEBUG_INFO_MAP) {
return map.get(ctor); return map.get(ctor);
} }
return null; return null;
} }

Loading…
Cancel
Save