Browse Source

Remove unnecessary calls to toString()

See gh-29408
pull/29167/head
Kulwant Singh 3 years ago committed by Sam Brannen
parent
commit
19955c5b77
  1. 2
      spring-websocket/src/main/java/org/springframework/web/socket/messaging/SessionDisconnectEvent.java
  2. 4
      spring-websocket/src/test/java/org/springframework/web/socket/adapter/standard/ConvertingEncoderDecoderSupportTests.java
  3. 2
      spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/RestTemplateXhrTransportTests.java

2
spring-websocket/src/main/java/org/springframework/web/socket/messaging/SessionDisconnectEvent.java

@ -89,7 +89,7 @@ public class SessionDisconnectEvent extends AbstractSubProtocolEvent { @@ -89,7 +89,7 @@ public class SessionDisconnectEvent extends AbstractSubProtocolEvent {
@Override
public String toString() {
return "SessionDisconnectEvent[sessionId=" + this.sessionId + ", " + this.status.toString() + "]";
return "SessionDisconnectEvent[sessionId=" + this.sessionId + ", " + this.status + "]";
}
}

4
spring-websocket/src/test/java/org/springframework/web/socket/adapter/standard/ConvertingEncoderDecoderSupportTests.java

@ -244,7 +244,7 @@ public class ConvertingEncoderDecoderSupportTests { @@ -244,7 +244,7 @@ public class ConvertingEncoderDecoderSupportTests {
private static class MyTypeToStringConverter implements Converter<MyType, String> {
@Override
public String convert(MyType source) {
return "_" + source.toString();
return "_" + source;
}
}
@ -252,7 +252,7 @@ public class ConvertingEncoderDecoderSupportTests { @@ -252,7 +252,7 @@ public class ConvertingEncoderDecoderSupportTests {
private static class MyTypeToBytesConverter implements Converter<MyType, byte[]> {
@Override
public byte[] convert(MyType source) {
return ("~" + source.toString()).getBytes();
return ("~" + source).getBytes();
}
}

2
spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/RestTemplateXhrTransportTests.java

@ -91,7 +91,7 @@ public class RestTemplateXhrTransportTests { @@ -91,7 +91,7 @@ public class RestTemplateXhrTransportTests {
for (int i = 0; i < 2048; i++) {
sb.append('h');
}
String body = sb.toString() + "\n" + "o\n" + "a[\"foo\"]\n" + "c[3000,\"Go away!\"]";
String body = sb + "\n" + "o\n" + "a[\"foo\"]\n" + "c[3000,\"Go away!\"]";
ClientHttpResponse response = response(HttpStatus.OK, body);
connect(response);

Loading…
Cancel
Save