@ -259,7 +259,7 @@ public class AspectJExpressionPointcut extends AbstractExpressionPointcut
@@ -259,7 +259,7 @@ public class AspectJExpressionPointcut extends AbstractExpressionPointcut
@ -554,7 +554,7 @@ public class AspectJExpressionPointcut extends AbstractExpressionPointcut
@@ -554,7 +554,7 @@ public class AspectJExpressionPointcut extends AbstractExpressionPointcut
@ -56,39 +56,39 @@ public class AspectJWeaverMessageHandler implements IMessageHandler {
@@ -56,39 +56,39 @@ public class AspectJWeaverMessageHandler implements IMessageHandler {
@ -48,7 +48,7 @@ public class DeclareParentsAdvisor implements IntroductionAdvisor {
@@ -48,7 +48,7 @@ public class DeclareParentsAdvisor implements IntroductionAdvisor {
@ -59,7 +59,7 @@ public class DeclareParentsAdvisor implements IntroductionAdvisor {
@@ -59,7 +59,7 @@ public class DeclareParentsAdvisor implements IntroductionAdvisor {
@ -47,11 +47,11 @@ public class TypePatternClassFilter implements ClassFilter {
@@ -47,11 +47,11 @@ public class TypePatternClassFilter implements ClassFilter {
@ -73,7 +73,7 @@ public class TypePatternClassFilter implements ClassFilter {
@@ -73,7 +73,7 @@ public class TypePatternClassFilter implements ClassFilter {
@ -121,7 +121,7 @@ public abstract class AbstractAspectJAdvisorFactory implements AspectJAdvisorFac
@@ -121,7 +121,7 @@ public abstract class AbstractAspectJAdvisorFactory implements AspectJAdvisorFac
// The AJTypeSystem goes to great lengths to provide a uniform appearance between code-style and
@ -154,11 +154,11 @@ public abstract class AbstractAspectJAdvisorFactory implements AspectJAdvisorFac
@@ -154,11 +154,11 @@ public abstract class AbstractAspectJAdvisorFactory implements AspectJAdvisorFac
@ -169,13 +169,13 @@ public abstract class AbstractAspectJAdvisorFactory implements AspectJAdvisorFac
@@ -169,13 +169,13 @@ public abstract class AbstractAspectJAdvisorFactory implements AspectJAdvisorFac
@ -326,10 +326,10 @@ public abstract class AbstractAspectJAdvisorFactory implements AspectJAdvisorFac
@@ -326,10 +326,10 @@ public abstract class AbstractAspectJAdvisorFactory implements AspectJAdvisorFac
@ -56,7 +56,7 @@ public class BeanFactoryAspectInstanceFactory implements MetadataAwareAspectInst
@@ -56,7 +56,7 @@ public class BeanFactoryAspectInstanceFactory implements MetadataAwareAspectInst
@ -203,7 +203,7 @@ public class ReflectiveAspectJAdvisorFactory extends AbstractAspectJAdvisorFacto
@@ -203,7 +203,7 @@ public class ReflectiveAspectJAdvisorFactory extends AbstractAspectJAdvisorFacto
returnnull;
}
// If we get here, we know we have an AspectJ method.
// If we get here, we know we have an AspectJ method.
// Check that it's an AspectJ-annotated class
if(!isAspect(candidateAspectClass)){
thrownewAopConfigException("Advice must be declared inside an aspect type: "+
@ -72,8 +72,8 @@ public class AspectJAwareAdvisorAutoProxyCreator extends AbstractAdvisorAutoProx
@@ -72,8 +72,8 @@ public class AspectJAwareAdvisorAutoProxyCreator extends AbstractAdvisorAutoProx
@ -81,13 +81,13 @@ public class AspectJAwareAdvisorAutoProxyCreator extends AbstractAdvisorAutoProx
@@ -81,13 +81,13 @@ public class AspectJAwareAdvisorAutoProxyCreator extends AbstractAdvisorAutoProx
// TODO: work harder to give a better error message here.
@ -60,7 +60,7 @@ public abstract class AbstractInterceptorDrivenBeanDefinitionDecorator implement
@@ -60,7 +60,7 @@ public abstract class AbstractInterceptorDrivenBeanDefinitionDecorator implement
@ -100,7 +100,7 @@ public class ProxyFactoryBean extends ProxyCreatorSupport
@@ -100,7 +100,7 @@ public class ProxyFactoryBean extends ProxyCreatorSupport
@ -543,10 +543,10 @@ public class ProxyFactoryBean extends ProxyCreatorSupport
@@ -543,10 +543,10 @@ public class ProxyFactoryBean extends ProxyCreatorSupport
Advisoradvisor=namedBeanToAdvisor(next);
if(logger.isTraceEnabled()){
logger.trace("Adding advisor with name '"+name+"'");
@ -627,24 +627,24 @@ public class ProxyFactoryBean extends ProxyCreatorSupport
@@ -627,24 +627,24 @@ public class ProxyFactoryBean extends ProxyCreatorSupport
@ -94,6 +94,6 @@ public class DefaultAdvisorAutoProxyCreator extends AbstractAdvisorAutoProxyCrea
@@ -94,6 +94,6 @@ public class DefaultAdvisorAutoProxyCreator extends AbstractAdvisorAutoProxyCrea
@ -59,5 +59,5 @@ public class QuickTargetSourceCreator extends AbstractBeanFactoryBasedTargetSour
@@ -59,5 +59,5 @@ public class QuickTargetSourceCreator extends AbstractBeanFactoryBasedTargetSour
@ -46,7 +46,7 @@ public class DefaultPointcutAdvisor extends AbstractGenericPointcutAdvisor imple
@@ -46,7 +46,7 @@ public class DefaultPointcutAdvisor extends AbstractGenericPointcutAdvisor imple
@ -55,7 +55,7 @@ public class DefaultPointcutAdvisor extends AbstractGenericPointcutAdvisor imple
@@ -55,7 +55,7 @@ public class DefaultPointcutAdvisor extends AbstractGenericPointcutAdvisor imple
@ -85,12 +85,12 @@ public class DelegatePerTargetObjectIntroductionInterceptor extends Introduction
@@ -85,12 +85,12 @@ public class DelegatePerTargetObjectIntroductionInterceptor extends Introduction
@ -126,7 +126,7 @@ public class DelegatePerTargetObjectIntroductionInterceptor extends Introduction
@@ -126,7 +126,7 @@ public class DelegatePerTargetObjectIntroductionInterceptor extends Introduction
@ -66,7 +66,7 @@ public class DelegatingIntroductionInterceptor extends IntroductionInfoSupport
@@ -66,7 +66,7 @@ public class DelegatingIntroductionInterceptor extends IntroductionInfoSupport
@ -91,8 +91,8 @@ public class DelegatingIntroductionInterceptor extends IntroductionInfoSupport
@@ -91,8 +91,8 @@ public class DelegatingIntroductionInterceptor extends IntroductionInfoSupport
@ -104,7 +104,7 @@ public class DelegatingIntroductionInterceptor extends IntroductionInfoSupport
@@ -104,7 +104,7 @@ public class DelegatingIntroductionInterceptor extends IntroductionInfoSupport
// get correct handling of InvocationTargetException
@ -90,7 +90,7 @@ public abstract class AbstractPoolingTargetSource extends AbstractPrototypeBased
@@ -90,7 +90,7 @@ public abstract class AbstractPoolingTargetSource extends AbstractPrototypeBased
@ -98,7 +98,7 @@ public abstract class AbstractPoolingTargetSource extends AbstractPrototypeBased
@@ -98,7 +98,7 @@ public abstract class AbstractPoolingTargetSource extends AbstractPrototypeBased
@ -62,9 +62,9 @@ public class ThreadLocalTargetSource extends AbstractPrototypeBasedTargetSource
@@ -62,9 +62,9 @@ public class ThreadLocalTargetSource extends AbstractPrototypeBasedTargetSource
@ -93,7 +93,7 @@ public class ThreadLocalTargetSource extends AbstractPrototypeBasedTargetSource
@@ -93,7 +93,7 @@ public class ThreadLocalTargetSource extends AbstractPrototypeBasedTargetSource
@ -36,7 +36,7 @@ public final class AspectJAdviceParameterNameDiscoverAnnotationTests
@@ -36,7 +36,7 @@ public final class AspectJAdviceParameterNameDiscoverAnnotationTests
@ -247,7 +247,7 @@ public class AspectJAdviceParameterNameDiscovererTests {
@@ -247,7 +247,7 @@ public class AspectJAdviceParameterNameDiscovererTests {
@ -72,31 +72,31 @@ public final class MethodInvocationProceedingJoinPointTests {
@@ -72,31 +72,31 @@ public final class MethodInvocationProceedingJoinPointTests {
// Try reentrant call--will go through this advice.
// Be sure to increment depth to avoid infinite recursion
if(depth++==0){
@ -109,10 +109,10 @@ public final class MethodInvocationProceedingJoinPointTests {
@@ -109,10 +109,10 @@ public final class MethodInvocationProceedingJoinPointTests {
assertSame("Return same MethodSignature repeatedly",msig,AbstractAspectJAdvice.currentJoinPoint().getSignature());
assertSame("Return same JoinPoint repeatedly",AbstractAspectJAdvice.currentJoinPoint(),AbstractAspectJAdvice.currentJoinPoint());
@ -146,7 +146,7 @@ public final class MethodInvocationProceedingJoinPointTests {
@@ -146,7 +146,7 @@ public final class MethodInvocationProceedingJoinPointTests {
catch(UnsupportedOperationExceptionex){
// Expected
}
try{
sloc.getFileName();
fail("Can't get file name");
@ -191,7 +191,7 @@ public final class MethodInvocationProceedingJoinPointTests {
@@ -191,7 +191,7 @@ public final class MethodInvocationProceedingJoinPointTests {
@ -38,37 +38,37 @@ public final class TigerAspectJAdviceParameterNameDiscovererTests
@@ -38,37 +38,37 @@ public final class TigerAspectJAdviceParameterNameDiscovererTests
@ -54,10 +54,10 @@ public final class TigerAspectJExpressionPointcutTests {
@@ -54,10 +54,10 @@ public final class TigerAspectJExpressionPointcutTests {
methodsOnHasGeneric.put(m.getName(),m);
}
}
publicstaticclassHasGeneric{
publicvoidsetFriends(List<TestBean>friends){
}
publicvoidsetEnemies(List<TestBean>enemies){
@ -73,20 +73,20 @@ public final class TigerAspectJExpressionPointcutTests {
@@ -73,20 +73,20 @@ public final class TigerAspectJExpressionPointcutTests {
@ -94,20 +94,20 @@ public final class TigerAspectJExpressionPointcutTests {
@@ -94,20 +94,20 @@ public final class TigerAspectJExpressionPointcutTests {
@ -115,44 +115,44 @@ public final class TigerAspectJExpressionPointcutTests {
@@ -115,44 +115,44 @@ public final class TigerAspectJExpressionPointcutTests {
@ -160,13 +160,13 @@ public final class TigerAspectJExpressionPointcutTests {
@@ -160,13 +160,13 @@ public final class TigerAspectJExpressionPointcutTests {
@ -174,13 +174,13 @@ public final class TigerAspectJExpressionPointcutTests {
@@ -174,13 +174,13 @@ public final class TigerAspectJExpressionPointcutTests {
@ -194,43 +194,43 @@ public final class TigerAspectJExpressionPointcutTests {
@@ -194,43 +194,43 @@ public final class TigerAspectJExpressionPointcutTests {
@ -267,7 +267,7 @@ public final class TigerAspectJExpressionPointcutTests {
@@ -267,7 +267,7 @@ public final class TigerAspectJExpressionPointcutTests {
}
}
staticclassBeanA{
privateStringname;
@ -283,7 +283,7 @@ public final class TigerAspectJExpressionPointcutTests {
@@ -283,7 +283,7 @@ public final class TigerAspectJExpressionPointcutTests {
@ -76,7 +76,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -76,7 +76,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@ -88,7 +88,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -88,7 +88,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@ -105,11 +105,11 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -105,11 +105,11 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@ -121,10 +121,10 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -121,10 +121,10 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
// Hit the method in the per clause to instantiate the aspect
itb.getSpouse();
assertTrue(maaif.isMaterialized());
assertEquals("Around advice must apply",0,itb.getAge());
@ -190,11 +190,11 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -190,11 +190,11 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
assertEquals("Around advice must NOT apply",realAge,itb.getAge());
Advisedadvised=(Advised)itb;
// Will be ExposeInvocationInterceptor, synthetic instantiation advisor, 2 method advisors
assertEquals(4,advised.getAdvisors().length);
@ -208,30 +208,30 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -208,30 +208,30 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
assertEquals("Around advice must now apply",0,itb.getAge());
Advisedadvised=(Advised)itb;
// Will be ExposeInvocationInterceptor, synthetic instantiation advisor, 2 method advisors
assertEquals(4,advised.getAdvisors().length);
@ -245,19 +245,19 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -245,19 +245,19 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
assertEquals("Around advice must still apply",1,itb.getAge());
assertEquals("Around advice must still apply",2,itb.getAge());
TestBeanitb2=(TestBean)createProxy(target,
getFixture().getAdvisors(aif),
TestBeanitb2=(TestBean)createProxy(target,
getFixture().getAdvisors(aif),
TestBean.class);
assertEquals(1,aif.getInstantiationCount());
assertEquals("Around advice be independent for second instance",0,itb2.getAge());
@ -282,20 +282,20 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -282,20 +282,20 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
assertEquals("Around advice must apply",-1,itb.getAge());
assertEquals(realAge,target.getAge());
@ -304,8 +304,8 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -304,8 +304,8 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
assertEquals("Around advice must apply",20,itb.getAge());
@ -315,10 +315,10 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -315,10 +315,10 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@ -327,7 +327,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -327,7 +327,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@ -344,7 +344,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -344,7 +344,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@ -363,17 +363,17 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -363,17 +363,17 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@ -398,7 +398,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -398,7 +398,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@ -415,7 +415,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -415,7 +415,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@ -430,19 +430,19 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -430,19 +430,19 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
// TODO: Why does this test fail? It hasn't been run before, so it maybe never actually passed...
@ -454,7 +454,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -454,7 +454,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
assertFalse("Setting same value does not modify",modifiable.isModified());
itb.setName("And now for something completely different");
assertTrue(modifiable.isModified());
lockable.lock();
assertTrue(lockable.locked());
try{
@ -474,8 +474,8 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -474,8 +474,8 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
assertEquals("One advice method was found",1,advisors.size());
ITestBeanitb=(ITestBean)createProxy(target,
advisors,
ITestBeanitb=(ITestBean)createProxy(target,
advisors,
ITestBean.class);
try{
itb.getAge();
@ -485,7 +485,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -485,7 +485,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
assertSame(expectedException,ex);
}
}
// TODO document this behaviour.
// Is it different AspectJ behaviour, at least for checked exceptions?
@Test
@ -494,8 +494,8 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -494,8 +494,8 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
assertEquals("One advice method was found",1,advisors.size());
ITestBeanitb=(ITestBean)createProxy(target,
advisors,
ITestBeanitb=(ITestBean)createProxy(target,
advisors,
ITestBean.class);
try{
itb.getAge();
@ -505,7 +505,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -505,7 +505,7 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@ -533,8 +533,8 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -533,8 +533,8 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@ -549,8 +549,8 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -549,8 +549,8 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@ -886,45 +886,45 @@ public abstract class AbstractAspectJAdvisorFactoryTests {
@@ -886,45 +886,45 @@ public abstract class AbstractAspectJAdvisorFactoryTests {