Browse Source

Polish contribution

See gh-24595
pull/24717/head
Sam Brannen 6 years ago
parent
commit
17140c8d4b
  1. 7
      spring-web/src/main/java/org/springframework/web/client/DefaultResponseErrorHandler.java
  2. 5
      spring-web/src/test/java/org/springframework/web/client/DefaultResponseErrorHandlerTests.java

7
spring-web/src/main/java/org/springframework/web/client/DefaultResponseErrorHandler.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2002-2019 the original author or authors.
* Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -103,9 +103,8 @@ public class DefaultResponseErrorHandler implements ResponseErrorHandler { @@ -103,9 +103,8 @@ public class DefaultResponseErrorHandler implements ResponseErrorHandler {
HttpStatus statusCode = HttpStatus.resolve(response.getRawStatusCode());
if (statusCode == null) {
byte[] body = getResponseBody(response);
String message = getErrorMessage(
response.getRawStatusCode(), response.getStatusText(),
body, getCharset(response));
String message = getErrorMessage(response.getRawStatusCode(),
response.getStatusText(), body, getCharset(response));
throw new UnknownHttpStatusCodeException(message,
response.getRawStatusCode(), response.getStatusText(),
response.getHeaders(), body, getCharset(response));

5
spring-web/src/test/java/org/springframework/web/client/DefaultResponseErrorHandlerTests.java

@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/*
* Copyright 2002-2019 the original author or authors.
* Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -183,6 +183,7 @@ public class DefaultResponseErrorHandlerTests { @@ -183,6 +183,7 @@ public class DefaultResponseErrorHandlerTests {
assertThat(actualUnknownHttpStatusCodeException.getRawStatusCode()).isEqualTo(statusCode);
assertThat(actualUnknownHttpStatusCodeException.getStatusText()).isEqualTo(statusText);
assertThat(actualUnknownHttpStatusCodeException.getResponseHeaders()).isEqualTo(headers);
assertThat(actualUnknownHttpStatusCodeException.getMessage()).contains(responseBody);
assertThat(actualUnknownHttpStatusCodeException.getResponseBodyAsString()).isEqualTo(responseBody);
}
@ -222,6 +223,7 @@ public class DefaultResponseErrorHandlerTests { @@ -222,6 +223,7 @@ public class DefaultResponseErrorHandlerTests {
assertThat(actualUnknownHttpStatusCodeException.getRawStatusCode()).isEqualTo(statusCode);
assertThat(actualUnknownHttpStatusCodeException.getStatusText()).isEqualTo(statusText);
assertThat(actualUnknownHttpStatusCodeException.getResponseHeaders()).isEqualTo(headers);
assertThat(actualUnknownHttpStatusCodeException.getMessage()).contains(responseBody);
assertThat(actualUnknownHttpStatusCodeException.getResponseBodyAsString()).isEqualTo(responseBody);
}
@ -241,6 +243,7 @@ public class DefaultResponseErrorHandlerTests { @@ -241,6 +243,7 @@ public class DefaultResponseErrorHandlerTests {
assertThat(StreamUtils.copyToString(response.getBody(), StandardCharsets.UTF_8)).isEqualTo("Hello World");
}
private static class TestByteArrayInputStream extends ByteArrayInputStream {
private boolean closed;

Loading…
Cancel
Save