From 0fb0335aa041f959cc87122f83d5b2e9f1bd64d4 Mon Sep 17 00:00:00 2001 From: izeye Date: Mon, 16 May 2022 08:40:53 +0900 Subject: [PATCH] Add level guards for trace logging in SpringFactoriesLoaderRuntimeHintsRegistrar Closes gh-28465 --- ...SpringFactoriesLoaderRuntimeHintsRegistrar.java | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/spring-core/src/main/java/org/springframework/core/io/support/SpringFactoriesLoaderRuntimeHintsRegistrar.java b/spring-core/src/main/java/org/springframework/core/io/support/SpringFactoriesLoaderRuntimeHintsRegistrar.java index 05a9088059f..185d465cae2 100644 --- a/spring-core/src/main/java/org/springframework/core/io/support/SpringFactoriesLoaderRuntimeHintsRegistrar.java +++ b/spring-core/src/main/java/org/springframework/core/io/support/SpringFactoriesLoaderRuntimeHintsRegistrar.java @@ -70,15 +70,21 @@ class SpringFactoriesLoaderRuntimeHintsRegistrar implements RuntimeHintsRegistra String factoryClassName, List implementationClassNames) { Class factoryClass = resolveClassName(classLoader, factoryClassName); if(factoryClass == null) { - logger.trace(LogMessage.format("Skipping factories for [%s]", factoryClassName)); + if (logger.isTraceEnabled()) { + logger.trace(LogMessage.format("Skipping factories for [%s]", factoryClassName)); + } return; } - logger.trace(LogMessage.format("Processing factories for [%s]", factoryClassName)); + if (logger.isTraceEnabled()) { + logger.trace(LogMessage.format("Processing factories for [%s]", factoryClassName)); + } hints.reflection().registerType(factoryClass, HINT); for (String implementationClassName : implementationClassNames) { Class implementationType = resolveClassName(classLoader, implementationClassName); - logger.trace(LogMessage.format("%s factory type [%s] and implementation [%s]", - (implementationType != null) ? "Processing" : "Skipping", factoryClassName, implementationClassName)); + if (logger.isTraceEnabled()) { + logger.trace(LogMessage.format("%s factory type [%s] and implementation [%s]", + (implementationType != null) ? "Processing" : "Skipping", factoryClassName, implementationClassName)); + } if (implementationType != null) { hints.reflection().registerType(implementationType, HINT); }