Browse Source

Reduce access on user in SimpleBrokerMessageHandler.handleMessageInternal

Issue: SPR-16264
pull/1610/merge
Juergen Hoeller 8 years ago
parent
commit
0b77c8835c
  1. 3
      spring-messaging/src/main/java/org/springframework/messaging/simp/broker/SimpleBrokerMessageHandler.java

3
spring-messaging/src/main/java/org/springframework/messaging/simp/broker/SimpleBrokerMessageHandler.java

@ -251,7 +251,6 @@ public class SimpleBrokerMessageHandler extends AbstractBrokerMessageHandler { @@ -251,7 +251,6 @@ public class SimpleBrokerMessageHandler extends AbstractBrokerMessageHandler {
SimpMessageType messageType = SimpMessageHeaderAccessor.getMessageType(headers);
String destination = SimpMessageHeaderAccessor.getDestination(headers);
String sessionId = SimpMessageHeaderAccessor.getSessionId(headers);
Principal user = SimpMessageHeaderAccessor.getUser(headers);
updateSessionReadTime(sessionId);
@ -267,6 +266,7 @@ public class SimpleBrokerMessageHandler extends AbstractBrokerMessageHandler { @@ -267,6 +266,7 @@ public class SimpleBrokerMessageHandler extends AbstractBrokerMessageHandler {
logMessage(message);
long[] clientHeartbeat = SimpMessageHeaderAccessor.getHeartbeat(headers);
long[] serverHeartbeat = getHeartbeatValue();
Principal user = SimpMessageHeaderAccessor.getUser(headers);
this.sessions.put(sessionId, new SessionInfo(sessionId, user, clientHeartbeat, serverHeartbeat));
SimpMessageHeaderAccessor connectAck = SimpMessageHeaderAccessor.create(SimpMessageType.CONNECT_ACK);
initHeaders(connectAck);
@ -279,6 +279,7 @@ public class SimpleBrokerMessageHandler extends AbstractBrokerMessageHandler { @@ -279,6 +279,7 @@ public class SimpleBrokerMessageHandler extends AbstractBrokerMessageHandler {
}
else if (SimpMessageType.DISCONNECT.equals(messageType)) {
logMessage(message);
Principal user = SimpMessageHeaderAccessor.getUser(headers);
handleDisconnect(sessionId, user, message);
}
else if (SimpMessageType.SUBSCRIBE.equals(messageType)) {

Loading…
Cancel
Save