From 08afe5d22b230252df62ab8c27a4d9b3d2e6d236 Mon Sep 17 00:00:00 2001 From: Sam Brannen Date: Fri, 7 Jun 2019 19:45:51 +0300 Subject: [PATCH] Polishing --- .../expression/spel/support/StandardTypeComparator.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spring-expression/src/main/java/org/springframework/expression/spel/support/StandardTypeComparator.java b/spring-expression/src/main/java/org/springframework/expression/spel/support/StandardTypeComparator.java index e2e6d11c7f9..a94509b020a 100644 --- a/spring-expression/src/main/java/org/springframework/expression/spel/support/StandardTypeComparator.java +++ b/spring-expression/src/main/java/org/springframework/expression/spel/support/StandardTypeComparator.java @@ -27,7 +27,7 @@ import org.springframework.util.NumberUtils; /** * A simple basic {@link TypeComparator} implementation. - * It supports comparison of Numbers and types implementing Comparable. + *

It supports comparison of Numbers and types implementing Comparable. * * @author Andy Clement * @author Juergen Hoeller @@ -89,10 +89,10 @@ public class StandardTypeComparator implements TypeComparator { return Integer.compare(leftNumber.intValue(), rightNumber.intValue()); } else if (leftNumber instanceof Short || rightNumber instanceof Short) { - return leftNumber.shortValue() - rightNumber.shortValue(); + return Short.compare(leftNumber.shortValue(), rightNumber.shortValue()); } else if (leftNumber instanceof Byte || rightNumber instanceof Byte) { - return leftNumber.byteValue() - rightNumber.byteValue(); + return Byte.compare(leftNumber.byteValue(), rightNumber.byteValue()); } else { // Unknown Number subtypes -> best guess is double multiplication