Browse Source

DATAJDBC-162 - Prevent NPE for missing PropertyPath in DbActionExecutionException.

pull/30/head
Jens Schauder 8 years ago
parent
commit
fe00e928a5
  1. 4
      src/main/java/org/springframework/data/jdbc/core/conversion/DbActionExecutionException.java
  2. 34
      src/test/java/org/springframework/data/jdbc/core/conversion/DbActionExecutionExceptionTest.java

4
src/main/java/org/springframework/data/jdbc/core/conversion/DbActionExecutionException.java

@ -1,5 +1,5 @@
/* /*
* Copyright 2017 the original author or authors. * Copyright 2018 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -28,7 +28,7 @@ public class DbActionExecutionException extends RuntimeException {
action.getClass().getSimpleName(), // action.getClass().getSimpleName(), //
action.getEntity(), // action.getEntity(), //
action.getEntityType(), // action.getEntityType(), //
action.getPropertyPath().toDotPath() // action.getPropertyPath() == null ? "" : action.getPropertyPath().toDotPath() //
), // ), //
cause); cause);
} }

34
src/test/java/org/springframework/data/jdbc/core/conversion/DbActionExecutionExceptionTest.java

@ -0,0 +1,34 @@
/*
* Copyright 2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.data.jdbc.core.conversion;
import static org.mockito.Mockito.*;
import org.junit.Test;
/**
* @author Jens Schauder
*/
public class DbActionExecutionExceptionTest {
@Test // DATAJDBC-162
public void constructorWorksWithNullPropertyPath() {
DbAction<?> action = mock(DbAction.class);
new DbActionExecutionException(action, null);
}
}
Loading…
Cancel
Save