Browse Source

DATAJDBC-113 - Polishing.

Applied changes from review.
Removed superfluous @ConstructorProperties annotations.
Fixed formatting.
Improved usage of generics.
pull/16/merge
Jens Schauder 8 years ago committed by Greg Turnquist
parent
commit
fd2ae05795
No known key found for this signature in database
GPG Key ID: CB2FA4D512B5C413
  1. 2
      src/main/java/org/springframework/data/jdbc/core/EntityRowMapper.java
  2. 13
      src/main/java/org/springframework/data/jdbc/core/conversion/JdbcEntityWriter.java
  3. 4
      src/main/java/org/springframework/data/jdbc/support/JdbcUtil.java
  4. 2
      src/test/java/org/springframework/data/jdbc/core/EntityRowMapperUnitTests.java

2
src/main/java/org/springframework/data/jdbc/core/EntityRowMapper.java

@ -51,7 +51,6 @@ class EntityRowMapper<T> implements RowMapper<T> {
private final JdbcEntityOperations template; private final JdbcEntityOperations template;
private final JdbcPersistentProperty idProperty; private final JdbcPersistentProperty idProperty;
@java.beans.ConstructorProperties({ "entity", "conversions", "context", "template" })
public EntityRowMapper(JdbcPersistentEntity<T> entity, ConversionService conversions, JdbcMappingContext context, public EntityRowMapper(JdbcPersistentEntity<T> entity, ConversionService conversions, JdbcMappingContext context,
JdbcEntityOperations template) { JdbcEntityOperations template) {
@ -137,7 +136,6 @@ class EntityRowMapper<T> implements RowMapper<T> {
@NonNull private final ConversionService conversionService; @NonNull private final ConversionService conversionService;
@NonNull private final String prefix; @NonNull private final String prefix;
@java.beans.ConstructorProperties({ "resultSet", "conversionService", "prefix" })
private ResultSetParameterValueProvider(ResultSet resultSet, ConversionService conversionService, String prefix) { private ResultSetParameterValueProvider(ResultSet resultSet, ConversionService conversionService, String prefix) {
this.resultSet = resultSet; this.resultSet = resultSet;

13
src/main/java/org/springframework/data/jdbc/core/conversion/JdbcEntityWriter.java

@ -126,21 +126,20 @@ public class JdbcEntityWriter extends JdbcEntityWriterSupport {
} }
Class<?> type = p.getType(); Class<?> type = p.getType();
if (Collection.class.isAssignableFrom(type))
return collectionPropertyAsStream(p, propertyAccessor);
return singlePropertyAsStream(p, propertyAccessor); return Collection.class.isAssignableFrom(type) //
? collectionPropertyAsStream(p, propertyAccessor) //
: singlePropertyAsStream(p, propertyAccessor);
} }
private Stream<Object> collectionPropertyAsStream(JdbcPersistentProperty p, private Stream<Object> collectionPropertyAsStream(JdbcPersistentProperty p,
PersistentPropertyAccessor propertyAccessor) { PersistentPropertyAccessor propertyAccessor) {
Object property = propertyAccessor.getProperty(p); Object property = propertyAccessor.getProperty(p);
if (property == null) {
return Stream.empty();
}
return ((Collection<Object>) property).stream(); return property == null //
? Stream.empty() //
: ((Collection<Object>) property).stream();
} }
private Stream<Object> singlePropertyAsStream(JdbcPersistentProperty p, PersistentPropertyAccessor propertyAccessor) { private Stream<Object> singlePropertyAsStream(JdbcPersistentProperty p, PersistentPropertyAccessor propertyAccessor) {

4
src/main/java/org/springframework/data/jdbc/support/JdbcUtil.java

@ -36,7 +36,7 @@ import org.springframework.jdbc.support.JdbcUtils;
@UtilityClass @UtilityClass
public class JdbcUtil { public class JdbcUtil {
private static final Map<Class, Integer> sqlTypeMappings = new HashMap<>(); private static final Map<Class<?>, Integer> sqlTypeMappings = new HashMap<>();
static { static {
@ -63,7 +63,7 @@ public class JdbcUtil {
sqlTypeMappings.put(Timestamp.class, Types.TIMESTAMP); sqlTypeMappings.put(Timestamp.class, Types.TIMESTAMP);
} }
public static int sqlTypeFor(Class type) { public static int sqlTypeFor(Class<?> type) {
return sqlTypeMappings.keySet().stream() // return sqlTypeMappings.keySet().stream() //
.filter(k -> k.isAssignableFrom(type)) // .filter(k -> k.isAssignableFrom(type)) //
.findFirst() // .findFirst() //

2
src/test/java/org/springframework/data/jdbc/core/EntityRowMapperUnitTests.java

@ -19,7 +19,6 @@ import static java.util.Arrays.*;
import static org.assertj.core.api.Assertions.*; import static org.assertj.core.api.Assertions.*;
import static org.mockito.Mockito.*; import static org.mockito.Mockito.*;
import lombok.Data;
import lombok.RequiredArgsConstructor; import lombok.RequiredArgsConstructor;
import java.sql.ResultSet; import java.sql.ResultSet;
@ -191,7 +190,6 @@ public class EntityRowMapperUnitTests {
} }
private Object getObject(String column) { private Object getObject(String column) {
return values.get(index).get(column); return values.get(index).get(column);
} }

Loading…
Cancel
Save