From f94e1939ed6d85475fd08a3e4258ee13c979460e Mon Sep 17 00:00:00 2001 From: Tran Ngoc Nhan Date: Sat, 21 Sep 2024 10:44:46 +0700 Subject: [PATCH] Polishing. Original pull request #1894 --- .../jdbc/repository/support/SimpleJdbcRepositoryUnitTests.java | 2 +- .../org/springframework/data/r2dbc/dialect/OracleDialect.java | 2 +- .../springframework/data/r2dbc/dialect/SqlServerDialect.java | 2 +- .../data/relational/core/dialect/AbstractDialect.java | 2 +- .../data/relational/core/sql/render/InVisitor.java | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/support/SimpleJdbcRepositoryUnitTests.java b/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/support/SimpleJdbcRepositoryUnitTests.java index d551c856d..f3219cf67 100644 --- a/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/support/SimpleJdbcRepositoryUnitTests.java +++ b/spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/support/SimpleJdbcRepositoryUnitTests.java @@ -42,7 +42,7 @@ public class SimpleJdbcRepositoryUnitTests { @Test // DATAJDBC-252 public void saveReturnsEntityProducedByOperations() { - SimpleJdbcRepository repository = new SimpleJdbcRepository<>(operations, entity,converter); + SimpleJdbcRepository repository = new SimpleJdbcRepository<>(operations, entity, converter); Sample expected = new Sample(); doReturn(expected).when(operations).save(any()); diff --git a/spring-data-r2dbc/src/main/java/org/springframework/data/r2dbc/dialect/OracleDialect.java b/spring-data-r2dbc/src/main/java/org/springframework/data/r2dbc/dialect/OracleDialect.java index 1a9b248f2..3a4011305 100644 --- a/spring-data-r2dbc/src/main/java/org/springframework/data/r2dbc/dialect/OracleDialect.java +++ b/spring-data-r2dbc/src/main/java/org/springframework/data/r2dbc/dialect/OracleDialect.java @@ -53,7 +53,7 @@ public class OracleDialect extends org.springframework.data.relational.core.dial } } - if (builder.length() == 0) { + if (builder.isEmpty()) { return ""; } diff --git a/spring-data-r2dbc/src/main/java/org/springframework/data/r2dbc/dialect/SqlServerDialect.java b/spring-data-r2dbc/src/main/java/org/springframework/data/r2dbc/dialect/SqlServerDialect.java index 9ab9eb13e..d2d5d8389 100644 --- a/spring-data-r2dbc/src/main/java/org/springframework/data/r2dbc/dialect/SqlServerDialect.java +++ b/spring-data-r2dbc/src/main/java/org/springframework/data/r2dbc/dialect/SqlServerDialect.java @@ -50,7 +50,7 @@ public class SqlServerDialect extends org.springframework.data.relational.core.d } } - if (builder.length() == 0) { + if (builder.isEmpty()) { return ""; } diff --git a/spring-data-relational/src/main/java/org/springframework/data/relational/core/dialect/AbstractDialect.java b/spring-data-relational/src/main/java/org/springframework/data/relational/core/dialect/AbstractDialect.java index 62686ceb0..516a29899 100644 --- a/spring-data-relational/src/main/java/org/springframework/data/relational/core/dialect/AbstractDialect.java +++ b/spring-data-relational/src/main/java/org/springframework/data/relational/core/dialect/AbstractDialect.java @@ -196,7 +196,7 @@ public abstract class AbstractDialect implements Dialect { @Override public CharSequence apply(CharSequence charSequence) { - if (charSequence.length() == 0) { + if (charSequence.isEmpty()) { return charSequence; } diff --git a/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/render/InVisitor.java b/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/render/InVisitor.java index 107ec92e6..249e71893 100644 --- a/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/render/InVisitor.java +++ b/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/render/InVisitor.java @@ -47,7 +47,7 @@ class InVisitor extends TypedSingleConditionRenderSupport { part.append(", "); } - if (part.length() == 0) { + if (part.isEmpty()) { part.append(renderedPart); if (notIn) { part.append(" NOT");