Browse Source

DATAJDBC-522 - Polishing.

Removed e-mail from author tag.
Removed spaces from references to methods in KDoc.
Removed superfluous comment.
Corrected copyright date.

Original pull request: #240.
pull/252/head
Jens Schauder 5 years ago
parent
commit
d5fdbd1581
No known key found for this signature in database
GPG Key ID: 996B1389BA0721C3
  1. 1
      spring-data-relational/pom.xml
  2. 19
      spring-data-relational/src/main/kotlin/org/springframework/data/relational/core/query/CriteriaStepExtensions.kt
  3. 6
      spring-data-relational/src/test/kotlin/org/springframework/data/relational/core/query/CriteriaStepExtensionsTests.kt

1
spring-data-relational/pom.xml

@ -71,7 +71,6 @@
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<!-- DATAJDBC-522: Add Kotlin extensions for Criteria -->
<dependency> <dependency>
<groupId>org.jetbrains.kotlin</groupId> <groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-stdlib</artifactId> <artifactId>kotlin-stdlib</artifactId>

19
spring-data-relational/src/main/kotlin/org/springframework/data/relational/core/query/CriteriaStepExtensions.kt

@ -1,5 +1,5 @@
/* /*
* Copyright 2019-2020 the original author or authors. * Copyright 2020 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,28 +16,31 @@
package org.springframework.data.relational.core.query package org.springframework.data.relational.core.query
/** /**
* Extension for [Criteria.CriteriaStep. is] providing a * Extension for [Criteria.CriteriaStep.is] providing a
* `isEquals(value)` variant. * `isEquals(value)` variant.
* *
* @author Juan Medina<jamedina@gmail.com> * @author Juan Medina
* @since 2.1
*/ */
infix fun Criteria.CriteriaStep.isEquals(value: Any): Criteria = infix fun Criteria.CriteriaStep.isEqual(value: Any): Criteria =
`is`(value) `is`(value)
/** /**
* Extension for [Criteria.CriteriaStep. in] providing a * Extension for [Criteria.CriteriaStep.in] providing a
* `isIn(value)` variant. * `isIn(value)` variant.
* *
* @author Juan Medina<jamedina@gmail.com> * @author Juan Medina
* @since 2.1
*/ */
fun Criteria.CriteriaStep.isIn(vararg value: Any): Criteria = fun Criteria.CriteriaStep.isIn(vararg value: Any): Criteria =
`in`(value) `in`(value)
/** /**
* Extension for [Criteria.CriteriaStep. in] providing a * Extension for [Criteria.CriteriaStep.in] providing a
* `isIn(value)` variant. * `isIn(value)` variant.
* *
* @author Juan Medina<jamedina@gmail.com> * @author Juan Medina
* @since 2.1
*/ */
fun Criteria.CriteriaStep.isIn(values: Collection<Any>): Criteria = fun Criteria.CriteriaStep.isIn(values: Collection<Any>): Criteria =
`in`(values) `in`(values)

6
spring-data-relational/src/test/kotlin/org/springframework/data/relational/core/query/CriteriaStepExtensionsTests.kt

@ -1,5 +1,5 @@
/* /*
* Copyright 2019 the original author or authors. * Copyright 2020 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -24,7 +24,7 @@ import org.junit.Test
/** /**
* Unit tests for [Criteria.CriteriaStep] extensions. * Unit tests for [Criteria.CriteriaStep] extensions.
* *
* @author Juan Medina<jamedina@gmail.com> * @author Juan Medina
*/ */
class CriteriaStepExtensionsTests { class CriteriaStepExtensionsTests {
@ -36,7 +36,7 @@ class CriteriaStepExtensionsTests {
every { spec.`is`("test") } returns criteria every { spec.`is`("test") } returns criteria
assertThat(spec isEquals "test").isEqualTo(criteria) assertThat(spec isEqual "test").isEqualTo(criteria)
verify { verify {
spec.`is`("test") spec.`is`("test")

Loading…
Cancel
Save