Browse Source

DATAJDBC-569 - Removes unused TestDatabaseFeatures.

Original pull request: #236.
pull/240/head
Jens Schauder 6 years ago committed by Mark Paluch
parent
commit
c6c31dea48
No known key found for this signature in database
GPG Key ID: 51A00FA751B91849
  1. 1
      spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/JdbcRepositoryIntegrationTests.java
  2. 16
      spring-data-jdbc/src/test/java/org/springframework/data/jdbc/testing/TestDatabaseFeatures.java

1
spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/JdbcRepositoryIntegrationTests.java

@ -259,7 +259,6 @@ public class JdbcRepositoryIntegrationTests { @@ -259,7 +259,6 @@ public class JdbcRepositoryIntegrationTests {
}
@Test // DATAJDBC-464, DATAJDBC-318
@EnabledOnFeature(SUPPORTS_DATE_DATATYPES)
public void executeQueryWithParameterRequiringConversion() {
Instant now = Instant.now();

16
spring-data-jdbc/src/test/java/org/springframework/data/jdbc/testing/TestDatabaseFeatures.java

@ -42,14 +42,6 @@ public class TestDatabaseFeatures { @@ -42,14 +42,6 @@ public class TestDatabaseFeatures {
database = Arrays.stream(Database.values()).filter(db -> db.matches(productName)).findFirst().get();
}
/**
* Oracle returns an oracle.sql.TIMESTAMP which currently cannot be converted to an Instant. See DATAJDBC-569 for
* reference.
*/
private void supportsDateDataTypes() {
assumeThat(database).isNotEqualTo(Database.Oracle);
}
/**
* Not all databases support really huge numbers as represented by {@link java.math.BigDecimal} and similar.
*/
@ -57,13 +49,6 @@ public class TestDatabaseFeatures { @@ -57,13 +49,6 @@ public class TestDatabaseFeatures {
assumeThat(database).isNotIn(Database.Oracle, Database.SqlServer);
}
/**
* Oracle does not allow to specify an alias for a joined table with {@code AS}. See DATAJDBC-570 for reference.
*/
private void supportsAsForJoinAlias() {
assumeThat(database).isNotEqualTo(Database.Oracle);
}
/**
* Oracles JDBC driver seems to have a bug that makes it impossible to acquire generated keys when the column is
* quoted. See
@ -119,7 +104,6 @@ public class TestDatabaseFeatures { @@ -119,7 +104,6 @@ public class TestDatabaseFeatures {
public enum Feature {
SUPPORTS_DATE_DATATYPES(TestDatabaseFeatures::supportsDateDataTypes), //
SUPPORTS_MULTIDIMENSIONAL_ARRAYS(TestDatabaseFeatures::supportsMultiDimensionalArrays), //
SUPPORTS_QUOTED_IDS(TestDatabaseFeatures::supportsQuotedIds), //
SUPPORTS_HUGE_NUMBERS(TestDatabaseFeatures::supportsHugeNumbers), //

Loading…
Cancel
Save