Browse Source

DATAJDBC-166 - Polishing.

Formatting.
Import order.
Use of AssertJ.
pull/33/merge
Jens Schauder 8 years ago committed by Greg Turnquist
parent
commit
964f319ae6
No known key found for this signature in database
GPG Key ID: CB2FA4D512B5C413
  1. 19
      src/main/java/org/springframework/data/jdbc/core/DefaultDataAccessStrategy.java
  2. 22
      src/main/java/org/springframework/data/jdbc/core/EntityRowMapper.java
  3. 4
      src/test/java/org/springframework/data/jdbc/repository/config/EnableJdbcRepositoriesIntegrationTests.java

19
src/main/java/org/springframework/data/jdbc/core/DefaultDataAccessStrategy.java

@ -15,6 +15,12 @@ @@ -15,6 +15,12 @@
*/
package org.springframework.data.jdbc.core;
import java.util.HashMap;
import java.util.Map;
import java.util.Optional;
import java.util.stream.Collectors;
import java.util.stream.StreamSupport;
import org.springframework.dao.EmptyResultDataAccessException;
import org.springframework.dao.InvalidDataAccessApiUsageException;
import org.springframework.dao.NonTransientDataAccessException;
@ -34,12 +40,6 @@ import org.springframework.jdbc.support.GeneratedKeyHolder; @@ -34,12 +40,6 @@ import org.springframework.jdbc.support.GeneratedKeyHolder;
import org.springframework.jdbc.support.KeyHolder;
import org.springframework.util.Assert;
import java.util.HashMap;
import java.util.Map;
import java.util.Optional;
import java.util.stream.Collectors;
import java.util.stream.StreamSupport;
/**
* The default {@link DataAccessStrategy} is to generate SQL statements based on meta data from the entity.
*
@ -57,7 +57,7 @@ public class DefaultDataAccessStrategy implements DataAccessStrategy { @@ -57,7 +57,7 @@ public class DefaultDataAccessStrategy implements DataAccessStrategy {
private final DataAccessStrategy accessStrategy;
public DefaultDataAccessStrategy(SqlGeneratorSource sqlGeneratorSource, NamedParameterJdbcOperations operations,
JdbcMappingContext context, DataAccessStrategy accessStrategy) {
JdbcMappingContext context, DataAccessStrategy accessStrategy) {
this.sqlGeneratorSource = sqlGeneratorSource;
this.operations = operations;
@ -70,7 +70,7 @@ public class DefaultDataAccessStrategy implements DataAccessStrategy { @@ -70,7 +70,7 @@ public class DefaultDataAccessStrategy implements DataAccessStrategy {
* Only suitable if this is the only access strategy in use.
*/
public DefaultDataAccessStrategy(SqlGeneratorSource sqlGeneratorSource, NamedParameterJdbcOperations operations,
JdbcMappingContext context) {
JdbcMappingContext context) {
this.sqlGeneratorSource = sqlGeneratorSource;
this.operations = operations;
@ -236,7 +236,8 @@ public class DefaultDataAccessStrategy implements DataAccessStrategy { @@ -236,7 +236,8 @@ public class DefaultDataAccessStrategy implements DataAccessStrategy {
@SuppressWarnings("unchecked")
private <S, ID> ID getIdValueOrNull(S instance, JdbcPersistentEntity<S> persistentEntity) {
EntityInformation<S, ID> entityInformation = (EntityInformation<S, ID>) context.getRequiredPersistentEntityInformation(persistentEntity.getType());
EntityInformation<S, ID> entityInformation = (EntityInformation<S, ID>) context
.getRequiredPersistentEntityInformation(persistentEntity.getType());
ID idValue = entityInformation.getId(instance);

22
src/main/java/org/springframework/data/jdbc/core/EntityRowMapper.java

@ -17,6 +17,10 @@ package org.springframework.data.jdbc.core; @@ -17,6 +17,10 @@ package org.springframework.data.jdbc.core;
import lombok.NonNull;
import lombok.RequiredArgsConstructor;
import java.sql.ResultSet;
import java.sql.SQLException;
import org.springframework.core.convert.ConversionService;
import org.springframework.core.convert.converter.Converter;
import org.springframework.data.convert.ClassGeneratingEntityInstantiator;
@ -32,9 +36,6 @@ import org.springframework.data.mapping.model.ConvertingPropertyAccessor; @@ -32,9 +36,6 @@ import org.springframework.data.mapping.model.ConvertingPropertyAccessor;
import org.springframework.data.mapping.model.ParameterValueProvider;
import org.springframework.jdbc.core.RowMapper;
import java.sql.ResultSet;
import java.sql.SQLException;
/**
* Maps a ResultSet to an entity of type {@code T}, including entities referenced.
*
@ -124,7 +125,8 @@ public class EntityRowMapper<T> implements RowMapper<T> { @@ -124,7 +125,8 @@ public class EntityRowMapper<T> implements RowMapper<T> {
return null;
}
S instance = instantiator.createInstance(entity, new ResultSetParameterValueProvider(rs, entity, conversions, prefix));
S instance = instantiator.createInstance(entity,
new ResultSetParameterValueProvider(rs, entity, conversions, prefix));
PersistentPropertyAccessor accessor = entity.getPropertyAccessor(instance);
ConvertingPropertyAccessor propertyAccessor = new ConvertingPropertyAccessor(accessor, conversions);
@ -139,14 +141,10 @@ public class EntityRowMapper<T> implements RowMapper<T> { @@ -139,14 +141,10 @@ public class EntityRowMapper<T> implements RowMapper<T> {
@RequiredArgsConstructor
private static class ResultSetParameterValueProvider implements ParameterValueProvider<JdbcPersistentProperty> {
@NonNull
private final ResultSet resultSet;
@NonNull
private final JdbcPersistentEntity<?> entity;
@NonNull
private final ConversionService conversionService;
@NonNull
private final String prefix;
@NonNull private final ResultSet resultSet;
@NonNull private final JdbcPersistentEntity<?> entity;
@NonNull private final ConversionService conversionService;
@NonNull private final String prefix;
/*
* (non-Javadoc)

4
src/test/java/org/springframework/data/jdbc/repository/config/EnableJdbcRepositoriesIntegrationTests.java

@ -63,11 +63,11 @@ public class EnableJdbcRepositoriesIntegrationTests { @@ -63,11 +63,11 @@ public class EnableJdbcRepositoriesIntegrationTests {
@Test // DATAJDBC-100
public void repositoryGetsPickedUp() {
assertNotNull(repository);
assertThat(repository).isNotNull();
Iterable<DummyEntity> all = repository.findAll();
assertNotNull(all);
assertThat(all).isNotNull();
}
@Test // DATAJDBC-166

Loading…
Cancel
Save