GitHub-Spring
/
spring-data-relational
mirror of https://github.com/spring-projects/spring-data-relational.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Unifying GitHub references to GH-nnn. 

Original pull request #903
See #578
pull/1002/head
Jens Schauder 5 years ago
parent
377d841284
commit
884332871e
No known key found for this signature in database
GPG Key ID: 45CC872F17423DBF
12 changed files with 43 additions and 43 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 2
      spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/BasicJdbcConverterUnitTests.java
  2. 4
      spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/DefaultDataAccessStrategyUnitTests.java
  3. 2
      spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/JdbcCustomConversionsUnitTests.java
  4. 2
      spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/dialect/JdbcDb2DialectUnitTests.java
  5. 2
      spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/dialect/JdbcMySqlDialectUnitTests.java
  6. 2
      spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/mapping/BasicJdbcPersistentPropertyUnitTests.java
  7. 16
      spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/JdbcRepositoryIntegrationTests.java
  8. 4
      spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/config/AbstractJdbcConfigurationIntegrationTests.java
  9. 2
      spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/query/PartTreeJdbcQueryUnitTests.java
  10. 2
      spring-data-relational/src/test/java/org/springframework/data/relational/core/sql/ConditionsUnitTests.java
  11. 4
      spring-data-relational/src/test/java/org/springframework/data/relational/core/sql/render/ConditionRendererUnitTests.java
  12. 44
      spring-data-relational/src/test/java/org/springframework/data/relational/repository/query/RelationalExampleMapperTests.java

2
spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/BasicJdbcConverterUnitTests.java
Unescape View File

@ -131,7 +131,7 @@ public class BasicJdbcConverterUnitTests {
} }
@Test // #945 @Test // GH-945
void conversionOfPrimitiveArrays() { void conversionOfPrimitiveArrays() {
int[] ints = { 1, 2, 3, 4, 5 }; int[] ints = { 1, 2, 3, 4, 5 };

4
spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/DefaultDataAccessStrategyUnitTests.java
Unescape View File

@ -193,7 +193,7 @@ public class DefaultDataAccessStrategyUnitTests {
assertThat(paramSourceCaptor.getValue().getValue("DUMMYENTITYROOT")).isEqualTo(rawId); assertThat(paramSourceCaptor.getValue().getValue("DUMMYENTITYROOT")).isEqualTo(rawId);
} }
@Test // #933 @Test // GH-933
public void insertWithDefinedIdDoesNotRetrieveGeneratedKeys() { public void insertWithDefinedIdDoesNotRetrieveGeneratedKeys() {
Object generatedId = accessStrategy.insert(new DummyEntity(ORIGINAL_ID), DummyEntity.class, Identifier.from(additionalParameters)); Object generatedId = accessStrategy.insert(new DummyEntity(ORIGINAL_ID), DummyEntity.class, Identifier.from(additionalParameters));
@ -204,7 +204,7 @@ public class DefaultDataAccessStrategyUnitTests {
paramSourceCaptor.capture()); paramSourceCaptor.capture());
} }
@Test // #933 @Test // GH-933
public void insertWithUndefinedIdRetrievesGeneratedKeys() { public void insertWithUndefinedIdRetrievesGeneratedKeys() {
when(namedJdbcOperations.update(any(), any(), any())) when(namedJdbcOperations.update(any(), any(), any()))

2
spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/JdbcCustomConversionsUnitTests.java
Unescape View File

@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test;
*/ */
class JdbcCustomConversionsUnitTests { class JdbcCustomConversionsUnitTests {
@Test // #937 @Test // GH-937
void registersNonDateDefaultConverter() { void registersNonDateDefaultConverter() {
JdbcCustomConversions conversions = new JdbcCustomConversions(); JdbcCustomConversions conversions = new JdbcCustomConversions();

2
spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/dialect/JdbcDb2DialectUnitTests.java
Unescape View File

@ -32,7 +32,7 @@ import org.springframework.data.jdbc.core.convert.JdbcCustomConversions;
*/ */
class JdbcDb2DialectUnitTests { class JdbcDb2DialectUnitTests {
@Test // #974 @Test // GH-974
void testCustomConversions() { void testCustomConversions() {
JdbcCustomConversions customConversions = new JdbcCustomConversions( JdbcCustomConversions customConversions = new JdbcCustomConversions(

2
spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/dialect/JdbcMySqlDialectUnitTests.java
Unescape View File

@ -32,7 +32,7 @@ import org.springframework.data.jdbc.core.convert.JdbcValue;
*/ */
class JdbcMySqlDialectUnitTests { class JdbcMySqlDialectUnitTests {
@Test // #974 @Test // GH-974
void testCustomConversions() { void testCustomConversions() {
JdbcCustomConversions customConversions = new JdbcCustomConversions( JdbcCustomConversions customConversions = new JdbcCustomConversions(

2
spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/mapping/BasicJdbcPersistentPropertyUnitTests.java
Unescape View File

@ -96,7 +96,7 @@ public class BasicJdbcPersistentPropertyUnitTests {
assertThat(listProperty.getReverseColumnName(path)).isEqualTo(quoted("override_id")); assertThat(listProperty.getReverseColumnName(path)).isEqualTo(quoted("override_id"));
} }
@Test // #938 @Test // GH-938
void considersAggregateReferenceAnAssociation() { void considersAggregateReferenceAnAssociation() {
RelationalPersistentEntity<?> entity = context.getRequiredPersistentEntity(DummyEntity.class); RelationalPersistentEntity<?> entity = context.getRequiredPersistentEntity(DummyEntity.class);

16
spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/JdbcRepositoryIntegrationTests.java
Unescape View File

@ -402,7 +402,7 @@ public class JdbcRepositoryIntegrationTests {
assertThat(repository.countByName(one.getName())).isEqualTo(2); assertThat(repository.countByName(one.getName())).isEqualTo(2);
} }
@Test // #945 @Test // GH-945
@EnabledOnFeature(TestDatabaseFeatures.Feature.IS_POSTGRES) @EnabledOnFeature(TestDatabaseFeatures.Feature.IS_POSTGRES)
public void usePrimitiveArrayAsArgument() { public void usePrimitiveArrayAsArgument() {
assertThat(repository.unnestPrimitive(new int[] { 1, 2, 3 })).containsExactly(1, 2, 3); assertThat(repository.unnestPrimitive(new int[] { 1, 2, 3 })).containsExactly(1, 2, 3);
@ -439,7 +439,7 @@ public class JdbcRepositoryIntegrationTests {
assertThat(slice.hasNext()).isTrue(); assertThat(slice.hasNext()).isTrue();
} }
@Test // #935 @Test // GH-935
public void queryByOffsetDateTime() { public void queryByOffsetDateTime() {
Instant now = createDummyBeforeAndAfterNow(); Instant now = createDummyBeforeAndAfterNow();
@ -450,7 +450,7 @@ public class JdbcRepositoryIntegrationTests {
assertThat(entities).extracting(DummyEntity::getName).containsExactly("second"); assertThat(entities).extracting(DummyEntity::getName).containsExactly("second");
} }
@Test // #971 @Test // GH-971
public void stringQueryProjectionShouldReturnProjectedEntities() { public void stringQueryProjectionShouldReturnProjectedEntities() {
repository.save(createDummyEntity()); repository.save(createDummyEntity());
@ -461,7 +461,7 @@ public class JdbcRepositoryIntegrationTests {
assertThat(result.get(0).getName()).isEqualTo("Entity Name"); assertThat(result.get(0).getName()).isEqualTo("Entity Name");
} }
@Test // #971 @Test // GH-971
public void stringQueryProjectionShouldReturnDtoProjectedEntities() { public void stringQueryProjectionShouldReturnDtoProjectedEntities() {
repository.save(createDummyEntity()); repository.save(createDummyEntity());
@ -472,7 +472,7 @@ public class JdbcRepositoryIntegrationTests {
assertThat(result.get(0).getName()).isEqualTo("Entity Name"); assertThat(result.get(0).getName()).isEqualTo("Entity Name");
} }
@Test // #971 @Test // GH-971
public void partTreeQueryProjectionShouldReturnProjectedEntities() { public void partTreeQueryProjectionShouldReturnProjectedEntities() {
repository.save(createDummyEntity()); repository.save(createDummyEntity());
@ -483,7 +483,7 @@ public class JdbcRepositoryIntegrationTests {
assertThat(result.get(0).getName()).isEqualTo("Entity Name"); assertThat(result.get(0).getName()).isEqualTo("Entity Name");
} }
@Test // #971 @Test // GH-971
public void pageQueryProjectionShouldReturnProjectedEntities() { public void pageQueryProjectionShouldReturnProjectedEntities() {
repository.save(createDummyEntity()); repository.save(createDummyEntity());
@ -494,14 +494,14 @@ public class JdbcRepositoryIntegrationTests {
assertThat(result.getContent().get(0).getName()).isEqualTo("Entity Name"); assertThat(result.getContent().get(0).getName()).isEqualTo("Entity Name");
} }
@Test // #974 @Test // GH-974
@EnabledOnFeature(TestDatabaseFeatures.Feature.IS_POSTGRES) @EnabledOnFeature(TestDatabaseFeatures.Feature.IS_POSTGRES)
void intervalCalculation() { void intervalCalculation() {
repository.updateWithIntervalCalculation(23L, LocalDateTime.now()); repository.updateWithIntervalCalculation(23L, LocalDateTime.now());
} }
@Test // #908 @Test // GH-908
void derivedQueryWithBooleanLiteralFindsCorrectValues() { void derivedQueryWithBooleanLiteralFindsCorrectValues() {
repository.save(createDummyEntity()); repository.save(createDummyEntity());

4
spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/config/AbstractJdbcConfigurationIntegrationTests.java
Unescape View File

@ -70,7 +70,7 @@ public class AbstractJdbcConfigurationIntegrationTests {
}, AbstractJdbcConfigurationUnderTest.class, Infrastructure.class); }, AbstractJdbcConfigurationUnderTest.class, Infrastructure.class);
} }
@Test // #975 @Test // GH-975
void registersSimpleTypesFromCustomConversions() { void registersSimpleTypesFromCustomConversions() {
assertApplicationContext(context -> { assertApplicationContext(context -> {
@ -84,7 +84,7 @@ public class AbstractJdbcConfigurationIntegrationTests {
}, AbstractJdbcConfigurationUnderTest.class, Infrastructure.class); }, AbstractJdbcConfigurationUnderTest.class, Infrastructure.class);
} }
@Test // #908 @Test // GH-908
void userProvidedConversionsOverwriteDialectSpecificConversions() { void userProvidedConversionsOverwriteDialectSpecificConversions() {
assertApplicationContext(applicationContext -> { assertApplicationContext(applicationContext -> {

2
spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/query/PartTreeJdbcQueryUnitTests.java
Unescape View File

@ -117,7 +117,7 @@ public class PartTreeJdbcQueryUnitTests {
assertThat(query.getQuery()).isEqualTo(BASE_SELECT + " WHERE " + TABLE + ".\"FIRST_NAME\" = :first_name"); assertThat(query.getQuery()).isEqualTo(BASE_SELECT + " WHERE " + TABLE + ".\"FIRST_NAME\" = :first_name");
} }
@Test // #971 @Test // GH-971
public void createsQueryToFindAllEntitiesByProjectionAttribute() throws Exception { public void createsQueryToFindAllEntitiesByProjectionAttribute() throws Exception {
when(returnedType.needsCustomConstruction()).thenReturn(true); when(returnedType.needsCustomConstruction()).thenReturn(true);

2
spring-data-relational/src/test/java/org/springframework/data/relational/core/sql/ConditionsUnitTests.java
Unescape View File

@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test;
*/ */
class ConditionsUnitTests { class ConditionsUnitTests {
@Test // #916 @Test // GH-916
void notInOfColumnAndExpression() { void notInOfColumnAndExpression() {
Table table = Table.create("t"); Table table = Table.create("t");

4
spring-data-relational/src/test/java/org/springframework/data/relational/core/sql/render/ConditionRendererUnitTests.java
Unescape View File

@ -233,7 +233,7 @@ public class ConditionRendererUnitTests {
assertThat(sql).endsWith("WHERE my_table.left NOT IN (my_table.right)"); assertThat(sql).endsWith("WHERE my_table.left NOT IN (my_table.right)");
} }
@Test // #907 @Test // GH-907
public void shouldRenderJust() { public void shouldRenderJust() {
String sql = SqlRenderer.toString(StatementBuilder.select(left).from(table) String sql = SqlRenderer.toString(StatementBuilder.select(left).from(table)
@ -243,7 +243,7 @@ public class ConditionRendererUnitTests {
assertThat(sql).endsWith("WHERE sql"); assertThat(sql).endsWith("WHERE sql");
} }
@Test // #907 @Test // GH-907
public void shouldRenderMultipleJust() { public void shouldRenderMultipleJust() {
String sql = SqlRenderer.toString(StatementBuilder.select(left).from(table) String sql = SqlRenderer.toString(StatementBuilder.select(left).from(table)

44
spring-data-relational/src/test/java/org/springframework/data/relational/repository/query/RelationalExampleMapperTests.java
Unescape View File

@ -49,7 +49,7 @@ public class RelationalExampleMapperTests {
exampleMapper = new RelationalExampleMapper(new RelationalMappingContext()); exampleMapper = new RelationalExampleMapper(new RelationalMappingContext());
} }
@Test // #929 @Test // GH-929
void queryByExampleWithId() { void queryByExampleWithId() {
Person person = new Person(); Person person = new Person();
@ -64,7 +64,7 @@ public class RelationalExampleMapperTests {
.hasValue("(id = 'id1')"); .hasValue("(id = 'id1')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstname() { void queryByExampleWithFirstname() {
Person person = new Person(); Person person = new Person();
@ -79,7 +79,7 @@ public class RelationalExampleMapperTests {
.hasValue("(firstname = 'Frodo')"); .hasValue("(firstname = 'Frodo')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameAndLastname() { void queryByExampleWithFirstnameAndLastname() {
Person person = new Person(); Person person = new Person();
@ -95,7 +95,7 @@ public class RelationalExampleMapperTests {
.hasValue("(firstname = 'Frodo') AND (lastname = 'Baggins')"); .hasValue("(firstname = 'Frodo') AND (lastname = 'Baggins')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithNullMatchingLastName() { void queryByExampleWithNullMatchingLastName() {
Person person = new Person(); Person person = new Person();
@ -111,7 +111,7 @@ public class RelationalExampleMapperTests {
.hasValue("(lastname IS NULL OR lastname = 'Baggins')"); .hasValue("(lastname IS NULL OR lastname = 'Baggins')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithNullMatchingFirstnameAndLastname() { void queryByExampleWithNullMatchingFirstnameAndLastname() {
Person person = new Person(); Person person = new Person();
@ -128,7 +128,7 @@ public class RelationalExampleMapperTests {
.hasValue("(firstname IS NULL OR firstname = 'Bilbo') AND (lastname IS NULL OR lastname = 'Baggins')"); .hasValue("(firstname IS NULL OR firstname = 'Bilbo') AND (lastname IS NULL OR lastname = 'Baggins')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameAndLastnameIgnoringFirstname() { void queryByExampleWithFirstnameAndLastnameIgnoringFirstname() {
Person person = new Person(); Person person = new Person();
@ -145,7 +145,7 @@ public class RelationalExampleMapperTests {
.hasValue("(lastname = 'Baggins')"); .hasValue("(lastname = 'Baggins')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameAndLastnameWithNullMatchingIgnoringFirstName() { void queryByExampleWithFirstnameAndLastnameWithNullMatchingIgnoringFirstName() {
Person person = new Person(); Person person = new Person();
@ -162,7 +162,7 @@ public class RelationalExampleMapperTests {
.hasValue("(lastname IS NULL OR lastname = 'Baggins')"); .hasValue("(lastname IS NULL OR lastname = 'Baggins')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameWithStringMatchingAtTheBeginning() { void queryByExampleWithFirstnameWithStringMatchingAtTheBeginning() {
Person person = new Person(); Person person = new Person();
@ -178,7 +178,7 @@ public class RelationalExampleMapperTests {
.hasValue("(firstname LIKE 'Fro%')"); .hasValue("(firstname LIKE 'Fro%')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameWithStringMatchingOnTheEnding() { void queryByExampleWithFirstnameWithStringMatchingOnTheEnding() {
Person person = new Person(); Person person = new Person();
@ -194,7 +194,7 @@ public class RelationalExampleMapperTests {
.hasValue("(firstname LIKE '%do')"); .hasValue("(firstname LIKE '%do')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameWithStringMatchingContaining() { void queryByExampleWithFirstnameWithStringMatchingContaining() {
Person person = new Person(); Person person = new Person();
@ -210,7 +210,7 @@ public class RelationalExampleMapperTests {
.hasValue("(firstname LIKE '%do%')"); .hasValue("(firstname LIKE '%do%')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameWithStringMatchingRegEx() { void queryByExampleWithFirstnameWithStringMatchingRegEx() {
Person person = new Person(); Person person = new Person();
@ -223,7 +223,7 @@ public class RelationalExampleMapperTests {
.withMessageContaining("REGEX is not supported!"); .withMessageContaining("REGEX is not supported!");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameWithFieldSpecificStringMatcherEndsWith() { void queryByExampleWithFirstnameWithFieldSpecificStringMatcherEndsWith() {
Person person = new Person(); Person person = new Person();
@ -239,7 +239,7 @@ public class RelationalExampleMapperTests {
.hasValue("(firstname LIKE '%do')"); .hasValue("(firstname LIKE '%do')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameWithFieldSpecificStringMatcherStartsWith() { void queryByExampleWithFirstnameWithFieldSpecificStringMatcherStartsWith() {
Person person = new Person(); Person person = new Person();
@ -255,7 +255,7 @@ public class RelationalExampleMapperTests {
.hasValue("(firstname LIKE 'Fro%')"); .hasValue("(firstname LIKE 'Fro%')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameWithFieldSpecificStringMatcherContains() { void queryByExampleWithFirstnameWithFieldSpecificStringMatcherContains() {
Person person = new Person(); Person person = new Person();
@ -271,7 +271,7 @@ public class RelationalExampleMapperTests {
.hasValue("(firstname LIKE '%do%')"); .hasValue("(firstname LIKE '%do%')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameWithStringMatchingAtTheBeginningIncludingNull() { void queryByExampleWithFirstnameWithStringMatchingAtTheBeginningIncludingNull() {
Person person = new Person(); Person person = new Person();
@ -287,7 +287,7 @@ public class RelationalExampleMapperTests {
.hasValue("(firstname IS NULL OR firstname LIKE 'Fro%')"); .hasValue("(firstname IS NULL OR firstname LIKE 'Fro%')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameWithStringMatchingOnTheEndingIncludingNull() { void queryByExampleWithFirstnameWithStringMatchingOnTheEndingIncludingNull() {
Person person = new Person(); Person person = new Person();
@ -303,7 +303,7 @@ public class RelationalExampleMapperTests {
.hasValue("(firstname IS NULL OR firstname LIKE '%do')"); .hasValue("(firstname IS NULL OR firstname LIKE '%do')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameIgnoreCaseFieldLevel() { void queryByExampleWithFirstnameIgnoreCaseFieldLevel() {
Person person = new Person(); Person person = new Person();
@ -321,7 +321,7 @@ public class RelationalExampleMapperTests {
assertThat(example.getMatcher().getPropertySpecifiers().getForPath("firstname").getIgnoreCase()).isTrue(); assertThat(example.getMatcher().getPropertySpecifiers().getForPath("firstname").getIgnoreCase()).isTrue();
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameWithStringMatchingContainingIncludingNull() { void queryByExampleWithFirstnameWithStringMatchingContainingIncludingNull() {
Person person = new Person(); Person person = new Person();
@ -337,7 +337,7 @@ public class RelationalExampleMapperTests {
.hasValue("(firstname IS NULL OR firstname LIKE '%do%')"); .hasValue("(firstname IS NULL OR firstname LIKE '%do%')");
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameIgnoreCase() { void queryByExampleWithFirstnameIgnoreCase() {
Person person = new Person(); Person person = new Person();
@ -355,7 +355,7 @@ public class RelationalExampleMapperTests {
assertThat(example.getMatcher().isIgnoreCaseEnabled()).isTrue(); assertThat(example.getMatcher().isIgnoreCaseEnabled()).isTrue();
} }
@Test // #929 @Test // GH-929
void queryByExampleWithFirstnameOrLastname() { void queryByExampleWithFirstnameOrLastname() {
Person person = new Person(); Person person = new Person();
@ -372,7 +372,7 @@ public class RelationalExampleMapperTests {
.hasValue("(firstname = 'Frodo') OR (lastname = 'Baggins')"); .hasValue("(firstname = 'Frodo') OR (lastname = 'Baggins')");
} }
@Test // #929 @Test // GH-929
void queryByExampleEvenHandlesInvisibleFields() { void queryByExampleEvenHandlesInvisibleFields() {
Person person = new Person(); Person person = new Person();
@ -388,7 +388,7 @@ public class RelationalExampleMapperTests {
.hasValue("(firstname = 'Frodo') AND (secret = 'I have the ring!')"); .hasValue("(firstname = 'Frodo') AND (secret = 'I have the ring!')");
} }
@Test // #929 @Test // GH-929
void queryByExampleSupportsPropertyTransforms() { void queryByExampleSupportsPropertyTransforms() {
Person person = new Person(); Person person = new Person();

Write Preview
Loading…
Cancel
Save