Browse Source

DATAJDBC-493 - Polishing.

Reformat code. Introduce assertions.
pull/217/head
Mark Paluch 6 years ago
parent
commit
0448148bec
No known key found for this signature in database
GPG Key ID: 51A00FA751B91849
  1. 3
      spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/LockMode.java
  2. 9
      spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/LockOptions.java
  3. 8
      spring-data-relational/src/test/java/org/springframework/data/relational/core/dialect/SqlServerDialectUnitTests.java

3
spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/LockMode.java

@ -23,6 +23,5 @@ package org.springframework.data.relational.core.sql;
*/ */
public enum LockMode { public enum LockMode {
PESSIMISTIC_READ, PESSIMISTIC_READ, PESSIMISTIC_WRITE
PESSIMISTIC_WRITE
} }

9
spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/LockOptions.java

@ -15,8 +15,10 @@
*/ */
package org.springframework.data.relational.core.sql; package org.springframework.data.relational.core.sql;
import org.springframework.util.Assert;
/** /**
* LockOptions has a LOCK option to apply to the Select statement. * Value object providing lock options to apply to a {@link Select} statement.
* *
* @author Myeonghyeon Lee * @author Myeonghyeon Lee
* @since 2.0 * @since 2.0
@ -26,7 +28,10 @@ public class LockOptions {
private final LockMode lockMode; private final LockMode lockMode;
private final From from; private final From from;
public LockOptions(LockMode lockMode, From from) { public LockOptions(LockMode lockMode, From from) {
Assert.notNull(lockMode, "LockMode must not be null");
Assert.notNull(from, "From must not be null");
this.lockMode = lockMode; this.lockMode = lockMode;
this.from = from; this.from = from;

8
spring-data-relational/src/test/java/org/springframework/data/relational/core/dialect/SqlServerDialectUnitTests.java

@ -15,15 +15,15 @@
*/ */
package org.springframework.data.relational.core.dialect; package org.springframework.data.relational.core.dialect;
import static org.assertj.core.api.Assertions.*;
import static org.mockito.Mockito.*;
import org.junit.Test; import org.junit.Test;
import org.springframework.data.relational.core.sql.From; import org.springframework.data.relational.core.sql.From;
import org.springframework.data.relational.core.sql.LockMode; import org.springframework.data.relational.core.sql.LockMode;
import org.springframework.data.relational.core.sql.LockOptions; import org.springframework.data.relational.core.sql.LockOptions;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.Mockito.mock;
/** /**
* Unit tests for {@link SqlServerDialect}. * Unit tests for {@link SqlServerDialect}.
* *

Loading…
Cancel
Save