Browse Source
Using keywords remove or delete in derived query, or setting @Query(delete=true) removes documents matching the query. If the return type is assignable to Number, the total number of affected documents is returned. In case the return type is collection like the query is executed against the store in first place. All documents included in the resulting collection are deleted in a subsequent call. Additionally findAllAndRemove(…) methods have been added to MongoTemplate. Original pull request: #147.pull/151/merge
Christoph Strobl
12 years ago
committed by
Oliver Gierke
14 changed files with 666 additions and 38 deletions
@ -0,0 +1,202 @@ |
|||||||
|
/* |
||||||
|
* Copyright 2014 the original author or authors. |
||||||
|
* |
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License"); |
||||||
|
* you may not use this file except in compliance with the License. |
||||||
|
* You may obtain a copy of the License at |
||||||
|
* |
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
* |
||||||
|
* Unless required by applicable law or agreed to in writing, software |
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS, |
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
||||||
|
* See the License for the specific language governing permissions and |
||||||
|
* limitations under the License. |
||||||
|
*/ |
||||||
|
package org.springframework.data.mongodb.repository.query; |
||||||
|
|
||||||
|
import static org.junit.Assert.*; |
||||||
|
import static org.mockito.Mockito.*; |
||||||
|
|
||||||
|
import java.lang.reflect.Method; |
||||||
|
import java.util.Arrays; |
||||||
|
import java.util.Date; |
||||||
|
import java.util.List; |
||||||
|
|
||||||
|
import org.bson.types.ObjectId; |
||||||
|
import org.hamcrest.core.Is; |
||||||
|
import org.junit.Before; |
||||||
|
import org.junit.Test; |
||||||
|
import org.junit.runner.RunWith; |
||||||
|
import org.mockito.Matchers; |
||||||
|
import org.mockito.Mock; |
||||||
|
import org.mockito.runners.MockitoJUnitRunner; |
||||||
|
import org.springframework.data.mongodb.MongoDbFactory; |
||||||
|
import org.springframework.data.mongodb.core.MongoOperations; |
||||||
|
import org.springframework.data.mongodb.core.Person; |
||||||
|
import org.springframework.data.mongodb.core.convert.DbRefResolver; |
||||||
|
import org.springframework.data.mongodb.core.convert.DefaultDbRefResolver; |
||||||
|
import org.springframework.data.mongodb.core.convert.MappingMongoConverter; |
||||||
|
import org.springframework.data.mongodb.core.mapping.BasicMongoPersistentEntity; |
||||||
|
import org.springframework.data.mongodb.core.mapping.MongoMappingContext; |
||||||
|
import org.springframework.data.mongodb.core.query.BasicQuery; |
||||||
|
import org.springframework.data.mongodb.core.query.Query; |
||||||
|
import org.springframework.data.mongodb.repository.MongoRepository; |
||||||
|
import org.springframework.data.repository.core.RepositoryMetadata; |
||||||
|
|
||||||
|
import com.mongodb.WriteResult; |
||||||
|
|
||||||
|
/** |
||||||
|
* @author Christoph Strobl |
||||||
|
*/ |
||||||
|
@RunWith(MockitoJUnitRunner.class) |
||||||
|
public class MongoQueryExecutionUnitTests { |
||||||
|
|
||||||
|
private @Mock RepositoryMetadata metadataMock; |
||||||
|
|
||||||
|
private @Mock MongoOperations mongoOperationsMock; |
||||||
|
|
||||||
|
@SuppressWarnings("rawtypes")//
|
||||||
|
private @Mock BasicMongoPersistentEntity persitentEntityMock; |
||||||
|
|
||||||
|
private @Mock MongoMappingContext mappingContextMock; |
||||||
|
|
||||||
|
private @Mock WriteResult writeResultMock; |
||||||
|
|
||||||
|
@SuppressWarnings({ "unchecked", "rawtypes" }) |
||||||
|
@Before |
||||||
|
public void setUp() { |
||||||
|
|
||||||
|
when(metadataMock.getDomainType()).thenReturn((Class) Person.class); |
||||||
|
when(metadataMock.getReturnedDomainClass(Matchers.any(Method.class))).thenReturn((Class) Person.class); |
||||||
|
when(persitentEntityMock.getCollection()).thenReturn("persons"); |
||||||
|
|
||||||
|
when(mappingContextMock.getPersistentEntity(Matchers.any(Class.class))).thenReturn(persitentEntityMock); |
||||||
|
|
||||||
|
when(persitentEntityMock.getType()).thenReturn(Person.class); |
||||||
|
DbRefResolver dbRefResolver = new DefaultDbRefResolver(mock(MongoDbFactory.class)); |
||||||
|
MappingMongoConverter converter = new MappingMongoConverter(dbRefResolver, mappingContextMock); |
||||||
|
converter.afterPropertiesSet(); |
||||||
|
|
||||||
|
when(mongoOperationsMock.getConverter()).thenReturn(converter); |
||||||
|
} |
||||||
|
|
||||||
|
/** |
||||||
|
* @see DATAMONGO-566 |
||||||
|
*/ |
||||||
|
@SuppressWarnings("unchecked") |
||||||
|
@Test |
||||||
|
public void testDeleteExecutionCallsRemoveCorreclty() { |
||||||
|
|
||||||
|
createQueryForMethod("deletePersonByLastname", String.class).setDeleteQuery(true).execute(new Object[] { "booh" }); |
||||||
|
verify(this.mongoOperationsMock, times(1)).remove(Matchers.any(Query.class), Matchers.eq("persons")); |
||||||
|
verify(this.mongoOperationsMock, times(0)).find(Matchers.any(Query.class), Matchers.any(Class.class), |
||||||
|
Matchers.anyString()); |
||||||
|
} |
||||||
|
|
||||||
|
/** |
||||||
|
* @see DATAMONGO-566 |
||||||
|
*/ |
||||||
|
@SuppressWarnings("unchecked") |
||||||
|
@Test |
||||||
|
public void testDeleteExecutionLoadsListOfRemovedDocumentsWhenReturnTypeIsCollectionLike() { |
||||||
|
|
||||||
|
when(this.mongoOperationsMock.find(Matchers.any(Query.class), Matchers.any(Class.class), Matchers.anyString())) |
||||||
|
.thenReturn(Arrays.asList(new Person(new ObjectId(new Date()), "bar"))); |
||||||
|
|
||||||
|
createQueryForMethod("deleteByLastname", String.class).setDeleteQuery(true).execute(new Object[] { "booh" }); |
||||||
|
|
||||||
|
verify(this.mongoOperationsMock, times(1)).findAllAndRemove(Matchers.any(Query.class), Matchers.eq(Person.class)); |
||||||
|
} |
||||||
|
|
||||||
|
/** |
||||||
|
* @see DATAMONGO-566 |
||||||
|
*/ |
||||||
|
@Test |
||||||
|
public void testDeleteExecutionReturnsZeroWhenWriteResultIsNull() { |
||||||
|
|
||||||
|
MongoQueryFake query = createQueryForMethod("deletePersonByLastname", String.class); |
||||||
|
query.setDeleteQuery(true); |
||||||
|
|
||||||
|
assertThat(query.execute(new Object[] { "fake" }), Is.<Object> is(0L)); |
||||||
|
} |
||||||
|
|
||||||
|
/** |
||||||
|
* @see DATAMONGO-566 |
||||||
|
*/ |
||||||
|
@Test |
||||||
|
public void testDeleteExecutionReturnsNrDocumentsDeletedFromWriteResult() { |
||||||
|
|
||||||
|
when(writeResultMock.getN()).thenReturn(100); |
||||||
|
when(this.mongoOperationsMock.remove(Matchers.any(Query.class), Matchers.eq("persons"))) |
||||||
|
.thenReturn(writeResultMock); |
||||||
|
|
||||||
|
MongoQueryFake query = createQueryForMethod("deletePersonByLastname", String.class); |
||||||
|
query.setDeleteQuery(true); |
||||||
|
|
||||||
|
assertThat(query.execute(new Object[] { "fake" }), Is.<Object> is(100L)); |
||||||
|
|
||||||
|
verify(this.mongoOperationsMock, times(1)).remove(Matchers.any(Query.class), Matchers.eq("persons")); |
||||||
|
} |
||||||
|
|
||||||
|
private MongoQueryFake createQueryForMethod(String methodName, Class<?>... paramTypes) { |
||||||
|
try { |
||||||
|
return this.createQueryForMethod(Repo.class.getMethod(methodName, paramTypes)); |
||||||
|
} catch (NoSuchMethodException e) { |
||||||
|
throw new IllegalArgumentException(e.getMessage(), e); |
||||||
|
} catch (SecurityException e) { |
||||||
|
throw new IllegalArgumentException(e.getMessage(), e); |
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
private MongoQueryFake createQueryForMethod(Method method) { |
||||||
|
return new MongoQueryFake(createMongoQueryMethodFrom(method), this.mongoOperationsMock); |
||||||
|
} |
||||||
|
|
||||||
|
private MongoQueryMethod createMongoQueryMethodFrom(Method method) { |
||||||
|
return new MongoQueryMethod(method, metadataMock, this.mappingContextMock); |
||||||
|
} |
||||||
|
|
||||||
|
class MongoQueryFake extends AbstractMongoQuery { |
||||||
|
|
||||||
|
public MongoQueryFake(MongoQueryMethod method, MongoOperations operations) { |
||||||
|
super(method, operations); |
||||||
|
} |
||||||
|
|
||||||
|
private boolean isCountQuery; |
||||||
|
private boolean isDeleteQuery; |
||||||
|
|
||||||
|
@Override |
||||||
|
protected Query createQuery(ConvertingParameterAccessor accessor) { |
||||||
|
return new BasicQuery("{'foo':'bar'}"); |
||||||
|
} |
||||||
|
|
||||||
|
@Override |
||||||
|
protected boolean isCountQuery() { |
||||||
|
return isCountQuery; |
||||||
|
} |
||||||
|
|
||||||
|
@Override |
||||||
|
protected boolean isDeleteQuery() { |
||||||
|
return isDeleteQuery; |
||||||
|
} |
||||||
|
|
||||||
|
public MongoQueryFake setCountQuery(boolean isCountQuery) { |
||||||
|
this.isCountQuery = isCountQuery; |
||||||
|
return this; |
||||||
|
} |
||||||
|
|
||||||
|
public MongoQueryFake setDeleteQuery(boolean isDeleteQuery) { |
||||||
|
this.isDeleteQuery = isDeleteQuery; |
||||||
|
return this; |
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
private interface Repo extends MongoRepository<Person, Long> { |
||||||
|
|
||||||
|
List<Person> deleteByLastname(String lastname); |
||||||
|
|
||||||
|
Long deletePersonByLastname(String lastname); |
||||||
|
} |
||||||
|
|
||||||
|
} |
||||||
Loading…
Reference in new issue